Page MenuHomePhabricator

Stabilize sorting of feed stories with similar strength
ClosedPublic

Authored by epriestley on May 22 2019, 12:04 AM.

Details

Summary

See PHI1222. When we publish several transactions to feed at once, we sort them by "action strength" to figure out which one gets to be the title story.

This sort currently uses msort(), which uses asort(), which is not a stable sort and has inconsistent behavior across PHP versions:

Switch to msortv(), which is a stable sort. Previously, see also T6861.

If all transactions have the same strength, we'll now consistently pick the first one.

This probably (?) does not impact anything in the upstream, but is good from a consistency point of view.

Test Plan

Top story was published after this change and uses the chronologically first transaction as the title story.

Bottom story was published before this change and uses the chronologically second transaction as the title story.

Both stories have two transactions with the same strength ("create" + "add reviewer").

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 22 2019, 12:04 AM
epriestley requested review of this revision.May 22 2019, 12:05 AM
amckinley edited the summary of this revision. (Show Details)May 22 2019, 9:15 PM
amckinley accepted this revision.May 22 2019, 9:18 PM
This revision is now accepted and ready to land.May 22 2019, 9:18 PM

Reading PHI1222; nice catch!

richardvanvelzen added inline comments.
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
1364–1395

Just a quick note - the other values were multiplied by 100 whereas these are by 1000. This causes more useful transactions (like accepting a revision) to have a lower action strength.

epriestley added inline comments.Jun 26 2019, 1:59 PM
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
1364–1395

Thanks! See D20622.