Page MenuHomePhabricator

Add a "Batch Edit Tasks..." action to workboard columns
ClosedPublic

Authored by epriestley on Apr 20 2015, 12:13 PM.

Details

Summary

Ref T5523. Adds a new workflow to make some kinds of bulk workboard operations easier.

New dropdown action:

This brings you into the existing bulk edit flow:

When you save an edit, you're taken back to the board:

If you try to edit a column with nothing in it, you get an error:

Note that the selected workboard filter is applied before choosing tasks, so if your filter is set to "open tasks" we only batch edit the open (i.e., currently visible) tasks in the column. I think this is more powerful (it lets you use filtering to select task subsets) but might not be completely obvious in all cases (although I do think it's more obvious than the alternative rule -- just an issue of neither rule being completely obvious).

Test Plan
  • Batch edited tasks in a column.
  • Used "Batch Edit Tasks..." to move tasks to a different workboard by removing + adding a project.
  • Batch edited a column with filtered-out tasks, verified only visible tasks were edited.
  • Batch edited a column with no visible tasks, received error.
  • Used the batch editor normally (Maniphest -> Maniphest, no boards).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Add a "Batch Edit Tasks..." action to workboard columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a project: Prioritized.
  • Respect "Can Batch Edit" capability to disable menu item.
  • Add an action to edit every visible task on the whole board.

  • Minor cleanup; magic string -> constant.

I think if this kept the filter & export buttons it would cover most of T5024 and obsolete my sketchy D10610 as well.

johnny-bit added a subscriber: johnny-bit.

I'd tentatively like to make that a separate action like "View as Query Results...". (I considered just doing that as the default and letting you explicitly move into the batch editor from there, but jumping directly to the batch editor feels pretty useful in a lot of cases.)

We could also show all the "do stuff with query results" options on the batch edit page, potentially, although it's not exactly clear what those will look like in the future. I'd want to wait for more clarity on T5307 before pursuing that.

We could give you tools for adjusting the result set (add/remove specific items) on the batch edit page.

You can apply filters indirectly by filtering the board first, then batch editing, but there's no way to do this granularly (at the level of individual tasks) and no way to get from there to export right now (except by copy/pasting things in the URL).

btrahan accepted this revision.Apr 20 2015, 5:04 PM
btrahan edited edge metadata.

This seems great to me for a first iteration!

We could also show all the "do stuff with query results" options on the batch edit page, potentially, although it's not exactly clear what those will look like in the future. I'd want to wait for more clarity on T5307 before pursuing that.

Sounds good. I think the missing bit to me here is being able to see the search you just ran (project: x, column: y, task status: open) and modify that as desired.

We could give you tools for adjusting the result set (add/remove specific items) on the batch edit page.

This sounds nice. I think there might be a little implementation complexity if you want to be able to remove specific items and also have the search UI update properly to reflect that as a search.

This revision is now accepted and ready to land.Apr 20 2015, 5:04 PM
This revision was automatically updated to reflect the committed changes.