There were no commits between friday and today, so I'm not following what you're trying to tell us.

Everyone loves Opportunities For Improvement!

This stuff is probably going to churn for a bit but I'm pretty sure I'll forget about that thing if I don't write it down somewhere.

In View Options → Collapse File, we get into this sort of oldschool state:

Just merging this over to Facts, I don't anticipate allocating any resources to Maniphest reports before Facts ships.

T10469 is vaguely related.

I had a friend once which I think had a fejolollololal farm.

I couldn't find them either but I understand:

I've been terribly unlucky in locating fejolollololals in any grocery store here on the East "coast".

ah,k

Oh, isViewableInBrowser() is the wrong check, and includes things like text files. Should be isViewableImage().

Might be pre-existing. Source file is:

How are you creating macros with non-viewable images?

The works here are on behalf of Solus, for the Solus infrastructure, and not that of my employer, and as such have blanket "own time approval" for the umbrella "Solus Project". This much I can do. Signing a CLA of any description for any purpose is what would entangle employers, something I cannot do.

At this time I'm presently unable to sign a CLA (apologies) due to employment situation, however what I can do is make the following diff Public Domain and relinquish any claims to it, should Phacility wish to correct this behaviour in upstream Phabricator.

• Override willConfigureFields() in MacroEditEngine.
  • This fires after extensions add fields (so "Subscribers" will exist), but before form configuration acts (so users will still be able to turn the field on if they really want, by creating a form which enables it).
  • $fields is indexed by by field key. Ideally, we'd move 'subscriberPHIDs' to some constant on PhabricatorSubscriptionsEditEngineExtension, then use that, something like this:

• I couldn't realllly find any bona fide new issues with Ponder.

Just the input on the create form, not the feature wholesale, right? Let me finish up (just Ponder left) and then I'll dig it up, I'm pretty sure there's a method you can use for it but we don't do it very often.

How do I remove subscribers from Macro, btw.

👍

Sidenote, it does turn out that in any instance, this will require some kind of empty commit for HEAD to exist, i.e. Repo constructed - but this change at least allows the empty commit to work.

Actually, I think T5791 is most correct.

• Added space

When using Mercurial, can Diffusion handle multiple remote bookmarks on the same branch?

space very important

Sorry about that! Thanks for the report.

Possibly we should just remove this flag because bin/storage status is equivalent and bin/storage adjust prompts by default, buuut...

guess macro has a bug too

Us right now:

Not at all! You can just buy an extremely expensive personal support plan and continue controlling 100% of the roadmap based on personal whim!

Ugh, so I have to come up with reasonable arguments now instead of just paying for features?

I've just removed mentions from Consulting, but that should eventually be updated when this is formally available.