`storage --dry-run` actually looks rather wet when applying patches
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	alexmv
	May 6 2017, 2:15 AM

Description

The refactoring in D16912 looks to have made storage --dry-run actually be wet. Namely:

if ($is_dryrun) {
  echo tsprintf(
    "%s\n",
    pht(
      'DRYRUN: Would apply patch "%s" to host "%s".',
      $key,
      $ref_key));
} else {
  echo tsprintf(
    "%s\n",
    pht(
      'Applying patch "%s" to host "%s"...',
      $key,
      $ref_key));
}

$t_begin = microtime(true);
$api->applyPatch($patch);
$t_end = microtime(true);

...looks to apply the patch regardless of the --dry-run flag. That is certainly what we just observed in production, as well.

Running rP 2017 week 17.

Revisions and Commits

rP Phabricator
	D17837	rPb0df33e6ecd7 (stable) Don't apply patches or mark patches applied with `bin/storage upgrade…
	D17837	rPbcd87e0e3f37 Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun`