Page MenuHomePhabricator
Create Task
Maniphest T4751

`arc patch` fails in empty repositories
Open, NormalPublic
Actions

Description

From @bitglue:

pfrost@zoom:~/Documents$ git clone git@git:puppet-macpros_jenkins test
Cloning into 'test'...
warning: You appear to have cloned an empty repository.
Checking connectivity... done
pfrost@zoom:~/Documents$ cd test/
pfrost@zoom:~/Documents/test$ arc patch D7
Exception
Command failed with error #128!
COMMAND
git diff --no-ext-diff --no-textconv --raw 'HEAD' --

STDOUT
(empty)

STDERR
fatal: bad revision 'HEAD'

(Run with --trace for a full exception trace.)
pfrost@zoom:~/Documents/test$

We probably need some special casing for empty repositories (like we have in various other places), since HEAD isn't meaningful when a repo is empty.

Related Objects

Event Timeline

epriestley created this task.Apr 7 2014, 3:14 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Arcanist.
epriestley added subscribers: epriestley, • bitglue.
• bitglue added a comment.EditedApr 9 2014, 2:07 PM

A rather poor workaround is:

$ git clone git@git:puppet-macpros_jenkins test
$ cd test/
$ git commit --allow-empty -m 'initial commit'
$ arc patch D7 --nobranch --nocommit

Not quite the desired behavior, but it does at least get the changes into a working directory. Even better might be to initialize repositories with an empty commit before arc diff, avoiding this issue, whilst still passing all changes through review.

joshuaspence added a subscriber: joshuaspence.May 29 2015, 9:53 AM
epriestley moved this task from Backlog to arc patch on the Arcanist board.Feb 11 2016, 6:35 PM
epriestley merged a task: T12686: Arcanist unable to patch with initial commit.May 7 2017, 5:54 PM
epriestley added a subscriber: ikeydoherty.
Herald added a subscriber: eadler. · View Herald TranscriptMay 7 2017, 5:54 PM
Phabricator · Built by Phacility