Page MenuHomePhabricator

Dialog box closes with ESC key even when there's unsaved change
Open, Needs TriagePublic

Description

Hello,

I'm not sure it can be categorized as a bug, but it's one of those things that make people angry :)

The most concrete example is:

  • Go to a Project's Workboard
  • Create a new Task from the column drop down menu
  • Edit your task with a lot of useful information
  • Press ESC on the keyboard
  • Bye bye all your information

Expected result: An other dialog asking if you really want to close the window and loose your changes. It should probably behave differently than the Cancel button.

Cheers,
Jean-Baptiste

Event Timeline

aubort created this task.May 5 2017, 1:46 PM
aubort updated the task description. (Show Details)May 5 2017, 1:49 PM
chad added a subscriber: chad.May 5 2017, 2:25 PM

Is this something you actually encountered and lost data?

aubort added a comment.May 5 2017, 2:33 PM

Yes, here's the testimony of one of our user,

I was filing a bug report for a project. I opened the task from the project workboard, using the dropdown menu beside "bugs". While typing the bug report, I hit the escape key while trying to quote a some text, which appears to close the task, losing all input information.

It would be nice if this was not lost inadvertently based on a single keystroke.

FWIW this behavior has also caused data loss on our team more than once. I'll usually trigger it when I'm going to insert a backtick somewhere in the task description to block off pseudocode and I fat-finger Esc instead.

T10469 is vaguely related.