Let me take this back for a bit.

In D10337#164167, @epriestley wrote:

The use of yyerror() explicitly is unusual, and does not seem to come from zend_language_parser.y. I'd rather see this prevented by the grammar itself. It looks like zend_language_parser.y accomplished this purely with grammar rules, at least as of 5.5.14 (the copy of the PHP source I have handy locally).

I wouldn't have expected the issue to be in xhpast at all. Thanks for the quick resolution!

We mitigated with:

Seems to have gone okay to me

I suddenly feel all important-y and stuff

So the preview didn't show the text on multiple lines. :/

Hahaha I suddenly remembered this

This would also make something like this parse badly:

https://wiki.php.net/phpng-upgrading should contain a lot of relevant information.

The mixed syntax is actually invalid. (Maybe known, just saw this one fly by)

aww

I have email notifications disabled wherever possible. When I shut down my computer, it'd be super useful to be able to get push notifications to my phone.

Wouldn't setting the view policy to "nobody" achieve pretty much the same?

Missing finally support is now starting to affect a large portion of my colleagues.

You can do this:

1. Some
# Item

Works like a charm now. :-)

Sorry, I think that did not fully resolve the issue - I still get the same exception after upgrading.

(Probably occurs thanks to D13283)

As per IRC:

[20:56:34] <_richardJ> I have a commit for which an Owners package of which I'm an owner requires an audit because of "owners not involved". However, I reviewed the actual revision.

At least Python and Mercurial itself use tags extensively, and there are many more projects that do.

Somewhat already mentioned a few times, but these are the two things me and co-workers noticed after using this feature for a while:

• The comments seem way too large to me. (We have a lot of inline discussion, probably a lot more than happens on this install)
• The "older"/"newer" comments appear on wrong lines a large chunk of the time. This is the most annoying part, I'd say, because a lot of inlines are really specific about what happens on a line.

Those two points aside, this feature is a huge win.

These changes fix it:

diff --git a/support/xhpast/scanner.l b/support/xhpast/scanner.l
index 28cf40f..bbdde72 100644
--- a/support/xhpast/scanner.l
+++ b/support/xhpast/scanner.l
@@ -313,8 +313,8 @@ NEWLINE ("\r\n"|"\n"|"\r")
   "("{TABS_AND_SPACES}unset{TABS_AND_SPACES}")" tok(T_UNSET_CAST);
 }

Not directly related to replies, but to creating tasks via email.

Rebase

Thanks!

No, this a private server in an internal network. For some context, here a some of the version number that seem relevant:

I had this same issue, but there was only one not-closed default branch. Maybe just not show closed branches?

Yeah, in 5.6 this works.

richard @dev[~]
-> php -v
PHP 5.6.2-1 (cli) (built: Oct 17 2014 17:15:37) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.2.5, Copyright (c) 2002-2014, by Derick Rethans

This has been discussed on the https://groups.google.com/forum/#!topic/nodejs/zF7GEoPccqw as well.

(tiny heads up - I know you're quite busy)

(the other link was the 2nd hit on Google, but this is the official documentation: https://docs.npmjs.com/getting-started/installing-npm-packages-globally)

The update went pretty well, and it seems to work just fine!

Seems reasonable to me.

Yeah, it did indeed. D11268 does solve the issue correctly for me in all cases I tested.

This seems to work for me. Thanks!

FWIW, this patch fixes it for me

diff --git a/support/xhpast/parser.y b/support/xhpast/parser.y
index 1697c26..e07704b 100644
--- a/support/xhpast/parser.y
+++ b/support/xhpast/parser.y
@@ -1176,7 +1176,7 @@ class_statement:
     yyextra->expecting_xhp_class_statements = yyextra->old_expecting_xhp_class_statements;

Since this landed, calling getDocblockToken() on a n_METHOD_DECLARATION does not return docblock token anymore.

How about adding the $sort_flag to msort as a parameter? It could very well be useful to explicitly sort things numerically?

Diff that very hackily implements desktop notifications on top of standard notifications: https://secure.phabricator.com/differential/diff/27013/

The concern was resolved in rPd4f992d2ed09349755757d02bc887f80b464ad9b

I'm getting an error via Conduit when adding a Conpherence message. See inline for where it goes wrong.

I would like a configuration option, but I'm fine either way. I took me some time to get used to.

After installing bcrypt, did you restart the web server?

I'm not entirely sure that no highlighting by default is always reasonable. For example, the company I work at developers mainly PHP, and pretty much all code snippets we write in comments, tasks, etc. are PHP.

It was removed in rPace1feb70220: Implement PhabricatorApplicationTransactionInterface on ManiphestTask, for what it's worth.

Is there any interest in the fix I described in T6112? The downside is that it is a lot slower, but it at least works.

I did my best to find an existing task, but I couldn't find it. I even replied on it, so I should have known.

Ohhh. I think I'd prefer indigo indeed :-)

I will miss the flame

There seems to be no other way than setting the timeout via ini_set().

Confirmed to work, thanks!

We are at 0c37f8db4b82 right now, which includes that commit as well.