Page MenuHomePhabricator

Rebuild xhpast.exe
AbandonedPublic

Authored by richardvanvelzen on Jan 11 2015, 9:10 PM.

Details

Summary

Fixes T6925.

Test Plan
$ ./src/parser/xhpast/bin/xhpast.exe -v
5.5.8/1h

$ arc lint ./src/parser/xhpast/api/XHPASTNode.php
 OKAY  No lint warnings.

Diff Detail

Repository
rPHU libphutil
Branch
xhpast-windows
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 4335
Build 4348: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

richardvanvelzen retitled this revision from to Rebuild xhpast.exe.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
joshuaspence accepted this revision.Jan 15 2015, 10:50 AM
joshuaspence edited edge metadata.

burnittotheground

Heads up, you would need to rebuild this after D11639.

richardvanvelzen edited edge metadata.

Rebase

richardvanvelzen edited the test plan for this revision. (Show Details)Feb 4 2015, 9:34 PM
staticshock requested changes to this revision.Feb 20 2015, 8:26 PM
staticshock added a reviewer: staticshock.
staticshock added a subscriber: staticshock.

Fails on x86:

$ git checkout arcpatch-D11335
Switched to branch 'arcpatch-D11335'

$ .\src\parser\xhpast\bin\xhpast.exe --help
This version of C:\Users\Administrator\libphutil\src\parser\xhpast\bin\xhpast.ex
e is not compatible with the version of Windows you're running. Check your compu
ter's system information to see whether you need a x86 (32-bit) or x64 (64-bit)
version of the program, and then contact the software publisher.

$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.

$ .\src\parser\xhpast\bin\xhpast.exe --help
xhpast version 5.5.8/1e
This revision now requires changes to proceed.Feb 20 2015, 8:26 PM
richardvanvelzen abandoned this revision.Mar 25 2015, 7:06 PM