Page MenuHomePhabricator
Create Task
Maniphest T6699

Inline comments on a revision don't appear in the timeline
Closed, ResolvedPublic
Actions

Description

Since updating to HEAD today, inline comments don't appear in the timeline anymore. It reproduces on this install as well (see D10789#96741 for example)

revision-missing-inline-comments.png (312×564 px, 43 KB)

Revisions and Commits

rP Phabricator
D10935rPac1c9559860b Transactions - fix bug in differential where older inlines weren't appearing

Related Objects

Event Timeline

richardvanvelzen created this task.Dec 5 2014, 8:39 AM
richardvanvelzen raised the priority of this task from to High.
richardvanvelzen updated the task description. (Show Details)
richardvanvelzen added a project: Differential.
richardvanvelzen added a subscriber: richardvanvelzen.
epriestley added subscribers: btrahan, epriestley.Dec 5 2014, 11:37 AM

If your HEAD is slightly behind D10931, that might be the fix for this.

richardvanvelzen added a comment.EditedDec 5 2014, 11:52 AM

We are at 0c37f8db4b82 right now, which includes that commit as well.

After some more looking around and testing, it seems that inline comments are only shown in the timeline for the latest diff of a revision.

Edit: correct that - it only shows inlines for the active diff of a revision.

btrahan claimed this task.Dec 5 2014, 5:58 PM
btrahan added a revision: D10935: Transactions - fix bug in differential where older inlines weren't appearing.Dec 5 2014, 6:19 PM
btrahan closed this task as Resolved.Dec 5 2014, 7:16 PM
btrahan added a commit: rPac1c9559860b: Transactions - fix bug in differential where older inlines weren't appearing.

Closed by commit rPac1c9559860b.

richardvanvelzen added a comment.Dec 5 2014, 7:48 PM

Confirmed to work, thanks!

Phabricator · Built by Phacility