Page MenuHomePhabricator

Inline comments on a revision don't appear in the timeline
Closed, ResolvedPublic


Since updating to HEAD today, inline comments don't appear in the timeline anymore. It reproduces on this install as well (see D10789#96741 for example)

revision-missing-inline-comments.png (312×564 px, 43 KB)

Event Timeline

richardvanvelzen raised the priority of this task from to High.
richardvanvelzen updated the task description. (Show Details)
richardvanvelzen added a project: Differential.
richardvanvelzen added a subscriber: richardvanvelzen.

If your HEAD is slightly behind D10931, that might be the fix for this.

We are at 0c37f8db4b82 right now, which includes that commit as well.

After some more looking around and testing, it seems that inline comments are only shown in the timeline for the latest diff of a revision.

Edit: correct that - it only shows inlines for the active diff of a revision.