Page MenuHomePhabricator
Differential D15068

Preserve newlines in remarkup previews
ClosedPublic
Actions

Authored by richardvanvelzen on Jan 20 2016, 12:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 4:09 AM
Unknown Object (File)
Sun, Feb 9, 12:32 AM
Unknown Object (File)
Sun, Feb 9, 12:32 AM
Unknown Object (File)
Sun, Feb 9, 12:32 AM
Unknown Object (File)
Sun, Feb 9, 12:32 AM
Unknown Object (File)
Sat, Feb 8, 2:07 AM
Unknown Object (File)
Fri, Feb 7, 6:19 PM
Unknown Object (File)
Tue, Jan 28, 4:22 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10177: Newlines in remarkup not always preserved
Commits
Restricted Diffusion Commit
rP958333c46dd9: Preserve newlines in remarkup previews
Summary

Fixes T10177

Test Plan

Saw that the preview of the rendered task description showed newlines proper.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

richardvanvelzen updated this revision to Diff 36386.Jan 20 2016, 12:51 PM
richardvanvelzen retitled this revision from to Preserve newlines in remarkup previews.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
richardvanvelzen added a task: T10177: Newlines in remarkup not always preserved.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 20 2016, 12:51 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 20 2016, 12:52 PM
epriestley edited edge metadata.

In theory, this should use the same ruleset as the previewed object, but there's no way to figure that out right now and I think all previewable objects use the ruleset this implies. Good enough for government work.

This revision is now accepted and ready to land.Jan 20 2016, 12:52 PM
epriestley added a comment.Jan 20 2016, 12:53 PM

I added you to Blessed Committers so you should be able to push or "Land Revision" this yourself. (Or I can just pull it if the raw power is too overwhelming.)

richardvanvelzen added a comment.Jan 20 2016, 1:00 PM

I suddenly feel all important-y and stuff

Let me see if I can get this to work

Closed by commit rP958333c46dd9: Preserve newlines in remarkup previews (authored by Richard van Velzen <rvanvelzen@experty.com>). · Explain WhyJan 20 2016, 1:00 PM
This revision was automatically updated to reflect the committed changes.
richardvanvelzen added a comment.Jan 20 2016, 1:07 PM

Seems to have gone okay to me

epriestley added a comment.Jan 20 2016, 1:09 PM

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
view/
1 line

Diff 36387

View Options

src/infrastructure/markup/view/PHUIRemarkupView.php

Loading...
Phabricator · Built by Phacility