Make `arc feature` work consistently with and without branches/bookmarks
AbandonedPublic
Actions

Authored by richardvanvelzen on Jun 23 2014, 5:39 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

If you call arc feature with no arguments and you have no branches/bookmarks whatsoever, you get a usage exception. This doesn't seem necessary.

Test Plan

ran arc feature in a mercurial repo:

With bookmarks regarding closed revisions
Same as above, but with --view-all
With all bookmarks deleted

Diff Detail

Repository

rARC Arcanist

Branch

feat

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1335
Build 1335: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

richardvanvelzen updated this revision to Diff 23254.Jun 23 2014, 5:39 PM

richardvanvelzen retitled this revision from to Make `arc feature` work consistently with and without branches/bookmarks.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 5:39 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1335: Diff 23254.Jun 23 2014, 5:40 PM

This could of course break if people depend on arc feature with no branches/bookmarks having exit code 1.

richardvanvelzen abandoned this revision.Mar 25 2015, 7:56 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistFeatureWorkflow.php

7 lines

Diff 23254

View Options

src/workflow/ArcanistFeatureWorkflow.php

Make `arc feature` work consistently with and without branches/bookmarksAbandonedPublicActions