Page MenuHomePhabricator

Extend nodes in both directions in XHPAST
ClosedPublic

Authored by epriestley on Jan 7 2015, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 3:10 AM
Unknown Object (File)
Mon, Apr 29, 2:40 PM
Unknown Object (File)
Fri, Apr 26, 3:06 AM
Unknown Object (File)
Fri, Apr 26, 3:06 AM
Unknown Object (File)
Fri, Apr 26, 3:06 AM
Unknown Object (File)
Wed, Apr 24, 10:28 PM
Unknown Object (File)
Wed, Apr 17, 9:17 AM
Unknown Object (File)
Sun, Apr 14, 5:05 PM
Subscribers

Details

Summary

Currently, appendChild() extends tokens only to the right, so this produces the wrong result:

NLMORE($$, $2);
$$->apppendChild($1);

Instead of separate setBegin() + setEnd() operations, just always extend both sides of the range if applicable. This reduces NLMORE to NMORE and removes the pitfall from the codebase.

(I retained NEXTEND() because I think it makes the code a little more clear.)

Test Plan
  • Unit tests.
  • Parsed a snippet with methods-with-modifiers and methods-without-modifiers and saw the whole method definition end up in the n_METHOD_DECLARATION node.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable