Page MenuHomePhabricator
Create Task
Maniphest T8320

Bring Owners out of the dark ages
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
epriestley
May 26 2015, 7:10 PM
Tags
Referenced Files
None
Subscribers
cburroughs
dereckson
eadler
joshuaspence
jparise
michaelf
nickz
View All 11 Subscribers
Tokens
"Manufacturing Defect?" token, awarded by tycho.tatitscheff."Manufacturing Defect?" token, awarded by chad.

Description

Owners is very badly out of date, and T7604 at least partially motivates spending some time modernizing it.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects
Search...

Event Timeline

epriestley created this task.May 26 2015, 7:10 PM
epriestley claimed this task.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Owners.
epriestley added a subtask: T8317: Can't add a new path to an owner's package.
epriestley added a subtask: Restricted Maniphest Task.
epriestley added a subtask: T8073: Unable to add Repositories to Owner groups (Packages) after creation.
epriestley moved this task from Backlog to Dark Ages on the Owners board.
epriestley added a subtask: T7127: Saving new path list when deletes occur is erroneous at best.
chad awarded a token.May 26 2015, 7:11 PM
epriestley added a subtask: T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository.May 26 2015, 7:11 PM
epriestley added a revision: Restricted Differential Revision.May 26 2015, 7:49 PM
epriestley added a revision: Restricted Differential Revision.May 26 2015, 8:33 PM
joshuaspence added a subscriber: joshuaspence.May 26 2015, 8:36 PM

What does this have to do with T7604?

epriestley added a comment.May 26 2015, 8:38 PM

Installs which relied on "Arcanist Project" Herald rules don't necessarily have a perfect way forward; "Owners"-based rules are one of the alternatives I suggest in the upgrading guide in the description of that task.

epriestley added a revision: Restricted Differential Revision.May 26 2015, 8:57 PM
epriestley added a comment.May 26 2015, 9:01 PM

So, anyone have any clue what we use "primary owner" for?

epriestley added a revision: Restricted Differential Revision.May 26 2015, 11:22 PM
epriestley added a revision: Restricted Differential Revision.May 27 2015, 1:29 AM
epriestley added a commit: Restricted Diffusion Commit.May 27 2015, 5:29 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley closed subtask T8317: Can't add a new path to an owner's package as Resolved.
epriestley closed subtask Restricted Maniphest Task as Resolved.
epriestley closed subtask T8073: Unable to add Repositories to Owner groups (Packages) after creation as Resolved.
epriestley closed subtask T7127: Saving new path list when deletes occur is erroneous at best as Resolved.
richardvanvelzen added a subscriber: richardvanvelzen.Jun 4 2015, 7:18 PM
richardvanvelzen added a comment.Jun 4 2015, 7:20 PM

As per IRC:

[20:56:34] <_richardJ> I have a commit for which an Owners package of which I'm an owner requires an audit because of "owners not involved". However, I reviewed the actual revision.
staticshock added a subscriber: staticshock.Jun 4 2015, 8:01 PM
eadler added a subscriber: eadler.Jun 4 2015, 8:25 PM
nickz added a subscriber: nickz.Jun 10 2015, 10:21 PM
michaelf added a subscriber: michaelf.Jun 11 2015, 4:44 PM
epriestley removed a subtask: T8426: permit owners to be bound to an "external thing" or let owners be determined by an extension.Jun 11 2015, 5:00 PM
epriestley added a revision: Restricted Differential Revision.Jun 18 2015, 10:14 PM
epriestley closed subtask T8427: Make owners typeahead browsable so installs can have more than 100 packages as Resolved.Jun 19 2015, 12:16 AM
epriestley added a commit: Restricted Diffusion Commit.
jparise added a subscriber: jparise.Jun 23 2015, 4:37 AM
tycho.tatitscheff awarded a token.Jun 23 2015, 11:44 AM
epriestley merged a task: T8859: Find Owners link in Diffusion leads to a 404 /owners/view/search.Jul 16 2015, 3:11 PM
epriestley added a subscriber: dereckson.
chad merged a task: T8934: Find Owners link in Diffusion leads to 404 page.Jul 23 2015, 12:39 AM
chad added a subscriber: vrana.
epriestley added a project: Prioritized.Aug 11 2015, 1:47 PM
epriestley moved this task from Backlog to The Queue on the Prioritized board.
epriestley added a subtask: T8004: Highlight files owned by self/project when viewing revision.Aug 11 2015, 2:44 PM
epriestley added a revision: Restricted Differential Revision.Aug 15 2015, 7:54 PM
epriestley added a commit: Restricted Diffusion Commit.Aug 15 2015, 8:06 PM
epriestley added a revision: Restricted Differential Revision.Aug 17 2015, 3:35 PM
epriestley added a revision: Restricted Differential Revision.Aug 17 2015, 4:14 PM
cburroughs added a subscriber: cburroughs.Aug 17 2015, 4:32 PM
epriestley added a commit: Restricted Diffusion Commit.Aug 17 2015, 5:08 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley closed subtask T8004: Highlight files owned by self/project when viewing revision as Resolved.Aug 17 2015, 5:14 PM
chad closed subtask T8428: Allow packages to be disabled as Resolved.Aug 18 2015, 8:36 PM
turadg added a subscriber: turadg.Aug 25 2015, 11:36 PM
epriestley removed a subtask: T8425: Semantics around historical commits in an Owners package are awkward.Aug 31 2015, 3:13 PM
epriestley removed a subtask: T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository.Aug 31 2015, 3:21 PM
epriestley added a revision: Restricted Differential Revision.Aug 31 2015, 10:34 PM
epriestley added a revision: Restricted Differential Revision.Aug 31 2015, 10:51 PM
epriestley added a comment.Aug 31 2015, 10:59 PM

I marked D14023 as resolving this since I think I took care of most of the really silly/old stuff and this now works in a fairly reasonable way, at least for the most part.

I sketched out a very rough v2 on the workboard covering T2443 / T8425. The former should wait for API stuff and the latter is just a messy migration thing. Depending on when Audit gets a round of updates that stuff might make it in, too. I'm mostly hoping to shelve this for a bit, though, if nothing too sketchy pops up.

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Aug 31 2015, 11:01 PM
epriestley closed subtask T9218: Should Owners allow multiple packages to own the same file? as Resolved.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Sep 1 2015, 3:07 PM
Phabricator · Built by Phacility