Owners is very badly out of date, and T7604 at least partially motivates spending some time modernizing it.
Description
Description
Revisions and Commits
Revisions and Commits
| rP Phabricator | |||
| D14022 | rP809c7fb4f35e Fix an issue where paths could bleed across repos in Owners | ||
| D14023 | rPce7c2097b216 Update Owners docs a bit | ||
| D13922 | rP6cfeb9e54014 Further modernize OwnersPackageQuery | ||
| D13921 | rPfd61702d6e96 Remove "Primary Owner" from Owners | ||
| D13911 | rP36a50ccbae1e Provide a more modern way to load packages owning a set of files | ||
| D13349 | rP1851ca2d71aa Make owners typeahead mostly reasonable | ||
| D13032 | rPebb7ca8cbdae Convert Owners paths to application transactions | ||
| D13028 | rPda9a61fb70db Use ApplicationTransactions for all non-path edits to Owners packages | ||
| D13026 | rP009598593f80 Separate editing of package data and paths in Owners | ||
| D13025 | rP05bd6a1682e9 Modernize Owners package view UI elements | ||
| D13024 | rP6d5d34e6a87b Use ApplicationSearch in Owners | ||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | joshuaspence | T7603 Remove the deprecated "Repositories" application | ||
| Resolved | joshuaspence | T7604 Remove "Arcanist Projects" | ||
| Resolved | epriestley | T8320 Bring Owners out of the dark ages | ||
| Resolved | epriestley | T8317 Can't add a new path to an owner's package | ||
| Restricted Maniphest Task | ||||
| Resolved | None | T8073 Unable to add Repositories to Owner groups (Packages) after creation | ||
| Resolved | None | T7127 Saving new path list when deletes occur is erroneous at best | ||
| Resolved | epriestley | T8427 Make owners typeahead browsable so installs can have more than 100 packages | ||
| Resolved | chad | T8428 Allow packages to be disabled | ||
| Resolved | None | T8004 Highlight files owned by self/project when viewing revision | ||
| Resolved | epriestley | T2183 unify "table of contents" views between Differential and Diffusion | ||
| Resolved | epriestley | T9218 Should Owners allow multiple packages to own the same file? |
Event Timeline
Comment Actions
Installs which relied on "Arcanist Project" Herald rules don't necessarily have a perfect way forward; "Owners"-based rules are one of the alternatives I suggest in the upgrading guide in the description of that task.
Comment Actions
As per IRC:
[20:56:34] <_richardJ> I have a commit for which an Owners package of which I'm an owner requires an audit because of "owners not involved". However, I reviewed the actual revision.
Comment Actions
I marked D14023 as resolving this since I think I took care of most of the really silly/old stuff and this now works in a fairly reasonable way, at least for the most part.
I sketched out a very rough v2 on the workboard covering T2443 / T8425. The former should wait for API stuff and the latter is just a messy migration thing. Depending on when Audit gets a round of updates that stuff might make it in, too. I'm mostly hoping to shelve this for a bit, though, if nothing too sketchy pops up.