Page MenuHomePhabricator

Arcanist can not upload binaries when use Mercurial on Windows
Closed, DuplicatePublic

Description

hm, simple to reproduce。

list($err, $stdout) = $this->execManualLocal(
  'cat --rev %s --output %s -- %C',
  $revision,
  // %p is the formatter for the repo-relative filepath
  $tmpdir.'/%p',
  implode(' ', $paths));

exec incorrectly on Windows, the '%p' was replace by ‘ p’, so hg cat has wrong arg。 but when i correct it, the file was uploaded , but still can't display normal in differential。 but the code run well on my Mac。

Event Timeline

ivoryxiong raised the priority of this task from to Needs Triage.
ivoryxiong updated the task description. (Show Details)
ivoryxiong added a project: Arcanist.
ivoryxiong added a subscriber: ivoryxiong.
chad added a subscriber: chad.

What version of Mercurial are you using?

chad renamed this task from Arcanist can not upload binaries when use mercurial on Windows to Arcanist can not upload binaries when use Mercurial on Windows.Nov 2 2014, 10:46 PM
chad triaged this task as Low priority.
In T6112#77230, @chad wrote:

What version of Mercurial are you using?

the version is 2.9.2

See T6348 for details on why this happens. escapeshellarg under Windows removed % signs.

Is there any interest in the fix I described in T6112? The downside is that it is a lot slower, but it at least works.