Page MenuHomePhabricator

Allow binary files to be uploaded via arcanist under windows
AbandonedPublic

Authored by richardvanvelzen on Dec 15 2014, 7:22 PM.
Tags
None
Referenced Files
F19211873: D10994.id26399.diff
Wed, Dec 17, 2:42 AM
F19084643: D10994.id.diff
Dec 2 2025, 3:52 PM
F19074536: D10994.diff
Dec 1 2025, 5:46 AM
F19056473: D10994.id26399.diff
Nov 28 2025, 7:48 PM
F19056458: D10994.id26399.diff
Nov 28 2025, 7:45 PM
F18979796: D10994.diff
Nov 16 2025, 10:57 PM
F18854488: D10994.id.diff
Nov 1 2025, 12:20 AM
F18851973: D10994.diff
Oct 31 2025, 5:46 AM
Subscribers

Details

Summary

Fixes T6112. escapeshellarg on Windows removes %-signs, which makes the command string for the bulk hg cat fail.

Test Plan

Ran arc diff on some repository to which I added binary files. Asserted that the files were correctly uploaded and viewable in Differential.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 3264
Build 3270: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestGitStateParsing
0 mstestHgStateParsing
0 mstestSVNFileEscapes
0 mstestSvnStateParsing