Page MenuHomePhabricator

Allow binary files to be uploaded via arcanist under windows
AbandonedPublic

Authored by richardvanvelzen on Dec 15 2014, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 30, 2:25 AM
Unknown Object (File)
Thu, May 29, 4:10 PM
Unknown Object (File)
Wed, May 28, 11:25 AM
Unknown Object (File)
Apr 26 2025, 2:11 AM
Unknown Object (File)
Apr 19 2025, 4:38 PM
Unknown Object (File)
Apr 13 2025, 8:47 PM
Unknown Object (File)
Mar 29 2025, 5:55 PM
Unknown Object (File)
Mar 29 2025, 2:20 PM
Subscribers

Details

Summary

Fixes T6112. escapeshellarg on Windows removes %-signs, which makes the command string for the bulk hg cat fail.

Test Plan

Ran arc diff on some repository to which I added binary files. Asserted that the files were correctly uploaded and viewable in Differential.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 3264
Build 3270: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestGitStateParsing
0 mstestHgStateParsing
0 mstestSVNFileEscapes
0 mstestSvnStateParsing