Page MenuHomePhabricator

Allow binary files to be uploaded via arcanist under windows
AbandonedPublic

Authored by richardvanvelzen on Dec 15 2014, 7:22 PM.
Tags
None
Referenced Files
F18095576: D10994.diff
Fri, Aug 8, 12:46 AM
F18082960: D10994.id26399.diff
Tue, Aug 5, 8:24 AM
F17947684: D10994.id.diff
Thu, Jul 31, 5:57 PM
F17937265: D10994.diff
Thu, Jul 31, 1:00 AM
F17922212: D10994.diff
Jul 30 2025, 6:27 AM
Unknown Object (File)
May 30 2025, 2:25 AM
Unknown Object (File)
May 29 2025, 4:10 PM
Unknown Object (File)
May 28 2025, 11:25 AM
Subscribers

Details

Summary

Fixes T6112. escapeshellarg on Windows removes %-signs, which makes the command string for the bulk hg cat fail.

Test Plan

Ran arc diff on some repository to which I added binary files. Asserted that the files were correctly uploaded and viewable in Differential.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 3264
Build 3270: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestGitStateParsing
0 mstestHgStateParsing
0 mstestSVNFileEscapes
0 mstestSvnStateParsing