Page MenuHomePhabricator

Allow binary files to be uploaded via arcanist under windows
AbandonedPublic

Authored by richardvanvelzen on Dec 15 2014, 7:22 PM.
Tags
None
Referenced Files
F15284156: D10994.id26399.diff
Tue, Mar 4, 9:20 AM
Unknown Object (File)
Wed, Feb 26, 4:58 AM
Unknown Object (File)
Sat, Feb 8, 12:21 AM
Unknown Object (File)
Sat, Feb 8, 12:20 AM
Unknown Object (File)
Sat, Feb 8, 12:20 AM
Unknown Object (File)
Feb 4 2025, 12:02 AM
Unknown Object (File)
Jan 29 2025, 5:44 AM
Unknown Object (File)
Jan 23 2025, 7:09 PM
Subscribers

Details

Summary

Fixes T6112. escapeshellarg on Windows removes %-signs, which makes the command string for the bulk hg cat fail.

Test Plan

Ran arc diff on some repository to which I added binary files. Asserted that the files were correctly uploaded and viewable in Differential.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 3264
Build 3270: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestGitStateParsing
0 mstestHgStateParsing
0 mstestSVNFileEscapes
0 mstestSvnStateParsing