Attached diff supports "timeout" for MySQLi. It would be nice to support this for MySQL, too.
Once MySQL supports it, PhabricatorSetupCheckDatabase should use "timeout" instead of manually setting ini_set('mysql.connect_timeout', 2);. Using an ini_set() dance may also be the only way to get this to work.
| Restricted Differential Revision | Restricted Diffusion Commit | |
| Restricted Differential Revision | Restricted Diffusion Commit | |
| Restricted Differential Revision | Restricted Diffusion Commit |
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Duplicate | epriestley | T4209 Multiserver / High-Availability Configuration | ||
| Resolved | epriestley | T10751 Make Phabricator Highly Available | ||
| Resolved | epriestley | T4571 Allow Phabricator to run in Read-Only Mode | ||
| Resolved | None | T6710 Support "timeout" in vanilla MySQL connections |
Ugh. I guess we'd have to this thing, then:
$old = ini_get(...);
ini_set('...', $val);
mysql_connect(...);
ini_set('...', $old);We need this for T4571 for the cluster status console so it doesn't take 10000 years if replicas are down.