Page MenuHomePhabricator
Create Task
Maniphest T6710

Support "timeout" in vanilla MySQL connections
Closed, ResolvedPublic
Actions

Description

Attached diff supports "timeout" for MySQLi. It would be nice to support this for MySQL, too.

Once MySQL supports it, PhabricatorSetupCheckDatabase should use "timeout" instead of manually setting ini_set('mysql.connect_timeout', 2);. Using an ini_set() dance may also be the only way to get this to work.

Revisions and Commits

rPHU libphutil
D15669rPHUd22d1ec5e35c Support "timeout" parameter in older MySQL connections
D10944rPHU3d31d3874f1b Support an explicit connection timeout parameter for database connections
rP Phabricator
D15670rPc178f29cdb8b Use new first-class MySQL timeout support in Phabricator

Related Objects
Search...

Event Timeline

epriestley created this task.Dec 8 2014, 1:21 PM
epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Infrastructure.
epriestley added a subscriber: epriestley.
epriestley added a revision: D10944: Support an explicit connection timeout parameter for database connections.Dec 8 2014, 1:22 PM
epriestley added a commit: rPHU3d31d3874f1b: Support an explicit connection timeout parameter for database connections.Dec 8 2014, 7:27 PM
richardvanvelzen added a subscriber: richardvanvelzen.Dec 8 2014, 10:26 PM

There seems to be no other way than setting the timeout via ini_set().

richardvanvelzen removed a subscriber: richardvanvelzen.Dec 8 2014, 10:26 PM
epriestley added a comment.Dec 8 2014, 10:27 PM

Ugh. I guess we'd have to this thing, then:

$old = ini_get(...);
ini_set('...', $val);
mysql_connect(...);
ini_set('...', $old);
epriestley reopened this task as Open.Apr 9 2016, 9:07 PM
epriestley closed this task as a duplicate of T4571: Allow Phabricator to run in Read-Only Mode.
epriestley added a parent task: T4571: Allow Phabricator to run in Read-Only Mode.

We need this for T4571 for the cluster status console so it doesn't take 10000 years if replicas are down.

epriestley added a revision: D15669: Support "timeout" parameter in older MySQL connections.Apr 10 2016, 11:02 AM
epriestley added a revision: D15670: Use new first-class MySQL timeout support in Phabricator.
epriestley added a commit: rPHUd22d1ec5e35c: Support "timeout" parameter in older MySQL connections.Apr 10 2016, 7:17 PM
Herald added a subscriber: eadler. · View Herald TranscriptApr 10 2016, 7:17 PM
epriestley closed this task as Resolved by committing rPc178f29cdb8b: Use new first-class MySQL timeout support in Phabricator.Apr 10 2016, 7:19 PM
epriestley added a commit: rPc178f29cdb8b: Use new first-class MySQL timeout support in Phabricator.
Phabricator · Built by Phacility