D14498 wasn't quite correct. Specifically, it incorrectly parsed the following code:
<?php namespace A; class A {} class B {}
Details
Details
- Reviewers
epriestley richardvanvelzen - Group Reviewers
Blessed Reviewers
 |  |
| Before | After } |
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8903 Build 10427: Run Core Tests Build 10426: arc lint + arc unit
Event Timeline
| support/xhpast/parser.y | ||
|---|---|---|
| 57 | I have no idea if this is okay. | |
| support/xhpast/parser.y | ||
|---|---|---|
| 57 | The resolution does seem okay, but it's probably better to rewrite the grammar in a way that it's not ambiguous. | |
Comment Actions
This would also make something like this parse badly:
namespace A; class T { } namespace B; class T { }
Here, the second namespace statement would be a child of the first (according to the grammar), even though they're both top-level.
Comment Actions
Hmm yeah, you are correct. I am wondering if maybe I should just revert D19948... It would still be possible to implement some sort of getNamespace() method (I think), but it would be significantly harder.