HomePhabricator
Diffusion libphutil 610ca9eba906

Minor tidying of XHPAST code
610ca9eba906
Actions

Description

Minor tidying of XHPAST code

Summary: Fix a few linter violations in XHPAST source code and modify a bunch of code for consistency.

Test Plan: Ran arc unit --everything in rARC, rPHU and rP.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D13987

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Nov 8 2015, 7:55 PM
Reviewer
Blessed Reviewers
Differential Revision
D13987: Minor tidying of XHPAST code
Parents
rPHUceca9d1122ea: Add Highlight Remarkup Rule
Branches
Unknown
Tags
Unknown
Reverted By
rPHU645da2b19d5d: Revert "Minor tidying of XHPAST code"
Build Status
Buildable 8715
Build 10116: Run Core Tests

Event Timeline

joshuaspence committed rPHU610ca9eba906: Minor tidying of XHPAST code (authored by joshuaspence).Nov 8 2015, 7:55 PM
Harbormaster failed to build B8715: rPHU610ca9eba906: Minor tidying of XHPAST code!Nov 8 2015, 7:56 PM
epriestley added a subscriber: epriestley.Nov 10 2015, 2:38 PM

I'm going to revert this; it breaks HEREDOC parsing. This causes test failures here (see build 10116) and in Phabricator.

I think the fix is removing one newline, but I can't build xhpast locally anymore to test it. I'll file a followup for that.

/support/xhpast/scanner.l
321–322

I suspect this is the break, and that this newline is considered semantic by bison.

epriestley added a reverting change: rPHU645da2b19d5d: Revert "Minor tidying of XHPAST code".Nov 10 2015, 2:39 PM
epriestley mentioned this in rPHU645da2b19d5d: Revert "Minor tidying of XHPAST code".
epriestley mentioned this in T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).Nov 10 2015, 2:46 PM
richardvanvelzen added a subscriber: richardvanvelzen.Nov 10 2015, 3:31 PM
richardvanvelzen added inline comments.
/support/xhpast/scanner.l
294–295

This newline isn't permitted either. When adding newlines, make sure a block is surrounding the semantic action.

321–322

That is correct.

Harbormaster failed to build B8715: rPHU610ca9eba906: Minor tidying of XHPAST code!Nov 11 2015, 10:02 PM

Changes (9)

PathSize
support/
xhpast/

rPHU610ca9eba906

View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/astnode.hpp

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/parser.yacc.hpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility