HomePhabricator

Minor tidying of XHPAST code

Description

Minor tidying of XHPAST code

Summary: Fix a few linter violations in XHPAST source code and modify a bunch of code for consistency.

Test Plan: Ran arc unit --everything in rARC, rPHU and rP.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D13987

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Nov 8 2015, 7:55 PM
Reviewer
Blessed Reviewers
Differential Revision
D13987: Minor tidying of XHPAST code
Parents
rPHUceca9d1122ea: Add Highlight Remarkup Rule
Branches
Unknown
Tags
Unknown
Reverted By
rPHU645da2b19d5d: Revert "Minor tidying of XHPAST code"
Build Status
Buildable 8715
Build 10116: Run Core Tests

Event Timeline

I'm going to revert this; it breaks HEREDOC parsing. This causes test failures here (see build 10116) and in Phabricator.

I think the fix is removing one newline, but I can't build xhpast locally anymore to test it. I'll file a followup for that.

/support/xhpast/scanner.l
321โ€“322

I suspect this is the break, and that this newline is considered semantic by bison.

richardvanvelzen added inline comments.
/support/xhpast/scanner.l
294โ€“295

This newline isn't permitted either. When adding newlines, make sure a block is surrounding the semantic action.

321โ€“322

That is correct.