Page MenuHomePhabricator
Create Task
Maniphest T8554

PHPUnit tests cause failure
Closed, ResolvedPublic
Actions

Description

[2015-06-15 22:31:24] EXCEPTION: (DomainException) Attempt to write to undeclared property ArcanistPhpunitTestResultParser::affectedTests. at [<phutil>/src/object/Phobject.php:23]
arcanist(), es-arcanist(), phutil()
  #0 Phobject::__set(string, array) called at [<arcanist>/src/unit/parser/ArcanistTestResultParser.php:29]
  #1 ArcanistTestResultParser::setAffectedTests(array) called at [<es-arcanist>/unit/ESPhpunitTestEngine.php:92]

ArcanistTestResultParser has no field called affectedTests, but setAffectedTests attempts to write to it.

Revisions and Commits

rARC Arcanist
AuditedrARC9a7c4d87a850 Fix missing property on ArcanistTestResultParser
AuditedrARC579c0eba1a00 Fix missing property in ArcanistPhpunitTestResultParser

Related Objects

Event Timeline

richardvanvelzen created this task.Jun 15 2015, 8:37 PM
richardvanvelzen raised the priority of this task from to Needs Triage.
richardvanvelzen updated the task description. (Show Details)
richardvanvelzen added a project: Arcanist.
richardvanvelzen added subscribers: joshuaspence, epriestley.
richardvanvelzen added a subscriber: richardvanvelzen.

(Probably occurs thanks to D13283)

epriestley closed this task as Resolved by committing rARC579c0eba1a00: Fix missing property in ArcanistPhpunitTestResultParser.Jun 15 2015, 8:39 PM
epriestley added a commit: rARC579c0eba1a00: Fix missing property in ArcanistPhpunitTestResultParser.
epriestley added a comment.Jun 15 2015, 8:39 PM

Thanks!

richardvanvelzen added a comment.Jun 15 2015, 8:54 PM

Sorry, I think that did not fully resolve the issue - I still get the same exception after upgrading.

I think that the parent class (ArcanistTestResultParser) should actually have the field (protected, as the other fields. (Since it also has the setter, which actually causes the exception)

epriestley added a commit: rARC9a7c4d87a850: Fix missing property on ArcanistTestResultParser.Jun 15 2015, 9:00 PM
epriestley added a comment.Jun 15 2015, 9:00 PM

Ah, you're right. Those classes are a little unconventional (we usually don't let subclasses touch properties on the parent class).

richardvanvelzen added a comment.Jun 15 2015, 9:04 PM

Works like a charm now. :-)

Thanks for the amazingly quick response as usual!

Phabricator · Built by Phacility