PHPUnit tests cause failure
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	richardvanvelzen
	Jun 15 2015, 8:37 PM

Description

[2015-06-15 22:31:24] EXCEPTION: (DomainException) Attempt to write to undeclared property ArcanistPhpunitTestResultParser::affectedTests. at [<phutil>/src/object/Phobject.php:23]
arcanist(), es-arcanist(), phutil()
  #0 Phobject::__set(string, array) called at [<arcanist>/src/unit/parser/ArcanistTestResultParser.php:29]
  #1 ArcanistTestResultParser::setAffectedTests(array) called at [<es-arcanist>/unit/ESPhpunitTestEngine.php:92]

ArcanistTestResultParser has no field called affectedTests, but setAffectedTests attempts to write to it.

Revisions and Commits

	Restricted Diffusion Commit
	Restricted Diffusion Commit

Event Timeline

(Probably occurs thanks to D13283)

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jun 15 2015, 8:39 PM

epriestley added a commit: Restricted Diffusion Commit.

Thanks!

Sorry, I think that did not fully resolve the issue - I still get the same exception after upgrading.

I think that the parent class (ArcanistTestResultParser) should actually have the field (protected, as the other fields. (Since it also has the setter, which actually causes the exception)

epriestley added a commit: Restricted Diffusion Commit.Jun 15 2015, 9:00 PM

Ah, you're right. Those classes are a little unconventional (we usually don't let subclasses touch properties on the parent class).

Works like a charm now. :-)

Thanks for the amazingly quick response as usual!

PHPUnit tests cause failureClosed, ResolvedPublicActions

Description

Revisions and Commits

Event Timeline

PHPUnit tests cause failure
Closed, ResolvedPublic
Actions