Diffusion Phabricator d4f992d2ed09

Continue after rejecting commits from a commit query
d4f992d2ed09
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Continue after rejecting commits from a commit query

Summary: Fixes T6880. If matching commits have no visible/loadable repository, we shouldn't keep going forward in the loop.

Test Plan: Havne't built a repro locally yet so not 100% sure this fixes it.

Reviewers: btrahan, mbishopim3, fabe

Reviewed By: mbishopim3, fabe

Subscribers: mbishopim3, epriestley

Maniphest Tasks: T6880

Differential Revision: https://secure.phabricator.com/D11251

Details

Provenance

epriestley	Authored on
epriestley	Pushed on Jan 6 2015, 4:02 PM

Reviewer

Differential Revision

D11251: Continue after rejecting commits from a commit query

Parents

rPf2e87aad89e9: Rename the `PhabricatorAuthFactorTOTP` class for consistency

Branches

Unknown

Tags

Unknown

Tasks

T6880: "Attempting to access attached data on PhabricatorRepositoryCommit (via getRepository())" error when creating or accessing diffs

Event Timeline

epriestley committed rPd4f992d2ed09: Continue after rejecting commits from a commit query (authored by epriestley).Jan 6 2015, 4:02 PM

epriestley added a task: T6880: "Attempting to access attached data on PhabricatorRepositoryCommit (via getRepository())" error when creating or accessing diffs.

richardvanvelzen mentioned this in rPf33e2de09286: make repo callsigns optional.Jan 6 2015, 5:17 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

query/

DiffusionCommitQuery.php

rPd4f992d2ed09

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...