Page MenuHomePhabricator
Differential D13283

Extend from Phobject
ClosedPublic
Actions

Authored by joshuaspence on Jun 14 2015, 9:20 PM.
Tags
None
Referenced Files
F15461175: D13283.largetrue.diff
Tue, Apr 1, 5:56 AM
F15458913: D13283.id.largetrue.diff
Mon, Mar 31, 8:12 AM
F15443041: D13283.id.diff
Thu, Mar 27, 1:51 AM
F15431571: D13283.diff
Mon, Mar 24, 1:12 PM
F15421071: D13283.id32150.diff
Fri, Mar 21, 8:49 PM
F15419831: D13283.id32110.diff
Fri, Mar 21, 9:15 AM
F15418554: D13283.id.diff
Fri, Mar 21, 12:01 AM
F15416564: D13283.id32145.diff
Thu, Mar 20, 12:08 PM
View All Files
Subscribers
epriestley
javabudd
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPb6d745b66687: Extend from Phobject
Summary

All classes should extend from some other class. See D13275 for some explanation.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32110.Jun 14 2015, 9:20 PM
joshuaspence retitled this revision from to Extend from Phobject.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 14 2015, 9:20 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 14 2015, 9:28 PM
epriestley edited edge metadata.

One probable fatal of everything? Looks good otherwise. But maybe click around a bit?

.arclint
77 ↗(On Diff #32110)

Unintended / debugging.

support/PhabricatorStartup.php
38 ↗(On Diff #32110)

I would expect this to immediately fatal when the web UI is loaded. This loads before libphutil, so my expectation is that it can't extend Phobject.

This revision is now accepted and ready to land.Jun 14 2015, 9:28 PM
joshuaspence updated this object.Jun 15 2015, 5:45 AM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 32145.Jun 15 2015, 6:02 AM

Don't fatal absolutely every single web request

joshuaspence added a comment.Jun 15 2015, 8:02 AM

I clicked around a bunch of applications and nothing seemed broken.

joshuaspence updated this revision to Diff 32148.Jun 15 2015, 8:05 AM

Rebase

Closed by commit rPb6d745b66687: Extend from Phobject (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 15 2015, 8:07 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D13296: Fix another undeclared property.Jun 15 2015, 10:30 AM
javabudd added a subscriber: javabudd.EditedJun 15 2015, 7:19 PM

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php;30e6203d8c453e74a8c40c9bc561151d45c07030$76

$settings does not exist in current or extended class

epriestley added a comment.Jun 15 2015, 7:22 PM

Thanks! rP6aa494b should fix it.

richardvanvelzen mentioned this in T8554: PHPUnit tests cause failure.Jun 15 2015, 8:38 PM
mikn mentioned this in T8599: Exceptions about after extending from Phobject.Jun 18 2015, 7:34 AM

Large Diff

This large diff affects 197 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
219 lines
aphront/
3 lines
2 lines
configuration/
2 lines
response/
2 lines
sink/
2 lines
applications/
aphlict/
query/
2 lines
audit/
constants/
2 lines
2 lines
2 lines
storage/
1 line
auth/
data/
2 lines
provider/
2 lines
base/
4 lines
cache/
2 lines
calendar/
util/
2 lines
celerity/
2 lines
3 lines
2 lines
2 lines
2 lines
2 lines
resources/
2 lines
conduit/
call/
3 lines
protocol/
2 lines
2 lines
config/
check/
2 lines
custom/
2 lines
issue/
2 lines
json/
2 lines
conpherence/
2 lines
constants/
2 lines
console/
core/
2 lines
plugin/
2 lines
errorlog/
2 lines
xhprof/
2 lines
dashboard/
layoutconfig/
2 lines
differential/
2 lines
constants/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
landing/
2 lines
parser/
4 lines
2 lines
2 lines
render/
2 lines
3 lines
storage/
1 line
2 lines
view/
2 lines
diffusion/
2 lines
data/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
protocol/
2 lines
query/
2 lines
2 lines
pathchange/
2 lines
pathid/
2 lines
request/
2 lines
ssh/
1 line
symbol/
2 lines
2 lines
diviner/
atom/
2 lines
2 lines
atomizer/
2 lines
cache/
2 lines
publisher/
2 lines
renderer/
2 lines
doorkeeper/
engine/
2 lines
drydock/
blueprint/
2 lines
constants/
2 lines
interface/
2 lines
util/
2 lines
fact/
engine/
2 lines
spec/
2 lines
feed/
2 lines
builder/
2 lines
story/
1 line
files/
2 lines
engine/
2 lines
query/
2 lines
flag/
constants/
2 lines
harbormaster/
step/
2 lines
herald/
adapter/
2 lines
config/
2 lines
2 lines
engine/
2 lines
7 lines
extension/
2 lines
storage/
transcript/
2 lines
2 lines
2 lines
lipsum/
generator/
2 lines
image/
2 lines
maniphest/
constants/
2 lines
export/
2 lines
metamta/
adapter/
2 lines
constants/
2 lines
contentsource/
2 lines
parser/
2 lines
query/
2 lines
receiver/
2 lines
replyhandler/
2 lines
storage/
2 lines
view/
2 lines
4 lines
multimeter/
data/
2 lines
notification/
builder/
2 lines
client/
2 lines
oauthserver/
2 lines
2 lines
owners/
query/
2 lines
phame/
skins/
2 lines
phid/
1 line
2 lines
handle/
view/
2 lines
query/
2 lines
storage/
2 lines
type/
2 lines
phortune/
cart/
2 lines
constants/
2 lines
product/
2 lines
provider/
2 lines
subscription/
2 lines
view/
2 lines
phriction/
constants/
2 lines
policy/
__tests__/
1 line
constants/
2 lines
filter/
2 lines
rule/
2 lines
ponder/
constants/
2 lines
project/
constants/
2 lines
view/
2 lines
releeph/
commitfinder/
2 lines
constants/
2 lines
differential/
2 lines
field/
selector/
2 lines
view/
branch/
2 lines
repository/
constants/
2 lines
engine/
2 lines
2 lines
graphcache/
2 lines
search/
constants/
2 lines
engine/
2 lines
2 lines
index/
2 lines
2 lines
settings/
panel/
2 lines
subscriptions/
view/
2 lines
2 lines
system/
action/
2 lines
transactions/
constants/
2 lines
typeahead/
storage/
2 lines
uiexample/
examples/
2 lines
infrastructure/
customfield/
field/
2 lines
2 lines
daemon/
bot/
2 lines
adapter/
2 lines
handler/
2 lines
target/
2 lines
control/
2 lines
workers/
2 lines
diff/
2 lines
edges/
constants/
2 lines
env/
2 lines
2 lines
2 lines
events/
2 lines
javelin/
2 lines
log/
2 lines
markup/
2 lines
4 lines
2 lines
query/
2 lines
sms/
adapter/
2 lines
storage/
configuration/
1 line
lisk/
2 lines
2 lines
2 lines
management/
2 lines
2 lines
patch/
2 lines
testing/
fixture/
2 lines
time/
2 lines
2 lines
util/
2 lines
view/
control/
2 lines
phui/
2 lines

Diff 32150

View Options

src/__phutil_library_map__.php

View Options

src/aphront/AphrontRequest.php

View Options

src/aphront/AphrontURIMapper.php

View Options

src/aphront/configuration/AphrontApplicationConfiguration.php

View Options

src/aphront/response/AphrontResponse.php

View Options

src/aphront/sink/AphrontHTTPSink.php

View Options

src/applications/aphlict/query/AphlictDropdownDataQuery.php

View Options

src/applications/audit/constants/PhabricatorAuditActionConstants.php

View Options

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

View Options

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

View Options

src/applications/auth/data/PhabricatorAuthHighSecurityToken.php

View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

View Options

src/applications/base/PhabricatorApplication.php

View Options

src/applications/cache/PhabricatorCaches.php

View Options

src/applications/calendar/util/CalendarTimeUtil.php

View Options

src/applications/celerity/CelerityAPI.php

View Options

src/applications/celerity/CelerityResourceMap.php

View Options

src/applications/celerity/CelerityResourceMapGenerator.php

View Options

src/applications/celerity/CelerityResourceTransformer.php

View Options

src/applications/celerity/CeleritySpriteGenerator.php

View Options

src/applications/celerity/CelerityStaticResourceResponse.php

View Options

src/applications/celerity/resources/CelerityResources.php

View Options

src/applications/conduit/call/ConduitCall.php

View Options

src/applications/conduit/protocol/ConduitAPIRequest.php

View Options

src/applications/conduit/protocol/ConduitAPIResponse.php

View Options

src/applications/config/check/PhabricatorSetupCheck.php

View Options

src/applications/config/custom/PhabricatorConfigOptionType.php

View Options

src/applications/config/issue/PhabricatorSetupIssue.php

View Options

src/applications/config/json/PhabricatorConfigJSON.php

View Options

src/applications/conpherence/ConpherenceTransactionRenderer.php

View Options

src/applications/conpherence/constants/ConpherenceConstants.php

View Options

src/applications/console/core/DarkConsoleCore.php

View Options

src/applications/console/plugin/DarkConsolePlugin.php

View Options

src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php

View Options

src/applications/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php

View Options

src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php

View Options

src/applications/differential/DifferentialGetWorkingCopy.php

View Options

src/applications/differential/constants/DifferentialAction.php

View Options

src/applications/differential/constants/DifferentialChangeType.php

View Options

src/applications/differential/constants/DifferentialLintStatus.php

View Options

src/applications/differential/constants/DifferentialReviewerStatus.php

View Options

src/applications/differential/constants/DifferentialRevisionControlSystem.php

View Options

src/applications/differential/constants/DifferentialRevisionStatus.php

View Options

src/applications/differential/constants/DifferentialUnitStatus.php

View Options

src/applications/differential/constants/DifferentialUnitTestResult.php

View Options

src/applications/differential/landing/DifferentialLandingStrategy.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/parser/DifferentialCommitMessageParser.php

View Options

src/applications/differential/parser/DifferentialHunkParser.php

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

View Options

src/applications/differential/render/DifferentialRawDiffRenderer.php

View Options

src/applications/differential/storage/DifferentialInlineComment.php

View Options

src/applications/differential/storage/DifferentialReviewer.php

View Options

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

View Options

src/applications/diffusion/DiffusionLintSaveRunner.php

View Options

src/applications/diffusion/data/DiffusionBrowseResultSet.php

View Options

src/applications/diffusion/data/DiffusionFileContent.php

View Options

src/applications/diffusion/data/DiffusionGitBranch.php

View Options

src/applications/diffusion/data/DiffusionPathChange.php

View Options

src/applications/diffusion/data/DiffusionRepositoryPath.php

View Options

src/applications/diffusion/data/DiffusionRepositoryTag.php

View Options

src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php

View Options

src/applications/diffusion/query/DiffusionPathQuery.php

View Options

src/applications/diffusion/query/DiffusionRenameHistoryQuery.php

View Options

src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php

View Options

src/applications/diffusion/query/pathid/DiffusionPathIDQuery.php

View Options

src/applications/diffusion/request/DiffusionRequest.php

View Options

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

View Options

src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php

View Options

src/applications/diffusion/symbol/DiffusionExternalSymbolsSource.php

View Options

src/applications/diviner/atom/DivinerAtom.php

View Options

src/applications/diviner/atom/DivinerAtomRef.php

View Options

src/applications/diviner/atomizer/DivinerAtomizer.php

View Options

src/applications/diviner/cache/DivinerDiskCache.php

View Options

src/applications/diviner/publisher/DivinerPublisher.php

View Options

src/applications/diviner/renderer/DivinerRenderer.php

View Options

src/applications/doorkeeper/engine/DoorkeeperFeedStoryPublisher.php

View Options

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

View Options

src/applications/drydock/constants/DrydockConstants.php

View Options

src/applications/drydock/interface/DrydockInterface.php

View Options

src/applications/drydock/util/DrydockBlueprintScopeGuard.php

View Options

src/applications/fact/engine/PhabricatorFactEngine.php

View Options

src/applications/fact/spec/PhabricatorFactSpec.php

View Options

src/applications/feed/PhabricatorFeedStoryPublisher.php

View Options

src/applications/feed/builder/PhabricatorFeedBuilder.php

View Options

src/applications/feed/story/PhabricatorFeedStory.php

View Options

src/applications/files/PhabricatorImageTransformer.php

View Options

src/applications/files/engine/PhabricatorFileStorageEngine.php

View Options

src/applications/files/query/PhabricatorFileBundleLoader.php

View Options

src/applications/flag/constants/PhabricatorFlagConstants.php

View Options

src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php

View Options

src/applications/herald/adapter/HeraldAdapter.php

View Options

src/applications/herald/config/HeraldRepetitionPolicyConfig.php

View Options

src/applications/herald/config/HeraldRuleTypeConfig.php

View Options

src/applications/herald/engine/HeraldEffect.php

View Options

src/applications/herald/engine/HeraldEngine.php

View Options

src/applications/herald/extension/HeraldCustomAction.php

View Options

src/applications/herald/storage/transcript/HeraldConditionTranscript.php

View Options

src/applications/herald/storage/transcript/HeraldObjectTranscript.php

View Options

src/applications/herald/storage/transcript/HeraldRuleTranscript.php

View Options

src/applications/lipsum/generator/PhabricatorTestDataGenerator.php

View Options

src/applications/lipsum/image/PhabricatorLipsumArtist.php

View Options

src/applications/maniphest/constants/ManiphestConstants.php

View Options

src/applications/maniphest/export/ManiphestExcelFormat.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationAdapter.php

View Options

src/applications/metamta/constants/MetaMTAConstants.php

View Options

src/applications/metamta/contentsource/PhabricatorContentSource.php

View Options

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

View Options

src/applications/metamta/query/PhabricatorMetaMTAActor.php

View Options

src/applications/metamta/receiver/PhabricatorMailReceiver.php

View Options

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAAttachment.php

View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

View Options

src/applications/metamta/view/PhabricatorMetaMTAMailSection.php

View Options

src/applications/multimeter/data/MultimeterControl.php

View Options

src/applications/notification/builder/PhabricatorNotificationBuilder.php

View Options

src/applications/notification/client/PhabricatorNotificationClient.php

View Options

src/applications/oauthserver/PhabricatorOAuthServer.php

View Options

src/applications/oauthserver/PhabricatorOAuthServerScope.php

View Options

src/applications/owners/query/PhabricatorOwnerPathQuery.php

View Options

src/applications/phame/skins/PhameSkinSpecification.php

View Options

src/applications/phid/PhabricatorObjectHandle.php

View Options

src/applications/phid/PhabricatorPHIDConstants.php

View Options

src/applications/phid/handle/view/PhabricatorHandleObjectSelectorDataView.php

View Options

src/applications/phid/query/PhabricatorObjectListQuery.php

View Options

src/applications/phid/storage/PhabricatorPHID.php

View Options

src/applications/phid/type/PhabricatorPHIDType.php

View Options

src/applications/phortune/cart/PhortuneCartImplementation.php

View Options

src/applications/phortune/constants/PhortuneConstants.php

View Options

src/applications/phortune/product/PhortuneProductImplementation.php

View Options

src/applications/phortune/provider/PhortunePaymentProvider.php

View Options

src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php

View Options

src/applications/phortune/view/PhortuneCreditCardForm.php

View Options

src/applications/phriction/constants/PhrictionConstants.php

View Options

src/applications/policy/__tests__/PhabricatorPolicyTestObject.php

View Options

src/applications/policy/constants/PhabricatorPolicyConstants.php

View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

View Options

src/applications/policy/rule/PhabricatorPolicyRule.php

View Options

src/applications/ponder/constants/PonderConstants.php

View Options

src/applications/project/constants/PhabricatorProjectStatus.php

View Options

src/applications/project/view/ProjectBoardTaskCard.php

View Options

src/applications/releeph/commitfinder/ReleephCommitFinder.php

View Options

src/applications/releeph/constants/ReleephRequestStatus.php

View Options

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

View Options

src/applications/releeph/field/selector/ReleephFieldSelector.php

View Options

src/applications/releeph/view/branch/ReleephBranchTemplate.php

View Options

src/applications/repository/constants/PhabricatorRepositoryType.php

View Options

src/applications/repository/engine/PhabricatorRepositoryCommitRef.php

View Options

src/applications/repository/engine/PhabricatorRepositoryEngine.php

View Options

src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php

View Options

src/applications/search/constants/PhabricatorSearchRelationship.php

View Options

src/applications/search/engine/PhabricatorJumpNavHandler.php

View Options

src/applications/search/engine/PhabricatorSearchEngine.php

View Options

src/applications/search/index/PhabricatorSearchAbstractDocument.php

View Options

src/applications/search/index/PhabricatorSearchIndexer.php

View Options

src/applications/settings/panel/PhabricatorSettingsPanel.php

View Options

src/applications/subscriptions/view/SubscriptionListDialogBuilder.php

View Options

src/applications/subscriptions/view/SubscriptionListStringBuilder.php

View Options

src/applications/system/action/PhabricatorSystemAction.php

View Options

src/applications/transactions/constants/PhabricatorTransactions.php

View Options

src/applications/typeahead/storage/PhabricatorTypeaheadResult.php

View Options

src/applications/uiexample/examples/PhabricatorUIExample.php

View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

View Options

src/infrastructure/customfield/field/PhabricatorCustomFieldAttachment.php

View Options

src/infrastructure/daemon/bot/PhabricatorBotMessage.php

View Options

src/infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php

View Options

src/infrastructure/daemon/bot/handler/PhabricatorBotHandler.php

View Options

src/infrastructure/daemon/bot/target/PhabricatorBotTarget.php

View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

View Options

src/infrastructure/diff/PhabricatorDifferenceEngine.php

View Options

src/infrastructure/edges/constants/PhabricatorEdgeConstants.php

View Options

src/infrastructure/env/PhabricatorConfigSource.php

View Options

src/infrastructure/env/PhabricatorEnv.php

View Options

src/infrastructure/env/PhabricatorScopedEnv.php

View Options

src/infrastructure/events/PhabricatorEventEngine.php

View Options

src/infrastructure/javelin/Javelin.php

View Options

src/infrastructure/log/PhabricatorAccessLog.php

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

View Options

src/infrastructure/markup/PhabricatorMarkupOneOff.php

View Options

src/infrastructure/markup/PhabricatorSyntaxHighlighter.php

View Options

src/infrastructure/query/PhabricatorQuery.php

View Options

src/infrastructure/sms/adapter/PhabricatorSMSImplementationAdapter.php

View Options

src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php

View Options

src/infrastructure/storage/lisk/LiskDAO.php

View Options

src/infrastructure/storage/lisk/LiskDAOSet.php

View Options

src/infrastructure/storage/lisk/PhabricatorLiskSerializer.php

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

View Options

src/infrastructure/storage/management/PhabricatorStoragePatch.php

View Options

src/infrastructure/storage/patch/PhabricatorSQLPatchList.php

View Options

src/infrastructure/testing/fixture/PhabricatorStorageFixtureScopeGuard.php

View Options

src/infrastructure/time/PhabricatorTime.php

View Options

src/infrastructure/time/PhabricatorTimeGuard.php

View Options

src/infrastructure/util/PhabricatorSlug.php

View Options

src/view/control/PhabricatorObjectSelectorDialog.php

View Options

src/view/phui/PHUI.php

Phabricator · Built by Phacility