Add support for desktop notifications
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	richardvanvelzen
	Nov 20 2013, 9:12 PM

Description

Support Web Notifications for application notifications.

Major steps are likely to be:

Notifications require an enrollment step where the browser asks users to confirm that they want notifications.
- Add Settings → Desktop Notifications and have that page check for enrollment and prompt the user to enroll.
- This panel should also let users disable desktop notifications completely.
- This panel should have a "Send test notification" button so users can confirm that notifications work and see what they look like.
If users are enrolled, we should emit application notifications as desktop notifications.
We may need to use JX.Leader to synchronize this (so multiple open tabs do not produce multiple identical notifications), or all browsers may be smart enough to deduplicate on their own.
We may need some additional preferences to control which application notifications promote into desktop notifications, but we'll probably have to build it and see how it feels first.

Revisions and Commits

rP Phabricator
	Abandoned		D9525 [DRAFT] Implement desktop notifications for Conpherence
		D13219	rP1bb2978a895a Desktop Notification support

Related Objects
Search...

		Status	Assigned	Task
		Open	None	T7568 Support Desktop Notifications in Conpherence
		Resolved	btrahan	T4139 Add support for desktop notifications

Event Timeline

richardvanvelzen created this task.Nov 20 2013, 9:12 PM

richardvanvelzen raised the priority of this task from to Needs Triage.

richardvanvelzen updated the task description. (Show Details)

richardvanvelzen added a project: Phabricator.

richardvanvelzen added a subscriber: epriestley.

richardvanvelzen added a subscriber: richardvanvelzen.

Hey hey - here's some useful links on how to contribute good javascript --

http://www.phabricator.com/docs/phabricator/article/Contributor_Introduction.html
http://www.phabricator.com/docs/phabricator/article/General_Coding_Standards.html
http://www.phabricator.com/docs/phabricator/article/Javascript_Coding_Standards.html

That said, I wouldn't sweat things too much. Once you get to the arc diff stage you'll get all the feedback you can handle. :D

krisbuist added a subscriber: krisbuist.Dec 3 2013, 8:52 AM

hnesland added a subscriber: hnesland.Feb 27 2014, 12:43 PM

epriestley triaged this task as Wishlist priority.Apr 24 2014, 1:02 PM

epriestley removed a project: Phabricator.

btrahan added a project: Aphlict.May 16 2014, 3:53 AM

sascha-egerer added a subscriber: sascha-egerer.May 28 2014, 8:33 PM

talshiri added a subscriber: talshiri.Jun 4 2014, 8:32 AM

Also interested in this. It could maaaybe reduce reliance on email </wishful thinking>

hach-que edited this Maniphest Task.Jun 14 2014, 4:44 AM

adoyle.h added a subscriber: adoyle.h.Oct 22 2014, 5:49 AM

shrinidhirao added a subscriber: shrinidhirao.Oct 22 2014, 9:49 AM

anton.vladimirov awarded a token.Nov 7 2014, 10:56 PM

Zolli added a subscriber: Zolli.Jan 5 2015, 10:03 AM

epriestley added a parent task: T5364: Conpherence v2 (Original Discussion).Jan 6 2015, 3:50 AM

epriestley mentioned this in T5364: Conpherence v2 (Original Discussion).Jan 6 2015, 6:23 PM

Diff that very hackily implements desktop notifications on top of standard notifications: https://secure.phabricator.com/differential/diff/27013/

J5lx added a subscriber: J5lx.Jan 14 2015, 5:33 PM

• davidme added a subscriber: • davidme.Feb 5 2015, 8:41 AM

rbalik awarded a token.Feb 19 2015, 5:34 PM

rbalik added a subscriber: rbalik.

epriestley added a parent task: T7568: Support Desktop Notifications in Conpherence.Mar 16 2015, 7:07 PM

epriestley removed a parent task: T5364: Conpherence v2 (Original Discussion).

epriestley mentioned this in T7568: Support Desktop Notifications in Conpherence.Mar 16 2015, 7:57 PM

epriestley updated the task description. (Show Details)

epriestley updated the task description. (Show Details)Mar 16 2015, 8:01 PM

benjumanji awarded a token.Apr 2 2015, 5:01 PM

benjumanji added a subscriber: benjumanji.

Very interested in this. Willing to contribute code if someone will have time to look at the patch (it doesn't have to be accepted, I just want to know that I am not stepping into something that is unlikely to get merged any time soon).