Page MenuHomePhabricator
Feed Advanced Search

Jan 21 2017

epriestley added a project to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Applications.
Jan 21 2017, 2:33 PM · Phacility, Ops, Applications
epriestley created T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.
Jan 21 2017, 2:30 PM · Phacility, Ops, Applications
epriestley edited the content of Changelog.
Jan 21 2017, 2:12 PM
epriestley created 2017 Week 3 (Late January).
Jan 21 2017, 2:12 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

And if I gave you a precise estimate you could be sneaky and just divide it by $1,500/hr to get the answer without paying for it!

Jan 21 2017, 1:59 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Obviously, we can't just hand out estimates for free. Converting units and multiplying numbers together takes away valuable time and resources we could be using to develop Phabricator.

Jan 21 2017, 1:53 PM · Bug Report (Needs Information)

Jan 20 2017

epriestley added a comment to T12138: Send-on-Enter and Fullscreen Mode interact destructively.

tarnation

Jan 20 2017, 11:40 PM · Remarkup, Conpherence
epriestley created T12138: Send-on-Enter and Fullscreen Mode interact destructively.
Jan 20 2017, 11:36 PM · Remarkup, Conpherence
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to, see Consulting to move forward.

Jan 20 2017, 11:23 PM · Bug Report (Needs Information)
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

How do I reproduce unexpected results at the application level (for example, what's something I can search for that doesn't match but should match)?

Jan 20 2017, 11:18 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T11521: Request Review action should clear "accepted older" status.

Yes and no. So: maybe?

Jan 20 2017, 11:12 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T11957: Add MenuEngine to Home.

While I've got you, how do you feel about a diff to:

Jan 20 2017, 7:34 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

(If there's pushback, maybe like a "one-time hacky copy your old global app settings into the menu script that we don't support" sort of thing? But I'd guess users won't feel like this is too painful since the new menu is a lot more flexible/powerful.)

Jan 20 2017, 7:31 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

I think it would potentially be reasonable to not migrate, especially if you do another blog post like the Favorites one to ease migration pain. Global stuff is relatively recent and pretty easy to put back in place, and I think a gentle nudge to configure the menu to work well for your install isn't a bad thing.

Jan 20 2017, 7:29 PM · Profile Menu Item, Dashboards
epriestley added a comment to T12136: What to do with "Application Counts" with MenuItem.

Maybe less complainey now that Audit and Differential have fairly sane default "stuff you should do" bucketed queries which can go on a dashboard? But who knows. I tend to think we should make an effort to toss these and see how much pushback we get. In particular, they're very expensive to build relative to their utility (and no one has complained yet that I nuked the Audit count, although it has only been gone for a little while).

Jan 20 2017, 7:24 PM · Profile Menu Item
epriestley added a revision to T12128: Favorites Menu Errata : Unknown Object (Differential Revision).
Jan 20 2017, 7:16 PM · Profile Menu Item
epriestley closed T12129: Mercurial repository updates cause high CPU usage as Invalid.

Sounds good. I'm going to close this since it doesn't seem to be moving toward becoming a bug report which we can accept upstream.

Jan 20 2017, 6:24 PM · Bug Report (Needs Information)
epriestley renamed T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username from when editing bot account settings, the default values suggest I'm editing my own settings to When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username.
Jan 20 2017, 6:20 PM · User Preferences, Bug Report
epriestley triaged T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username as Wishlist priority.

There's a TODO about this in the code:

Jan 20 2017, 6:19 PM · User Preferences, Bug Report
cspeckmim awarded T12134: Develop a Nuance-based Phabricator reporting/support flow a Party Time token.
Jan 20 2017, 6:00 PM · Abuse
epriestley merged task T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 6:00 PM · Public & Media Relations, Support
epriestley merged T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 6:00 PM · Abuse
epriestley added a comment to T9212: Community Feedback: How should we handle free support?.

I'm going to merge this into T12134, which begins defining a more concrete plan roughly following some of the outline above. The major change from an upstream perspective since this task was filed is that we have a more specific set of harder technical requirements around support for Phacility SAAS instances (particularly after the launch of free instances), so it makes more sense to let those requirements drive product design and then accommodate general free support under that umbrella. Broadly, I expect to move support (bug reports, feature requests) into Nuance and continue reducing user access to the upstream.

Jan 20 2017, 6:00 PM · Public & Media Relations, Support
epriestley created T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 5:32 PM · Abuse
epriestley added a revision to T12131: Edit History inserts itself wherever it feels like: Unknown Object (Differential Revision).
Jan 20 2017, 3:40 PM · Bug Report
• Ondrej awarded T2393: Adds a "Needs Verification" state to Audits a Like token.
Jan 20 2017, 3:38 PM · Restricted Project, Audit
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

(This change was half-accidental, and then I just figured I'd roll it into T2393 when I realized I'd made it.)

Jan 20 2017, 3:30 PM · Bug Report
epriestley merged T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Jan 20 2017, 3:30 PM · Restricted Project, Audit
epriestley merged task T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Jan 20 2017, 3:29 PM · Bug Report
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

This did actually change in connection with T10978, but only if audit.can-author-close-audit is configured. I plan to resolve T2393 (maybe today?) and hopefully get rid of "Close" and this option entirely. I'm just going to merge this there.

Jan 20 2017, 3:29 PM · Bug Report
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to work with you one-on-one to help troubleshoot issues in your environment, but we can't offer that kind of support for free. This process almost always takes up a large amount of our time and very rarely uncovers any real bugs in Phabricator or helps anyone except the single user experiencing a configuration problem. See Support Resources for more discussion of the kinds of free and paid support we offer. If you'd like to move forward with one-on-one configuration and environment support, see Consulting.

Jan 20 2017, 12:51 PM · Bug Report (Needs Information)

Jan 19 2017

epriestley edited projects for T12129: Mercurial repository updates cause high CPU usage, added: Bug Report (Needs Information); removed Bug Report.
Jan 19 2017, 11:58 PM · Bug Report (Needs Information)
epriestley awarded Image Macro "tarnation" a Pterodactyl token.
Jan 19 2017, 11:57 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I am unable to reproduce the issue you described by following the steps provided. To move forward:

Jan 19 2017, 10:06 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Here's what I did to try to reproduce this:

Jan 19 2017, 10:04 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

(A synthetic repository which you create by running hg commit in a loop, or instructions which allow us to build such a synthetic repository, are also fine.)

Jan 19 2017, 8:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

An existing, open source project is perfectly fine, provided you first verify that it reproduces the problem.

Jan 19 2017, 8:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

We need specific reproduction steps to move forward, and "a repository with about 2800 commits" isn't sufficiently specific.

Jan 19 2017, 8:35 PM · Bug Report (Needs Information)
epriestley closed T6024: Display (post-push) audit-state in Diffusion commit-list as Resolved by committing Restricted Diffusion Commit.
Jan 19 2017, 7:43 PM · Restricted Project, Audit, Diffusion
epriestley moved T6507: Audit inline comments doesn't account for synthetic authors from Inlines to Future on the Audit board.
Jan 19 2017, 7:32 PM · Audit
epriestley added a comment to T12127: Allow EditEngine forms to have custom icons.

This is easy but I think you want to get rid of all the IconSet stuff and just let everything have any icon?

Jan 19 2017, 7:32 PM · Dashboards, EditEngine
epriestley added a comment to T6507: Audit inline comments doesn't account for synthetic authors.

This report is probably correct and the remedy is likely also correct, but getting lint into Diffusion is completely in shambles so I'm actually not immediately sure how to reproduce it, at least in a reasonable / moderately-convenient way.

Jan 19 2017, 7:31 PM · Audit
epriestley added a revision to T11096: Redesign main header / quick create / search: Unknown Object (Differential Revision).
Jan 19 2017, 7:11 PM · Design
epriestley added a comment to T11096: Redesign main header / quick create / search.

Not intentional -- @chad, I can figure out what's going on there since it might reasonably be me and I have a local repro.

Jan 19 2017, 7:00 PM · Design
epriestley awarded T5867: Move Quick Create to MenuItemEngine a Party Time token.
Jan 19 2017, 6:54 PM · Design
epriestley added a revision to T6024: Display (post-push) audit-state in Diffusion commit-list: Unknown Object (Differential Revision).
Jan 19 2017, 6:53 PM · Restricted Project, Audit, Diffusion
epriestley added a revision to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only: Unknown Object (Differential Revision).
Jan 19 2017, 6:53 PM · Diffusion, Audit, Feature Request
epriestley moved T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only from Backlog to Future on the Audit board.
Jan 19 2017, 4:52 PM · Diffusion, Audit, Feature Request
epriestley renamed T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only from Audits of true merge commits may present duplicate changes in potentially large audit requests to Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.
Jan 19 2017, 4:52 PM · Diffusion, Audit, Feature Request
epriestley edited projects for T12098: Create Revision from FavoritesMenuItem doesn't work, added: Differential; removed Diffusion.
Jan 19 2017, 4:46 PM · Dashboards, Differential
azurasean awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Jan 19 2017, 10:30 AM · Workboards (v3), Restricted Project

Jan 18 2017

epriestley closed T12122: Cannot login to Phabricator as Resolved.
Jan 18 2017, 10:59 PM · Bug Report
epriestley added a comment to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.

I think the big trick on this is going to be making inline comments work somewhat-correctly in the extreme case of octopus merges.

Jan 18 2017, 10:48 PM · Diffusion, Audit, Feature Request
epriestley added a comment to T12122: Cannot login to Phabricator.

Does upgrading past b21cd24341c6552a3fbd21305ca682a161129a6b resolve it?

Jan 18 2017, 10:43 PM · Bug Report
epriestley added projects to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only: Audit, Diffusion.
Jan 18 2017, 9:47 PM · Diffusion, Audit, Feature Request
epriestley added a comment to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.

As an adversarial actor, I can use the proposed rule to avoid audit of dangerous changes like this:

Jan 18 2017, 9:37 PM · Diffusion, Audit, Feature Request
epriestley closed T3917: Avoid or easily handle 'duplicate' audits as Resolved.

My merge of T6557 here was questionable, but I think this is a case where the audits are basically correct and the remedy is better cleanup tools.

Jan 18 2017, 9:12 PM · Restricted Project, Audit
epriestley added a comment to T6557: Automatic auditing should ignore merges.

Sounds good, thanks.

Jan 18 2017, 8:44 PM · Audit
epriestley changed the status of T6557: Automatic auditing should ignore merges from Duplicate to Invalid.

On re-reading T3917 I agree it has approximately nothing to do with this, but see also T5338, where I think I go through a flow like this and it doesn't trigger an audit.

Jan 18 2017, 8:44 PM · Audit
epriestley closed T5338: Incorrect handling of merge commits as Invalid.

Per above, not sure how to reproduce this.

Jan 18 2017, 8:41 PM · Differential, Audit
epriestley added a comment to T5338: Incorrect handling of merge commits.

I don't believe this report, but here goes:

Jan 18 2017, 8:41 PM · Differential, Audit
epriestley added a comment to T6557: Automatic auditing should ignore merges.

I'm having some difficulty figuring out exactly what this and related reports are describing.

Jan 18 2017, 8:34 PM · Audit
epriestley merged task T6557: Automatic auditing should ignore merges into T3917: Avoid or easily handle 'duplicate' audits.
Jan 18 2017, 8:09 PM · Audit
epriestley merged T6557: Automatic auditing should ignore merges into T3917: Avoid or easily handle 'duplicate' audits.
Jan 18 2017, 8:09 PM · Restricted Project, Audit
epriestley added a comment to T6557: Automatic auditing should ignore merges.

I'm going to merge this into T3917, which I think is the broadest description of this issue.

Jan 18 2017, 8:08 PM · Audit
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 18 2017, 8:04 PM · Audit
epriestley moved T10604: Allow application code to stream request data from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:02 PM · Diffusion (v3), Restricted Project
epriestley moved T10900: Repository content search with `hg grep` returns matches found in old versions of files from Backlog to Mercurial on the Diffusion board.
Jan 18 2017, 7:01 PM · Mercurial, Diffusion
epriestley moved T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:01 PM · Diffusion
epriestley moved T11029: Colorized html inline diffs for Diffusion from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:01 PM · Diffusion (v3), Audit
epriestley moved T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:01 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
epriestley moved T11205: Hard/Impossible to disable SSH built-in URIs from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:01 PM · Diffusion (v3), Bug Report
epriestley moved T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:01 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley moved T11165: Changing a callsign throws a 404 from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:00 PM · Diffusion (v3), Bug Report
epriestley moved T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Backlog to v3 on the Diffusion board.
Jan 18 2017, 7:00 PM · Diffusion (v3), Differential, Mail
epriestley moved T11968: Decide the fate of FutureGraph from Backlog to v3 on the Diffusion board.
Jan 18 2017, 6:59 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley moved T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches from Backlog to v3 on the Diffusion board.
Jan 18 2017, 6:59 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley moved T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist from Backlog to v3 on the Diffusion board.
Jan 18 2017, 6:59 PM · Diffusion (v3), Arcanist, Differential
epriestley moved T12033: Large diffs can still repeatedly fail to insert from Backlog to v3 on the Diffusion board.
Jan 18 2017, 6:59 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley moved T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) from Backlog to v3 on the Diffusion board.
Jan 18 2017, 6:59 PM · Diffusion, Herald, Bug Report
epriestley closed T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure as Wontfix.

I'm going to close this as "Wontfix". Although adding custom fields is something we may still do, I no longer expect to "rebuild" on top of that infrastructure.

Jan 18 2017, 6:39 PM · Restricted Project, Diffusion, Custom Fields
epriestley closed T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure, a subtask of T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234", as Wontfix.
Jan 18 2017, 6:39 PM · Maniphest
epriestley closed T5889: Allow herald rules to act on existence of auditors as Resolved by committing Restricted Diffusion Commit.
Jan 18 2017, 6:05 PM · Restricted Project, Audit, Herald
epriestley moved T3917: Avoid or easily handle 'duplicate' audits from Audit States to Commit Identity on the Audit board.
Jan 18 2017, 5:56 PM · Restricted Project, Audit
epriestley moved T5338: Incorrect handling of merge commits from Herald to Commit Identity on the Audit board.
Jan 18 2017, 5:56 PM · Differential, Audit
epriestley moved T6557: Automatic auditing should ignore merges from Herald to Commit Identity on the Audit board.
Jan 18 2017, 5:56 PM · Audit
epriestley added a comment to T5889: Allow herald rules to act on existence of auditors.

D17221 adds an "Auditors" field to Herald.

Jan 18 2017, 5:54 PM · Restricted Project, Audit, Herald
epriestley added a revision to T5889: Allow herald rules to act on existence of auditors: Unknown Object (Differential Revision).
Jan 18 2017, 5:53 PM · Restricted Project, Audit, Herald
epriestley closed T12119: `arc diff --reviewers foo` puts reviewers into Summary field as Invalid.

making the old version of arc continue working as it did, if trivial, with new versions of the backend

Jan 18 2017, 5:31 PM · Bug Report
epriestley added a comment to T12119: `arc diff --reviewers foo` puts reviewers into Summary field.

goes away after upgrading both to latest

Jan 18 2017, 4:14 PM · Bug Report
epriestley added a revision to T5867: Move Quick Create to MenuItemEngine: Unknown Object (Differential Revision).
Jan 18 2017, 3:58 PM · Design
epriestley closed T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED' as Resolved by committing Restricted Diffusion Commit.
Jan 18 2017, 3:45 PM · Audit, Diffusion, Conduit, Bug Report
epriestley added a comment to T5132: Document the special syntax you can use in commit messages to cause effects.

No. This task covers documenting this syntax.

Jan 18 2017, 3:43 PM · Guides, Diffusion
sgielen awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 18 2017, 3:25 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12118: Differential email does not contain reviewers/subscribers information anymore.

After a quick look, ModularTransactions doesn't currently expose a shouldHideFormMail() hook and I may want to do something a little more tailored here, so fixing this isn't a one-liner.

Jan 18 2017, 2:36 PM · Restricted Project, Differential, Bug Report
epriestley closed T12112: Upload file stalles network connections as Invalid.

This does not appear to be moving forward as a valid bug report which we can accept upstream.

Jan 18 2017, 2:30 PM · Bug Report (Needs Information)
epriestley added a comment to T12118: Differential email does not contain reviewers/subscribers information anymore.

For context, this is a side effect of the move to EditEngine in T11114.

Jan 18 2017, 2:25 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.

Thanks, D17218 should fix this.

Jan 18 2017, 2:08 PM · Audit, Diffusion, Conduit, Bug Report
epriestley moved T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED' from Backlog to EditEngine on the Audit board.
Jan 18 2017, 2:08 PM · Audit, Diffusion, Conduit, Bug Report
epriestley claimed T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.
Jan 18 2017, 2:07 PM · Audit, Diffusion, Conduit, Bug Report