Page MenuHomePhabricator

When a branch in Diffusion is not tracked, the UI should be explicit about it
Closed, WontfixPublic

Description

To reproduce:

  • Configure a repository to "Track Only: example".
  • Leave "Default Branch: master".
  • View repository main detail page.

Commits on master are shown, despite the branch not being tracked, so they will never be imported.

This is correct, but confusing. Clearer would be a message like "You are viewing an untracked branch." with no commits shown. Additional cases:

  • Create a new repository, immediately set it to track only stable before activating it, activate it, view main page.
  • View a branch which does not exist, and is tracked.
  • View a branch which does not exist, and is not tracked.
  • View a branch which exists, and is tracked.
  • Delete a tracked branch, then view it in the web UI.
  • Close a branch in Mercurial, then view it.

See PHI930 for a report of this.

Event Timeline

epriestley moved this task from Backlog to v3 on the Diffusion board.Jan 18 2017, 7:01 PM
epriestley edited projects, added Diffusion (v3); removed Diffusion.
chad updated the task description. (Show Details)Aug 17 2017, 5:22 PM
chad updated the task description. (Show Details)
epriestley moved this task from v3 to "Track Only" on the Diffusion board.Mon, Apr 15, 4:30 PM
epriestley edited projects, added Diffusion; removed Diffusion (v3).
epriestley closed this task as Wontfix.
epriestley claimed this task.

See T13277. I'm moving us away from "Track Only", and our behavior is already reasonable under "Fetch Rules" + "Permanent Refs".

(Branches and tags which are not permanent refs could reasonably show a hint about this, but the behavior should not be misleading.)