Page MenuHomePhabricator

Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234"
Closed, DuplicatePublic


Noticed the difference between rP4c143ad3b2c4bb6e9d15e2eefda5432455fc3a9a and rPccd4ae56382762fa2631e1c0a521e4ebaa5f2926.

The first one appears on T4205 because it contains "Ref T4205" in the summary. The latter one does not appear, even though it has "Maniphest Tasks: T4205" in it (the first one has this as well).

Generally I think commits should be picked up by the task if the diff they reference is associated so that there isn't inconsistent behaviour (it also means that all diffs that are associated with a task that get closed off get the nice "D1234 / rP4c143ad3" format).

Event Timeline

hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Maniphest.
hach-que added subscribers: hach-que, epriestley.

This whole thing needs some work; see also T3906 / T3577.

@chad some of your commits are affected too, for example rP695f0b09b23761c813b015c2b62075cbdee1de59, better if you add for example a Ref T99999 ;)