Page MenuHomePhabricator

sgielen (Sjors Gielen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 31 2015, 3:01 PM (308 w, 3 d)
Availability
Available

Recent Activity

May 16 2017

sgielen awarded T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL a The World Burns token.
May 16 2017, 3:21 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

Ah, I see that it works differently in other shells. The above output was from zsh. In bash, indeed all output is written to the file:

May 16 2017, 12:52 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

It shows no output because there are no warnings. If you replace phabricator/bin/storage dump with a command that does give various formats of warnings on stderr, you see that it works:

$ sh -c 'echo "output1"; echo "error\nwarning\nerror2" 1>&2; echo "output2"' >foo.txt 2> >(grep -v warning)
error
error2
$ cat foo.txt
output1
output2
May 16 2017, 12:47 PM · Bug Report
sgielen added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

I used the subshell redirection trick as mentioned by @epriestley to hide this warning from our cron output as well:

May 16 2017, 11:43 AM · Bug Report

Jan 18 2017

sgielen awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 18 2017, 3:25 PM · Prioritized, Restricted Project, Infrastructure

Aug 22 2016

sgielen added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

FWIW, in our case the bug was also triggered by logging in for the first time (for this account) using LDAP.

Aug 22 2016, 8:47 PM · Contributor Onboarding, Setup

Jul 7 2016

sgielen added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

I just had this problem as well. Turns out I had a typo in preamble.php. A more descriptive error would be nice, but with this task open at least the cause is easy to find :)

Jul 7 2016, 12:30 PM · Contributor Onboarding, Setup
sgielen added a comment to T10794: Upgrading: Changes to Aphlict (Real-Time Notifications) Configuration.

Note that it is possible to set a path to the websocket for every server as well. This is handy, for example, when your notification websocket is hosted behind the same URL as Phabricator itself. We have https://phabricator.ourcompany.net/ for Phabricator itself, and https://phabricator.ourcompany.net/ws/ for the notifictions websocket. This corresponds to the following client config:

Jul 7 2016, 12:00 PM · Installing & Upgrading, Aphlict

Mar 30 2016

sgielen added a comment to T9293: WebSockets access problems with reverse SSL proxy .

Using client-uri will cause us to use wss:// on pages which are http:// on the client. This seems very confusing/unexpected to me. Although this is probably fine usually, it defies user intent and may not work if, for example, the server certificate is self-signed and the user is using http specifically because their client does not recognize the CA. Such a user would be confused: "I'm connecting with HTTP and it says HTTP in my browser, but I'm getting an SSL certificate error. I specifically switched to HTTP because I know that this client can not trust the certificate."

Mar 30 2016, 5:38 PM · Restricted Project, Aphlict
sgielen added a comment to T9293: WebSockets access problems with reverse SSL proxy .

$_SERVER['HTTPS'] should always reflect the SSL-ness of the original connection. If it does not, it is misconfigured.

Mar 30 2016, 3:00 PM · Restricted Project, Aphlict
sgielen added a comment to T9293: WebSockets access problems with reverse SSL proxy .

We will not trust X-Forwarded-Proto, X-Forwarded-For, etc., by default because they are not trustworthy in the general case (they are completely client-controlled if you aren't behind a load-balancer).

Mar 30 2016, 2:54 PM · Restricted Project, Aphlict

Mar 6 2016

renatomassaro awarded T9293: WebSockets access problems with reverse SSL proxy a Manufacturing Defect? token.
Mar 6 2016, 11:36 AM · Restricted Project, Aphlict

Dec 25 2015

cwang awarded T9293: WebSockets access problems with reverse SSL proxy a Love token.
Dec 25 2015, 4:06 PM · Restricted Project, Aphlict

Dec 16 2015

ablekh awarded T9293: WebSockets access problems with reverse SSL proxy a Love token.
Dec 16 2015, 9:57 AM · Restricted Project, Aphlict

Aug 31 2015

sgielen added a comment to T9293: WebSockets access problems with reverse SSL proxy .

T8982 is somewhat related, since it is about wrong parsing of notification.client-uri (but it is not related in that it may have the same fix).

Aug 31 2015, 6:55 PM · Restricted Project, Aphlict
tycho.tatitscheff awarded T9293: WebSockets access problems with reverse SSL proxy a Love token.
Aug 31 2015, 6:21 PM · Restricted Project, Aphlict
sgielen added a comment to T9293: WebSockets access problems with reverse SSL proxy .
commit 33c3ebe0606580efc22c410f654a9fa76655779a
Author: Sjors Gielen <sjors@sjorsgielen.nl>
Date:   Mon Aug 31 17:29:00 2015 +0200
Aug 31 2015, 3:31 PM · Restricted Project, Aphlict
sgielen created T9293: WebSockets access problems with reverse SSL proxy .
Aug 31 2015, 3:28 PM · Restricted Project, Aphlict