Page MenuHomePhabricator
Feed Advanced Search

Mar 30 2016

epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

To prevent this, I plan to:

Mar 30 2016, 12:37 PM · Phacility, Ops
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

Here's the smoking gun from /var/log/syslog:

Mar 30 2016, 12:33 PM · Phacility, Ops
epriestley created T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.
Mar 30 2016, 5:49 AM · Phacility, Ops
epriestley created T10694: Improve behavior of context for inline comments in mail.
Mar 30 2016, 1:49 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.

See also T5701 for bonus complexity.

Mar 30 2016, 12:09 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley renamed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments from HTML email doesn't syntax highlight code blocks to HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Mar 30 2016, 12:09 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley closed T10693: Allow setting --plan-changes in Differential UI as Resolved.
Mar 30 2016, 12:02 AM · Feature Request

Mar 29 2016

epriestley added a comment to T10693: Allow setting --plan-changes in Differential UI.

This option should already be available from the UI. Here's a screenshot?

Mar 29 2016, 11:47 PM · Feature Request
epriestley updated subscribers of T4190: Rebuild remarkup image proxying.

@jshirley, here's the issue we spoke about earlier.

Mar 29 2016, 11:26 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

Anyway, assuming this is a "freedom and flexibility" issue over a "perform only reasonable operations" issue, we're definitely open to implementing forking, but this is probably in the realm of prioritization with a nontrivial set of infrastructure and product blockers.

Mar 29 2016, 11:11 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

I think I'm still missing something here -- are users doing this?

Mar 29 2016, 10:52 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

In this case, does the branch contain reviewed changes, or just draft changes by multiple different authors?

Mar 29 2016, 5:54 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10688: Badge translation error.

I think these steps should reproduce the issue:

Mar 29 2016, 5:22 PM · Badges, Bug Report
epriestley updated subscribers of T10574: A pathway toward "All Reviewers Must Accept".
Mar 29 2016, 3:26 PM · FreeBSD, Restricted Project, Differential
epriestley merged task T10689: Display slightly more information about status of revision from main page. into T10574: A pathway toward "All Reviewers Must Accept".
Mar 29 2016, 3:26 PM · Feature Request (Needs Information)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

Root problem: To ensure quality software, I want to make sure that all reviewers accept a change.

Mar 29 2016, 3:26 PM · Feature Request (Needs Information)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

I think that's just a rewording of the original description, and doesn't provide any new insight or context. It still focuses on a very narrow symptom problem (not being able to see individual reviewer status from the revision list), not the root problem.

Mar 29 2016, 2:30 PM · Feature Request (Needs Information)
epriestley created T10690: Allow badges to be searched by name.
Mar 29 2016, 2:24 PM · Badges (v0)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 29 2016, 2:18 PM · Nuance (v1)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

T1279 is talking about the reviewer list on the detail page (/Dxxx), not the list page (/differential/). This was implemented years ago, so I suspect it isn't a duplicate, unless you're years out of date.

Mar 29 2016, 2:04 PM · Feature Request (Needs Information)
epriestley moved T10689: Display slightly more information about status of revision from main page. from Backlog to Needs Information on the Feature Request board.
Mar 29 2016, 1:51 PM · Feature Request (Needs Information)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

Thanks for the request!

Mar 29 2016, 1:43 PM · Feature Request (Needs Information)
epriestley assigned T10688: Badge translation error to lpriestley.

D15545 should fix the infrastructure part of this, and make this error more clear by returning an explicit diagnostic error rather than a mostly-working string and a log.

Mar 29 2016, 12:33 PM · Badges, Bug Report
epriestley added a revision to T10688: Badge translation error: Unknown Object (Differential Revision).
Mar 29 2016, 12:31 PM · Badges, Bug Report
epriestley added a comment to T10688: Badge translation error.

Oh, I believe the actual issue is that the translations are variant on the wrong parameter. I think this is the correct fix (adding an extra array()):

Mar 29 2016, 12:10 PM · Badges, Bug Report
epriestley added a comment to T10688: Badge translation error.

D15544 (changing %s to %d) shouldn't be the fix for this -- %s is correct, because we want to render "1,234,567" if the number is large:

Mar 29 2016, 12:08 PM · Badges, Bug Report

Mar 28 2016

epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 28 2016, 7:46 PM · Nuance (v1)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 28 2016, 7:46 PM · Nuance, GitHub
epriestley assigned T6526: Implement "Badges" or "Medals", for annotating special users to lpriestley.
Mar 28 2016, 7:36 PM · Restricted Project, Badges (v0), People
epriestley assigned T8940: Annotate badges with awarder, date to lpriestley.
Mar 28 2016, 7:36 PM · Badges (v0)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 28 2016, 6:44 PM · Nuance, GitHub
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 28 2016, 6:35 PM · Nuance (v1)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 28 2016, 6:00 PM · Nuance (v1)
epriestley updated subscribers of T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines.

D15535 should completely fix this in all cases

Mar 28 2016, 5:36 PM · Remarkup, Bug Report
epriestley added a revision to T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines: Unknown Object (Differential Revision).
Mar 28 2016, 5:24 PM · Remarkup, Bug Report
epriestley closed T10686: Remarkup: Unable to use italics on a quoted header line as Resolved by committing Restricted Diffusion Commit.
Mar 28 2016, 4:12 PM · Remarkup, Bug Report
epriestley added a revision to T10686: Remarkup: Unable to use italics on a quoted header line: Unknown Object (Differential Revision).
Mar 28 2016, 4:11 PM · Remarkup, Bug Report
epriestley claimed T10686: Remarkup: Unable to use italics on a quoted header line.

u wot m8? havin' a go? havin' a little laff?

Mar 28 2016, 4:09 PM · Remarkup, Bug Report
epriestley added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

Specifically, the issue here is that we fetch and import branch heads, but not other refs, including tags. We also aren't totally consistent about which refs we import across hosted/imported repositories.

Mar 28 2016, 3:35 PM · Wikimedia, Restricted Project, Diffusion

Mar 27 2016

epriestley added a subtask for T10364: Conpherence v4 (UI/UX): T10683: New Conpherence participant makes the conversation unread but does not update subtitle.
Mar 27 2016, 7:34 PM · Conpherence (v4)
epriestley added a parent task for T10683: New Conpherence participant makes the conversation unread but does not update subtitle: T10364: Conpherence v4 (UI/UX).
Mar 27 2016, 7:34 PM · Conpherence (v4), Bug Report
epriestley added a comment to T10682: Applications have no profile photos when they author transactions.

At a minimum, Herald, Harbormaster, Nuance, Phortune and Differential can author stories today, although not all of these stories currently render with photos. We should probably assume any application may author stories.

Mar 27 2016, 7:00 PM · Restricted Project, Harbormaster, Bug Report
epriestley renamed T10682: Applications have no profile photos when they author transactions from Harbormaster has no "user photo" in feed to Applications have no profile photos when they author transactions.
Mar 27 2016, 6:58 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T10682: Applications have no profile photos when they author transactions.

See also vaguely-related T8952.

Mar 27 2016, 5:33 PM · Restricted Project, Harbormaster, Bug Report
epriestley created T10681: Add Phurl Conduit API methods .
Mar 27 2016, 5:04 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley renamed T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion from Audit form in Diffusion should be optional to Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
Mar 27 2016, 5:02 PM · Audit, Diffusion, Wikimedia
epriestley updated subscribers of T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
Mar 27 2016, 5:01 PM · Audit, Diffusion, Wikimedia
epriestley merged task T10680: If Audit app is uninstalled, you can still add comments to a commit and "raise concern" but it fails with 404 into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
Mar 27 2016, 5:01 PM · Bug Report
epriestley created T10679: When phurl.short-uri is configured, use it in the UI.
Mar 27 2016, 4:55 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley closed T9745: Configure phurl.io against secure.phabricator.com, a subtask of T6049: Implement Phurl, a URL shortener/bookmarking application, as Resolved.
Mar 27 2016, 4:52 PM · Phurl
epriestley closed T9745: Configure phurl.io against secure.phabricator.com as Resolved.

This is now fully configured.

Mar 27 2016, 4:52 PM · Ops, Phurl
epriestley created T10678: Consider roadblocking redirects from Phurl in some cases.
Mar 27 2016, 4:24 PM · Phurl
epriestley closed T9744: Harden Phurl against anchor reattachment as Wontfix.

I ultimately don't think there's any really reasonable way we can fix this that doesn't have a cost and complexity far greater than the benefit.

Mar 27 2016, 4:16 PM · Security, Phurl
epriestley closed T9744: Harden Phurl against anchor reattachment, a subtask of T6049: Implement Phurl, a URL shortener/bookmarking application, as Wontfix.
Mar 27 2016, 4:16 PM · Phurl

Mar 26 2016

epriestley closed T10114: Upgrading: Amazon S3 Configuration Changes as Resolved.

This has been live for some time without any apparent issues.

Mar 26 2016, 9:02 PM · Installing & Upgrading, Files
epriestley closed T10199: NSS on Red Hat derivative OSes does not support ECC cipher-suites and can not connect to CloudFlare HTTPS as Wontfix.

We haven't seen further reports of this in more than two months, so I don't plan to mitigate it at the application level.

Mar 26 2016, 7:44 PM · Infrastructure
epriestley closed T10239: Ability to pass more info to custom linters as Resolved.

Presuming resolved by getPathChangedLines($path) + -lines.

Mar 26 2016, 7:36 PM · Feature Request
epriestley closed T10240: Copy Comment as Invalid.

This request doesn't describe a root problem, so we can't develop a solution to it. We haven't received any new information in more than a month. See Describing Root Problems and Contributing Feature Requests for help describing root problems and filing feature requests that the usptream can accept.

Mar 26 2016, 7:32 PM · Feature Request (Needs Information)
epriestley closed T10302: Workflow.js is picking up 7px from somewhere as Resolved by committing Restricted Diffusion Commit.
Mar 26 2016, 7:29 PM · PHUI, Bug Report
epriestley closed T10296: SSLRead() return error -9806 on git clone as Invalid.

We can't reproduce this and we haven't learned any new information in more than a month, so I'm going to close it.

Mar 26 2016, 7:29 PM · Bug Report (Needs Information), Diffusion
epriestley added a revision to T10302: Workflow.js is picking up 7px from somewhere: Unknown Object (Differential Revision).
Mar 26 2016, 7:26 PM · PHUI, Bug Report
epriestley closed T10356: Unhandled Exception ("FilesystemException") after adding Github repo as Invalid.

This report does not include reproduction steps. Bug reports must include complete, self-contained reproduction steps to be accepted by the upstream. See Providing Reproduction Steps for help.

Mar 26 2016, 7:15 PM · Diffusion, Bug Report
epriestley updated subscribers of T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.
Mar 26 2016, 7:12 PM · Inline Comments, Differential, Restricted Project
epriestley merged task T8610: No threaded comments --hard to follow in line comments when two bugs exist on one line into T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.
Mar 26 2016, 7:12 PM · Restricted Project
epriestley closed T8610: No threaded comments --hard to follow in line comments when two bugs exist on one line as Wontfix.

I'm going to merge this into T10563 which is narrower but more actionable.

Mar 26 2016, 7:12 PM · Restricted Project
epriestley closed T10365: Support passing generated annotation to ArcanistGeneratedLinter as Invalid.

We don't have enough information about this problem to design a solution, and haven't received more information in more than a month. See Describing Root Problems and Contributing Feature Requests for details on how to submit an actionable feature request.

Mar 26 2016, 7:08 PM · Feature Request (Needs Information), Lint
epriestley closed T10385: Diffusion code view doesn't hide blame pane as Resolved by committing Restricted Diffusion Commit.
Mar 26 2016, 7:06 PM · Diffusion (v3), Mobile
epriestley claimed T10385: Diffusion code view doesn't hide blame pane.
Mar 26 2016, 6:58 PM · Diffusion (v3), Mobile
epriestley added a revision to T10385: Diffusion code view doesn't hide blame pane: Unknown Object (Differential Revision).
Mar 26 2016, 6:58 PM · Diffusion (v3), Mobile
epriestley edited the content of Changelog.
Mar 26 2016, 1:49 PM
epriestley created 2016 Week 13 (Very Late March).
Mar 26 2016, 1:48 PM

Mar 25 2016

epriestley closed T10674: Latest HEAD broke viewing unit test results in Harbormaster as Resolved by committing Restricted Diffusion Commit.
Mar 25 2016, 10:49 PM · Harbormaster, Bug Report
epriestley added a revision to T10674: Latest HEAD broke viewing unit test results in Harbormaster: Unknown Object (Differential Revision).
Mar 25 2016, 10:46 PM · Harbormaster, Bug Report
cwre awarded T10584: Allow users to amend revisions they don't own, without commandeering them a Like token.
Mar 25 2016, 8:11 PM · Differential
epriestley renamed T9819: Allow Phurl URLs to reference objects from Allow multiple aliases to a Phurl URL to Allow Phurl URLs to reference objects.
Mar 25 2016, 8:06 PM · Restricted Project, Phurl
epriestley created T10673: Convert Phurl to use EditEngine.
Mar 25 2016, 7:36 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley claimed T9744: Harden Phurl against anchor reattachment.
Mar 25 2016, 7:33 PM · Security, Phurl
epriestley moved T9745: Configure phurl.io against secure.phabricator.com from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Ops, Phurl
epriestley moved T6049: Implement Phurl, a URL shortener/bookmarking application from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Phurl
epriestley moved T9744: Harden Phurl against anchor reattachment from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Security, Phurl
epriestley moved T9819: Allow Phurl URLs to reference objects from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Restricted Project, Phurl
chad awarded T10672: Complete EditEngine implementation in Badges a Orange Medal token.
Mar 25 2016, 7:21 PM · Badges (v0)
epriestley created T10672: Complete EditEngine implementation in Badges.
Mar 25 2016, 7:18 PM · Badges (v0)
epriestley created T10671: Implement `badges.search` and `badges.edit` Conduit API methods.
Mar 25 2016, 7:15 PM · Restricted Project, Conduit, Badges (v0)
epriestley moved T9007: Allow Badges to be ordered by quality from Backlog to v0 on the Badges board.
Mar 25 2016, 7:10 PM · Badges (v0)
epriestley moved T10670: When a user has been awarded badges but all their badges are archived, their profile shows an empty panel from Backlog to v0 on the Badges board.
Mar 25 2016, 7:10 PM · Badges (v0)
epriestley reassigned T8941: Badges don't show in certain Timeline conditions from chad to lpriestley.

Take a look at this and see how far you can get? It might be really easy but it might also be very involved.

Mar 25 2016, 7:09 PM · Badges (v0)
epriestley assigned T9007: Allow Badges to be ordered by quality to lpriestley.

It's currently impossible to sort badges by rarity because they rarities are internally 'grey', 'white', 'green', etc., and there is no natural order to these. For example, MySQL has no idea what order 'indigo', 'orange' and 'yellow' should go in, except alphabetical, which is not actually the correct order.

Mar 25 2016, 7:03 PM · Badges (v0)
epriestley created T10670: When a user has been awarded badges but all their badges are archived, their profile shows an empty panel.
Mar 25 2016, 5:37 PM · Badges (v0)
• bitglue awarded T9456: Evaluate upstream support for third-party build systems a Mountain of Wealth token.
Mar 25 2016, 5:34 PM · Restricted Project, Harbormaster
epriestley renamed T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Unable to edit/delete inline comments in Pholio to Inline comments do not support editing (Pholio, Differential, Diffusion).
Mar 25 2016, 5:30 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley updated subscribers of T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).
Mar 25 2016, 5:29 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley merged task T10669: Can't edit inline comments on diff into T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).
Mar 25 2016, 5:29 PM · Feature Request
epriestley created T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI.
Mar 25 2016, 5:12 PM · Inline Comments, Restricted Project, Differential
epriestley moved T10667: Improve ambiguity when resolving commits that appear in multiple repositories from Backlog to v3 on the Diffusion board.
Mar 25 2016, 2:45 PM · Diffusion (v3)
epriestley added a project to T10667: Improve ambiguity when resolving commits that appear in multiple repositories: Remarkup.
Mar 25 2016, 2:44 PM · Diffusion (v3)
epriestley closed T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException as Resolved.

Sounds good, let us know if you run into anything else.

Mar 25 2016, 2:43 PM · Passphrase, Bug Report
epriestley created T10667: Improve ambiguity when resolving commits that appear in multiple repositories.
Mar 25 2016, 2:42 PM · Diffusion (v3)
epriestley added a comment to T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException.

For completeness, T10651 is the earlier report.

Mar 25 2016, 2:36 PM · Passphrase, Bug Report
epriestley added a comment to T10665: Incorrect divergent heads message on mercurial push.

I think this should now be resolved in HEAD of master. It will likely promote to stable in about 24 hours.

Mar 25 2016, 2:35 PM · Bug Report