Page MenuHomePhabricator
Create Task
Maniphest T10688

Badge translation error
Closed, ResolvedPublic
Actions

Description

Seeing this in my sandbox currently. Investigating.

Object of class PhutilSafeHTML could not be converted to int
Stack trace:
PhutilTranslator::chooseVariant called at [/Users/familyroom/Sites/libphutil/src/internationalization/PhutilTranslator.php:69]
PhutilTranslator::translate
call_user_func_array called at [/Users/familyroom/Sites/libphutil/src/internationalization/pht.php:17]
pht called at [/Users/familyroom/Sites/phabricator/src/applications/badges/storage/PhabricatorBadgesTransaction.php:227]
PhabricatorBadgesTransaction::getTitleForFeed called at [/Users/familyroom/Sites/phabricator/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php:90]
PhabricatorApplicationTransactionFeedStory::renderView called at [/Users/familyroom/Sites/phabricator/src/applications/feed/builder/PhabricatorFeedBuilder.php:62]
PhabricatorFeedBuilder::buildView called at [/Users/familyroom/Sites/phabricator/src/applications/people/controller/PhabricatorPeopleProfileViewController.php:257]
PhabricatorPeopleProfileViewController::buildPeopleFeed called at [/Users/familyroom/Sites/phabricator/src/applications/people/controller/PhabricatorPeopleProfileViewController.php:54]
PhabricatorPeopleProfileViewController::handleRequest called at [/Users/familyroom/Sites/phabricator/src/aphront/configuration/AphrontApplicationConfiguration.php:237]
AphrontApplicationConfiguration::processRequest called at [/Users/familyroom/Sites/phabricator/src/aphront/configuration/AphrontApplicationConfiguration.php:149]
AphrontApplicationConfiguration::runHTTPRequest called at [/Users/familyroom/Sites/phabricator/webroot/index.php:17]

Revisions and Commits

rPHU libphutil
D15545rPHUc274930326c7 Make it more clear when a translation provides bad variants
rP Phabricator
D15544rP2386705873bd Allow awarding Badges from the profile
D15547rP8d67629e9ec0 Fix translation of badge feed stories.

Related Objects

Event Timeline

chad created this task.Mar 29 2016, 2:37 AM
Herald added a subscriber: eadler. · View Herald TranscriptMar 29 2016, 2:37 AM
chad added a revision: D15544: Allow awarding Badges from the profile.Mar 29 2016, 3:04 AM
epriestley added a subscriber: epriestley.Mar 29 2016, 12:08 PM

D15544 (changing %s to %d) shouldn't be the fix for this -- %s is correct, because we want to render "1,234,567" if the number is large:

https://secure.phabricator.com/book/phabcontrib/article/internationalization/#using-phutilnumber

Let me see what's going on here.

epriestley added a comment.Mar 29 2016, 12:10 PM

Oh, I believe the actual issue is that the translations are variant on the wrong parameter. I think this is the correct fix (adding an extra array()):

diff --git a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
index 492d68d..2b7d48c 100644
--- a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
+++ b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
@@ -1545,16 +1545,20 @@ final class PhabricatorUSEnglishTranslation
 
       '%s awarded %s to %s recipient(s): %s.' => array(
         array(
-          '%s awarded %s to recipient: %4$s.',
-          '%s awarded %s to recipients: %4$s.',
-        ),
+          array(
+            '%s awarded %s to recipient: %4$s.',
+            '%s awarded %s to recipients: %4$s.',
+          ),
+        )
       ),
 
       '%s revoked %s from %s recipient(s): %s.' => array(
         array(
-          '%s revoked %s from recipient: %4$s.',
-          '%s revoked %s from recipients: %4$s.',
-        ),
+          array(
+            '%s revoked %s from recipient: %4$s.',
+            '%s revoked %s from recipients: %4$s.',
+          ),
+        )
       ),
     );
   }

I'll see if I can improve the error handling.

epriestley added a revision: D15545: Make it more clear when a translation provides bad variants.Mar 29 2016, 12:31 PM
epriestley assigned this task to lpriestley.Mar 29 2016, 12:33 PM

D15545 should fix the infrastructure part of this, and make this error more clear by returning an explicit diagnostic error rather than a mostly-working string and a log.

We should also fix the translation data part of this: these translations should be corrected in the translation data file so they vary on the correct parameter.

epriestley mentioned this in D15544: Allow awarding Badges from the profile.Mar 29 2016, 12:55 PM
epriestley added a commit: rPHUc274930326c7: Make it more clear when a translation provides bad variants.Mar 29 2016, 1:49 PM
lpriestley added a comment.Mar 29 2016, 5:20 PM

How do I reproduce this error?

epriestley added a comment.Mar 29 2016, 5:22 PM

I think these steps should reproduce the issue:

  • Update libphutil.
  • Change language to "English (US)" if not already set to that.
  • View feed stories about badge awards.

At HEAD, stories with a data issue should render obviously:

Screen Shot 2016-03-29 at 5.23.31 AM.png (567×1 px, 156 KB)

Prior to D15545, these same steps reproduced the issue, except that it wasn't nearly as obvious that there was an issue, since the error got handled pretty quietly. You had to have DarkConsole set up and/or be looking at the error log.

lpriestley added a revision: D15547: Fix translation of badge feed stories..Mar 29 2016, 5:38 PM
lpriestley closed this task as Resolved by committing rP8d67629e9ec0: Fix translation of badge feed stories..Mar 29 2016, 5:56 PM
lpriestley added a commit: rP8d67629e9ec0: Fix translation of badge feed stories..
chad added a commit: rP2386705873bd: Allow awarding Badges from the profile.Mar 31 2016, 8:39 PM
Phabricator · Built by Phacility