Page MenuHomePhabricator
Feed Advanced Search

May 15 2017

epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with subproject "Warp Drive > Thermocoupling"?
Do you expect a task to be able to be tagged with "Warp Drive" and also simultaneously tagged with milestone "Warp Drive > Milestone 1"?

May 15 2017, 2:44 PM · Bug Report
eliaspro added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

What it looks like here:
We have the project Grammofy Collections which represents one of our products.
It has a milestone Full Catalog Access
It also has a subproject Grammofy Collections: Frontend/Web

May 15 2017, 2:38 PM · Bug Report
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

This should now be resolved in HEAD of master and stable. Thanks for the report!

May 15 2017, 1:45 PM · Projects, Bug Report
epriestley closed T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them as Resolved by committing Restricted Diffusion Commit.
May 15 2017, 1:44 PM · Projects, Bug Report
epriestley renamed T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them from Project profile broken to Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.
May 15 2017, 1:43 PM · Projects, Bug Report
epriestley edited projects for T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them, added: Bug Report, Projects; removed Bug Report (Needs Information).
May 15 2017, 1:42 PM · Projects, Bug Report
epriestley added a comment to T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.

I can't reproduce this. Here's an example of a profile working correctly for me locally:

May 15 2017, 11:12 AM · Projects, Bug Report
mrthomasbrix created T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.
May 15 2017, 7:31 AM · Projects, Bug Report

May 14 2017

chad added a comment to T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.

T12708 is the same root bug. This was more engineering than I could handle.

May 14 2017, 8:48 PM · Dashboards, Bug Report
chad merged task T12708: Editing of Dashboard Tab Panels can delete Tabs into T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.
May 14 2017, 8:46 PM · Bug Report
chad merged T12708: Editing of Dashboard Tab Panels can delete Tabs into T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.
May 14 2017, 8:46 PM · Dashboards, Bug Report
benwick added a comment to T12708: Editing of Dashboard Tab Panels can delete Tabs.

Yeah, these two bugs are probably connected. But the reproductions steps in my setup are surely more common 😄 When I tried to setup the main dashboard for our install, we changed the tabs a lot of times to find the right way to present the important infos for our users. This swallowing of tabs was pretty frustrating...

May 14 2017, 8:26 PM · Bug Report
eliaspro added a comment to T12708: Editing of Dashboard Tab Panels can delete Tabs.

Duplicate of T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned

May 14 2017, 8:18 PM · Bug Report
benwick created T12708: Editing of Dashboard Tab Panels can delete Tabs.
May 14 2017, 7:36 PM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

BTW, the original patch was generated using git format-patch, not git diff

May 14 2017, 1:39 AM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

The original patch which causes this problem is attached. It was generated using git version 2.10.1.windows.1. git am 0001-Move-lld-Parallel-algorithms-to-llvm.patch will successfully apply the patch, but after uploading it to phabricator and then redownloading the raw diff, it no longer applies. The original patch contains text like this:

May 14 2017, 1:37 AM · Bug Report

May 12 2017

epriestley triaged T12701: Harbormaster does not ignore additional whitespace in HTTP URLs, making invalid HTTP requests as Low priority.

T11632 is vaguely related.

May 12 2017, 5:49 PM · Security, Harbormaster, Bug Report
epriestley added a comment to T12702: Unable to apply raw diff when files are moved.

Oh, no problem -- we likely won't look into this for a while anyway (T12664 is a big mess of related issues that we'll probably try to fix all at once).

May 12 2017, 5:48 PM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

Sorry, I've been slacking on getting you this information. Been swamped at
work. I'll try to get it to you this weekend.

May 12 2017, 5:47 PM · Bug Report
epriestley closed T12705: Set visibility through arc diff as Invalid.

See Contributing Feature Requests, but also note that we're likely to restrict this channel soon because no one reads that document (see T12134#212579).

May 12 2017, 5:40 PM · Bug Report
epriestley added a comment to T12702: Unable to apply raw diff when files are moved.

(We probably won't look at this until T12664 moves forward, but when it does it would definitely be helpful to have a specific set of steps we can take to reproduce the issue locally in a clean repository.)

May 12 2017, 5:39 PM · Bug Report
franziskus created T12705: Set visibility through arc diff.
May 12 2017, 5:38 PM · Bug Report
epriestley added a parent task for T12702: Unable to apply raw diff when files are moved: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 12 2017, 5:37 PM · Bug Report
stephane.chazelas added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

Isn't that a dup of T8611?

May 12 2017, 1:43 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
asherkin closed T12704: test as Invalid.

This is not a demo or test install. Please don't make a mess! You can launch a demo install on Phacility if you want to poke around and try things out.

May 12 2017, 12:23 PM · Bug Report
• thirupu.somu created T12704: test.
May 12 2017, 10:45 AM · Bug Report

May 11 2017

avivey added a project to T12703: When integrated, CircleCI and Harbormaster can send redundant notifications: Harbormaster.
May 11 2017, 7:20 PM · Feature Request, Harbormaster
ry created T12703: When integrated, CircleCI and Harbormaster can send redundant notifications.
May 11 2017, 5:49 PM · Feature Request, Harbormaster
chad updated the image for Bug Report from Unknown Object (File) to F4952490: fa-bug-yellow.png.
May 11 2017, 5:28 PM

May 10 2017

zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

This is rather strange. I don't have the original patch used to create the revision anymore, but I tried it again using the same command I always use to generate patches, and when I upload this new patch, I do not see the same issue. In the first (broken) one, some of the files are marked with V, but in the new (working) one, none of the files are marked as V. This is even though git status shows that they are renames:

May 10 2017, 8:13 PM · Bug Report
avivey added a comment to T12702: Unable to apply raw diff when files are moved.

Which version of git was used? Can you upload the original patch file used to create the diff?
Which version of git is the server using?

May 10 2017, 7:52 PM · Bug Report
avivey closed T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok as Wontfix.
May 10 2017, 7:41 PM · Bug Report
cxzzero moved T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok from Backlog to Fishing Expeditions on the Bug Report board.
May 10 2017, 5:24 PM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

Note that a workaround is to do the following:

May 10 2017, 4:53 PM · Bug Report
zjturner updated subscribers of T12702: Unable to apply raw diff when files are moved.
May 10 2017, 4:47 PM · Bug Report
zjturner created T12702: Unable to apply raw diff when files are moved.
May 10 2017, 4:46 PM · Bug Report
cxzzero added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

Excellent! Thanks @avivey.
This ticket could be closed.

May 10 2017, 12:48 PM · Bug Report
mormegil created T12701: Harbormaster does not ignore additional whitespace in HTTP URLs, making invalid HTTP requests.
May 10 2017, 10:17 AM · Security, Harbormaster, Bug Report

May 9 2017

jeffprouty added a comment to T12696: broadcast_main has weird behavior with RC channel for sprayer config.

@epriestley Whoops! So embarrassed. Thanks :)

May 9 2017, 10:35 PM · Bug Report
epriestley closed T12699: MP does not respect MavFrame in .waypoints file. as Invalid.

You're on the wrong install by mistake.

May 9 2017, 10:33 PM · Bug Report
epriestley closed T12698: Spray is on when returning to land! as Invalid.

You're on the wrong install by mistake.

May 9 2017, 10:33 PM · Bug Report
epriestley closed T12697: Altitude for TakeOff should match waypoint altitudes for spray mission as Invalid.

You're on the wrong install by mistake.

May 9 2017, 10:33 PM · Bug Report
jeffprouty created T12699: MP does not respect MavFrame in .waypoints file..
May 9 2017, 10:32 PM · Bug Report
jeffprouty created T12698: Spray is on when returning to land!.
May 9 2017, 10:31 PM · Bug Report
epriestley closed T12696: broadcast_main has weird behavior with RC channel for sprayer config as Invalid.

I think you've filed this against the wrong install by mistake.

May 9 2017, 10:30 PM · Bug Report
jeffprouty created T12697: Altitude for TakeOff should match waypoint altitudes for spray mission.
May 9 2017, 10:30 PM · Bug Report
jeffprouty created T12696: broadcast_main has weird behavior with RC channel for sprayer config.
May 9 2017, 10:29 PM · Bug Report
avivey added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

It saves it to a directory called arc in your repository meta-directory. If you're using git, it would be in .git/arc/.

May 9 2017, 9:28 PM · Bug Report
cxzzero added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

Thanks for your reply.

May 9 2017, 9:22 PM · Bug Report
epriestley added a revision to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000: Restricted Differential Revision.
May 9 2017, 9:01 PM · Inline Comments, Differential, Bug Report
avivey added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

You can user arc set-config --local to set a configuration value in a file that is in the repository but is not committed.

May 9 2017, 8:51 PM · Bug Report
avivey updated the task description for T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.
May 9 2017, 8:43 PM · Bug Report
cxzzero updated the task description for T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.
May 9 2017, 8:35 PM · Bug Report
cxzzero created T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.
May 9 2017, 8:33 PM · Bug Report
epriestley added a comment to T12689: Mail is still received after resigning from a revision.

You can't explicitly subscribe to a revision you're a reviewer for because being a reviewer makes you an automatic subscriber (and, due to a similar bug to the one here, probably can't subscribe even if you've resigned, today), so you'd need to resign, then explicitly subscribe. Also, I'm not sure we handle the other way (explicitly unsubscribe, then later become a reviewer) correctly. These are tractable.

May 9 2017, 4:11 PM · Mail, Differential, Bug Report
tomheng created T12690: phpcs linter report No such linter standard.
May 9 2017, 3:32 AM

May 8 2017

joshuaspence added a comment to T12689: Mail is still received after resigning from a revision.

(But what if you meant "I'm not going to review this but still want to keep an eye on it" instead of "I'm not going to review this and don't care about it at all"?)

May 8 2017, 11:58 PM · Mail, Differential, Bug Report
epriestley added a comment to T12689: Mail is still received after resigning from a revision.
  • There's probably one fairly narrow bug bug here: DifferentialTransactionEditor->getMailTo() likely includes resigned users but should not.
  • Beyond that, when you've resigned, we should probably exclude you from getting indirect mail via a project/package? Maybe? (But what if you meant "I'm not going to review this but still want to keep an eye on it" instead of "I'm not going to review this and don't care about it at all"?)
May 8 2017, 11:00 PM · Mail, Differential, Bug Report
joshuaspence added a comment to T12689: Mail is still received after resigning from a revision.

rPbcd87e0e3f3756970d26d5e9c4a60e4be73ef6a6
rARC3c4735795a2963c5ddff6dceaf60122d01ca3dc0
rPHUa900d7b63e954e221efe140f0f33d3d701524aae

May 8 2017, 10:37 PM · Mail, Differential, Bug Report
chad added a comment to T12689: Mail is still received after resigning from a revision.

Need version information, please.

May 8 2017, 10:36 PM · Mail, Differential, Bug Report
joshuaspence created T12689: Mail is still received after resigning from a revision.
May 8 2017, 10:21 PM · Mail, Differential, Bug Report
chad added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.

There were no commits between friday and today, so I'm not following what you're trying to tell us.

May 8 2017, 5:35 PM · Windows, Bug Report (Needs Information)
chad added a comment to T10541: Maniphest report by project not showing proper results.

Just merging this over to Facts, I don't anticipate allocating any resources to Maniphest reports before Facts ships.

May 8 2017, 5:26 PM · Maniphest, Bug Report
chad merged task T10541: Maniphest report by project not showing proper results into T1562: Build "Facts", an ETL pipeline and charting application.
May 8 2017, 5:25 PM · Maniphest, Bug Report
epriestley added a comment to T12676: Dialog box closes with ESC key even when there's unsaved change.

T10469 is vaguely related.

May 8 2017, 2:38 PM · Bug Report
cxzzero renamed T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows from When submitting an arc diff, svn diff or updating a revision a Parse Error ocurrs in Windows to When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.
May 8 2017, 2:28 PM · Windows, Bug Report (Needs Information)
cxzzero renamed T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows from When submitting a svn diff or updating a revision a Parse Error ocurrs in Windows to When submitting an arc diff, svn diff or updating a revision a Parse Error ocurrs in Windows.
May 8 2017, 2:27 PM · Windows, Bug Report (Needs Information)
cxzzero created T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.
May 8 2017, 2:26 PM · Windows, Bug Report (Needs Information)

May 7 2017

ikeydoherty added a comment to T12686: Arcanist unable to patch with initial commit.

The works here are on behalf of Solus, for the Solus infrastructure, and not that of my employer, and as such have blanket "own time approval" for the umbrella "Solus Project". This much I can do. Signing a CLA of any description for any purpose is what would entangle employers, something I cannot do.

May 7 2017, 6:08 PM · Bug Report
epriestley added a comment to T12686: Arcanist unable to patch with initial commit.

At this time I'm presently unable to sign a CLA (apologies) due to employment situation, however what I can do is make the following diff Public Domain and relinquish any claims to it, should Phacility wish to correct this behaviour in upstream Phabricator.

May 7 2017, 6:02 PM · Bug Report
epriestley merged task T12686: Arcanist unable to patch with initial commit into T4751: `arc patch` fails in empty repositories.
May 7 2017, 5:54 PM · Bug Report
ikeydoherty added a comment to T12686: Arcanist unable to patch with initial commit.

Sidenote, it does turn out that in any instance, this will require some kind of empty commit for HEAD to exist, i.e. Repo constructed - but this change at least allows the empty commit to work.

May 7 2017, 4:58 PM · Bug Report
ikeydoherty created T12686: Arcanist unable to patch with initial commit.
May 7 2017, 4:43 PM · Bug Report

May 6 2017

chad added a project to T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username: User Preferences.
May 6 2017, 7:00 PM · User Preferences, Bug Report
avivey merged T12683: Managing a bot accounts pronoun shows users name instead of the bots into T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username.
May 6 2017, 6:59 PM · User Preferences, Bug Report
avivey merged task T12683: Managing a bot accounts pronoun shows users name instead of the bots into T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username.
May 6 2017, 6:59 PM · User Preferences, Bug Report
chad added a project to T12683: Managing a bot accounts pronoun shows users name instead of the bots: User Preferences.
May 6 2017, 5:41 PM · User Preferences, Bug Report
chad renamed T12683: Managing a bot accounts pronoun shows users name instead of the bots from Managing' a bot account's pronoun shows user's name instead of the bot's to Managing a bot accounts pronoun shows users name instead of the bots.
May 6 2017, 5:39 PM · User Preferences, Bug Report
cspeckmim created T12683: Managing a bot accounts pronoun shows users name instead of the bots.
May 6 2017, 5:28 PM · User Preferences, Bug Report
epriestley added a comment to T12682: `storage --dry-run` actually looks rather wet when applying patches.

Sorry about that! Thanks for the report.

May 6 2017, 2:57 AM · Bug Report
epriestley closed T12682: `storage --dry-run` actually looks rather wet when applying patches as Resolved by committing Restricted Diffusion Commit.
May 6 2017, 2:57 AM · Bug Report
epriestley added a revision to T12682: `storage --dry-run` actually looks rather wet when applying patches: Restricted Differential Revision.
May 6 2017, 2:56 AM · Bug Report
epriestley claimed T12682: `storage --dry-run` actually looks rather wet when applying patches.

Possibly we should just remove this flag because bin/storage status is equivalent and bin/storage adjust prompts by default, buuut...

May 6 2017, 2:54 AM · Bug Report
chad added a comment to T12682: `storage --dry-run` actually looks rather wet when applying patches.

guess macro has a bug too

May 6 2017, 2:26 AM · Bug Report
neilfitz added a comment to T12682: `storage --dry-run` actually looks rather wet when applying patches.

Us right now:

May 6 2017, 2:18 AM · Bug Report
alexmv created T12682: `storage --dry-run` actually looks rather wet when applying patches.
May 6 2017, 2:15 AM · Bug Report

May 5 2017

chad added a comment to T12675: Burnup rate month date shown in tool tip is off by one (January is month zero).

Specifically, you will be able to get this information from Facts.

May 5 2017, 3:39 PM · Maniphest, Bug Report
chad added a comment to T12675: Burnup rate month date shown in tool tip is off by one (January is month zero).

It's correct, we will not be allocating resources to fix this before shipping Facts.

May 5 2017, 3:38 PM · Maniphest, Bug Report
aklapper updated subscribers of T12675: Burnup rate month date shown in tool tip is off by one (January is month zero).

@chad: Errrm, I assume that translates to "wontfix"? Because I don't see how a specific well-defined issue in an existing part of Phabricator is a duplicate of "Build some new tool".

May 5 2017, 3:36 PM · Maniphest, Bug Report
faulconbridge added a comment to T12676: Dialog box closes with ESC key even when there's unsaved change.

FWIW this behavior has also caused data loss on our team more than once. I'll usually trigger it when I'm going to insert a backtick somewhere in the task description to block off pseudocode and I fat-finger Esc instead.

May 5 2017, 2:37 PM · Bug Report
aubort added a comment to T12676: Dialog box closes with ESC key even when there's unsaved change.

Yes, here's the testimony of one of our user,

May 5 2017, 2:33 PM · Bug Report
chad added a comment to T12676: Dialog box closes with ESC key even when there's unsaved change.

Is this something you actually encountered and lost data?

May 5 2017, 2:25 PM · Bug Report
chad merged task T12675: Burnup rate month date shown in tool tip is off by one (January is month zero) into T1562: Build "Facts", an ETL pipeline and charting application.
May 5 2017, 1:50 PM · Maniphest, Bug Report
aubort updated the task description for T12676: Dialog box closes with ESC key even when there's unsaved change.
May 5 2017, 1:49 PM · Bug Report
aubort created T12676: Dialog box closes with ESC key even when there's unsaved change.
May 5 2017, 1:46 PM · Bug Report
aklapper created T12675: Burnup rate month date shown in tool tip is off by one (January is month zero).
May 5 2017, 11:30 AM · Maniphest, Bug Report

May 4 2017

epriestley closed T12669: differential.revision.search doesn't return the reviewers. as Resolved.

Sounds good, let us know if you run into issues.

May 4 2017, 4:34 PM · Bug Report
cos added a comment to T12669: differential.revision.search doesn't return the reviewers..

thanks - I'll upgrade!

May 4 2017, 4:21 PM · Bug Report
epriestley added a comment to T12669: differential.revision.search doesn't return the reviewers..

You should be able to use the "reviewers" attachment to get reviewer information. Here's an example of a query which asks for this attachment, and a response which includes it:

May 4 2017, 3:40 PM · Bug Report
cos created T12669: differential.revision.search doesn't return the reviewers..
May 4 2017, 2:54 PM · Bug Report