Page MenuHomePhabricator
Create Task
Maniphest T12710

Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them
Closed, ResolvedPublic
Actions

Description

Reproduction

  1. Go to project profile.

Error

Unhandled Exception ("PhabricatorDataNotAttachedException")

Attempting to access attached data on PhabricatorProject, but the data is not actually attached. Before accessing attachable data on an object, you must load and attach it.
Data is normally attached by calling the corresponding needX() method on the Query class when the object is loaded. You can also call the corresponding attachX() method explicitly.

Version

I'm on master commit 89e567ffd94594bd7ab8f2deb7fab3b2f632d1a9.

Revisions and Commits

rP Phabricator
D17882rP5fee24fa4311 (stable) Add required needMembers/needWatchers calls to Project…
D17882rP7f54f79fd1c3 Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs

Related Objects

Event Timeline

mrthomasbrix created this task.May 15 2017, 7:30 AM
epriestley added a subscriber: epriestley.May 15 2017, 11:12 AM

I can't reproduce this. Here's an example of a profile working correctly for me locally:

Screen Shot 2017-05-15 at 4.12.13 AM.png (1×1 px, 95 KB)

Can you reproduce this issue on this install?

epriestley edited projects, added Bug Report (Needs Information); removed Bug Report.May 15 2017, 11:12 AM
mrthomasbrix added a comment.EditedMay 15 2017, 11:38 AM

Yes on the Almanac project profile.

epriestley added a subscriber: chad.May 15 2017, 1:35 PM

I think more narrow reproduction instructions are:

  • Find a project which has active subprojects or milestones.
  • View the profile tab or the "Subprojects" tab.

@chad, this is because PhabricatorProjectListView needs members and watchers after D17880.

The project profile tab uses a list view to show subprojects.

The project "Subprojects" tab uses a list view to show subprojects and milestones.

We can fix this by just adding needMembers() + needWatchers() everywhere, but that results in these broken-ish/redundant/silly/questionable interfaces:

Screen Shot 2017-05-15 at 6.31.49 AM.png (1×1 px, 204 KB)

Screen Shot 2017-05-15 at 6.33.36 AM.png (159×318 px, 13 KB)

epriestley added a comment.May 15 2017, 1:36 PM

I'll just ship up the "unbreak" diff, and you can either counter-diff me or figure out something else.

epriestley added a revision: D17882: Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs.May 15 2017, 1:38 PM
epriestley edited projects, added Bug Report, Projects; removed Bug Report (Needs Information).May 15 2017, 1:42 PM
Herald added a subscriber: eadler. · View Herald TranscriptMay 15 2017, 1:42 PM
epriestley renamed this task from Project profile broken to Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.May 15 2017, 1:43 PM
epriestley closed this task as Resolved by committing rP7f54f79fd1c3: Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs.May 15 2017, 1:44 PM
epriestley added a commit: rP7f54f79fd1c3: Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs.
epriestley added a commit: rP5fee24fa4311: (stable) Add required needMembers/needWatchers calls to Project….
epriestley added a comment.May 15 2017, 1:45 PM

This should now be resolved in HEAD of master and stable. Thanks for the report!

Phabricator · Built by Phacility