Page MenuHomePhabricator

zjturner (Zachary Turner)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 10 2017, 4:07 PM (192 w, 4 d)
Availability
Available

Recent Activity

May 14 2017

zjturner added a comment to T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.

Not sure if I should make a separate issue for this or just mention it here, but it would be nice if you could parse the "signature" of a patch generated with git format-patch. Currently patches generated with git format-patch cannot even be uploaded to Phabricator unless you set git config format.signature=""

May 14 2017, 3:58 AM · Arcanist, Differential
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

BTW, the original patch was generated using git format-patch, not git diff

May 14 2017, 1:39 AM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

The original patch which causes this problem is attached. It was generated using git version 2.10.1.windows.1. git am 0001-Move-lld-Parallel-algorithms-to-llvm.patch will successfully apply the patch, but after uploading it to phabricator and then redownloading the raw diff, it no longer applies. The original patch contains text like this:

May 14 2017, 1:37 AM · Bug Report

May 12 2017

zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

Sorry, I've been slacking on getting you this information. Been swamped at
work. I'll try to get it to you this weekend.

May 12 2017, 5:47 PM · Bug Report

May 10 2017

zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

This is rather strange. I don't have the original patch used to create the revision anymore, but I tried it again using the same command I always use to generate patches, and when I upload this new patch, I do not see the same issue. In the first (broken) one, some of the files are marked with V, but in the new (working) one, none of the files are marked as V. This is even though git status shows that they are renames:

May 10 2017, 8:13 PM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

Note that a workaround is to do the following:

May 10 2017, 4:53 PM · Bug Report
zjturner updated subscribers of T12702: Unable to apply raw diff when files are moved.
May 10 2017, 4:47 PM · Bug Report
zjturner created T12702: Unable to apply raw diff when files are moved.
May 10 2017, 4:46 PM · Bug Report