Page MenuHomePhabricator

Editing of Dashboard Tab Panels can delete Tabs
Closed, DuplicatePublic

Description

My Phabricator Version
phabricator d2baa88171fcc3f327b157277afb905430b5a918 (Thu, Apr 27)

But the bug is also reproducible on this install.

Reproduction steps:

  • Create a new Dashboard
  • Create four new Query Panels of any kind (named "Query 1", "Query 2", "Query 3", "Query 4")
  • Create a new Tab Panel and edit it:
    • Tab 1 Name: "Tab 1" / Tab 1 Panel: the created "Query 1"
    • Tab 2 Name: "Tab 2" / Tab 2 Panel: the created "Query 2"
    • Tab 3 Name: "Tab 3" / Tab 3 Panel: the created "Query 3"
  • Save Panel und then edit it again:
    • edit Tab 2 and use "Query 4" as the Tab 2 Panel
  • Save Panel

Expected result:

  • A Tab Panel with 3 Tabs
    • 1st Tab with name "Tab 1" and Panel "Query 1"
    • 2nd Tab with name "Tab 2" and Panel "Query 4"
    • 3rd Tab with name "Tab 3" and Panel "Query 3"

Actual result:

  • A Tab Panel with 2 Tabs
    • 1st Tab with name "Tab 1" and Panel "Query 1"
    • 2nd Tab with name "Tab 3" and Panel "Query 3"

One Tab was swallowed ...

Event Timeline

benwick created this task.May 14 2017, 7:35 PM

Yeah, these two bugs are probably connected. But the reproductions steps in my setup are surely more common ๐Ÿ˜„ When I tried to setup the main dashboard for our install, we changed the tabs a lot of times to find the right way to present the important infos for our users. This swallowing of tabs was pretty frustrating...