Page MenuHomePhabricator
Feed Advanced Search

Feb 26 2017

Mnkras added a comment to T12296: Improve Phacility repository import performance.

@epriestley all other commits that have the message "This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref." have imported, so I don't think the reachable code is working correctly, as until within the last few weeks I wasn't seeing these "This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref." commits showing up, but now I see them all the time.

Feb 26 2017, 1:30 AM · Customer Impact, Diffusion, Ops

Feb 24 2017

20after4 added a comment to T12296: Improve Phacility repository import performance.

The commit cache should be a fairly large performance win.

Feb 24 2017, 7:22 PM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

Ah, okay. This is the relevant part:

Feb 24 2017, 6:46 PM · Customer Impact, Diffusion, Ops
Mnkras added a comment to T12296: Improve Phacility repository import performance.

@epriestley
https://test-3uoifmrptebb.phacility.com/R2:80233a27d7b72bb03710d358e12a531ce46808a9

Feb 24 2017, 6:25 PM · Customer Impact, Diffusion, Ops
epriestley added a revision to T12296: Improve Phacility repository import performance: Restricted Differential Revision.
Feb 24 2017, 6:05 PM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

Starting with repository update:

Feb 24 2017, 5:56 PM · Customer Impact, Diffusion, Ops
20after4 added a comment to T12296: Improve Phacility repository import performance.

My impression is that there is a lot of room for optimization in the RepositoryPullLocalDaemon. I've wanted to tackle that for a while because it causes a fair delay between when a commit goes into git and when it actually shows up in Diffusion.

Feb 24 2017, 10:45 AM · Customer Impact, Diffusion, Ops

Feb 21 2017

Mnkras added a comment to T12296: Improve Phacility repository import performance.

@epriestley The import has finished, but some commits show as importing still?

Feb 21 2017, 8:33 PM · Customer Impact, Diffusion, Ops

Feb 20 2017

bcooksley added a project to T5698: Github-style Remarkup previews on a checked-in resource: KDE.
Feb 20 2017, 10:01 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley added a comment to T12296: Improve Phacility repository import performance.

There's also a bunch of the usual free-tier shenanigans on this host -- free instances with 1 user importing multiple large repositories -- but that's to be expected.

Feb 20 2017, 4:10 PM · Customer Impact, Diffusion, Ops
epriestley created T12296: Improve Phacility repository import performance.
Feb 20 2017, 4:09 PM · Customer Impact, Diffusion, Ops

Feb 19 2017

yuanchen.zhu added a comment to T5028: Commit message text formatting in remote git repository (SSH) is not preserved.

Hi I recently started experimenting with phabricator with my team and stumbled on this issue.

Feb 19 2017, 7:26 PM · Diffusion
epriestley added a comment to T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.

The in-diff issue is described in T11482.

Feb 19 2017, 7:10 PM · Diffusion, Feature Request
Mnkras added a comment to T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.

We once rendered these renames like this:

new/path/to/file.c
  Moved From: old/path/to/file.c

Personally I like that, I think a compromise to make it easier to consume, would be to try and group the moves together and showing the relation, for example
now:

a ->
b ->
a <-
b <-

to

a ->
a <-
b ->
b <-
Feb 19 2017, 7:06 PM · Diffusion, Feature Request
epriestley added a comment to T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.

I'm not sure I understand what changes you're suggesting.

Feb 19 2017, 6:43 PM · Diffusion, Feature Request
Mnkras updated the task description for T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.
Feb 19 2017, 6:37 PM · Diffusion, Feature Request
Mnkras created T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.
Feb 19 2017, 6:08 PM · Diffusion, Feature Request

Feb 14 2017

eadler closed T12176: Importing large SVN repository causes a full disk as Invalid.

closed per user request

Feb 14 2017, 11:03 PM · Bug Report (Needs Information), Daemons, Diffusion
matthewrbowker added a comment to T12176: Importing large SVN repository causes a full disk.

@epriestley Please close this task (I can't).

Feb 14 2017, 10:54 PM · Bug Report (Needs Information), Daemons, Diffusion

Feb 13 2017

epriestley added a comment to T12253: null in remarkup rather than comment reference when quoting a comment in audit.

Thanks, this should now be fixed in HEAD of master. Let us know if you run into anything else.

Feb 13 2017, 3:44 PM · Diffusion, Bug Report
epriestley closed T12253: null in remarkup rather than comment reference when quoting a comment in audit as Resolved by committing Restricted Diffusion Commit.
Feb 13 2017, 3:44 PM · Diffusion, Bug Report
epriestley added a revision to T12253: null in remarkup rather than comment reference when quoting a comment in audit: Restricted Differential Revision.
Feb 13 2017, 3:42 PM · Diffusion, Bug Report
epriestley claimed T12253: null in remarkup rather than comment reference when quoting a comment in audit.
Feb 13 2017, 3:38 PM · Diffusion, Bug Report

Feb 10 2017

jcox closed T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock as Resolved by committing Restricted Diffusion Commit.
Feb 10 2017, 5:38 PM · Diffusion, Bug Report
jcox added a revision to T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock: Restricted Differential Revision.
Feb 10 2017, 5:30 PM · Diffusion, Bug Report
yelirekim assigned T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock to jcox.
Feb 10 2017, 5:19 PM · Diffusion, Bug Report
yelirekim created T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock.
Feb 10 2017, 5:19 PM · Diffusion, Bug Report

Feb 3 2017

epriestley added a comment to T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".

"Bizarro Gremlin" is just an alias for Quicksand

Feb 3 2017, 10:05 PM · Diffusion, Differential, Bug Report
thoughtpolice added a comment to T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".

i'm bad at search

Feb 3 2017, 10:00 PM · Diffusion, Differential, Bug Report
epriestley merged task T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes" into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Feb 3 2017, 9:59 PM · Diffusion, Differential, Bug Report
thoughtpolice renamed T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes" from Bizarro Gremlin on secure.phabricator.com to Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".
Feb 3 2017, 9:59 PM · Diffusion, Differential, Bug Report
thoughtpolice created T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".
Feb 3 2017, 9:57 PM · Diffusion, Differential, Bug Report
bcooksley added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

I would imagine they're using something along those lines yes. I think we'll probably keep a bunch of people happy if pushing Git refs up were supported.

Feb 3 2017, 7:13 AM · KDE, Restricted Project, Diffusion, Differential
chad added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

I'm just curious how people are generating diffs, just command line then cut and paste? I would presume those users would be fine with pushing a branch up for review. Are there other methods we're not considering, like IDEs?

Feb 3 2017, 7:08 AM · KDE, Restricted Project, Diffusion, Differential
bcooksley added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

Chances are we're going to get complaints that go either way. Myself, i'd tend to prefer T5000.

Feb 3 2017, 7:06 AM · KDE, Restricted Project, Diffusion, Differential
chad added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

You would prefer this over T5000?

Feb 3 2017, 7:01 AM · KDE, Restricted Project, Diffusion, Differential
bcooksley added a project to T5029: Fill in missing context for low-context diffs against tracked repositories: KDE.

We've had some people in KDE kick up some fuss about this.

Feb 3 2017, 6:52 AM · KDE, Restricted Project, Diffusion, Differential

Feb 2 2017

epriestley renamed T12184: Large (~750MB) git push fails over SSH from Large GIT push fails over SSH or HTTP to Large (~750MB) git push fails over SSH.
Feb 2 2017, 7:45 PM · Diffusion, Bug Report
epriestley renamed T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable from Umlauts in commit messages show up as ? in emails and on the web to Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Feb 2 2017, 4:13 PM · Diffusion (v3)
epriestley moved T11781: Hosted SVN repo doesn't work with SSH on nondefaut port from Backlog to Subversion on the Diffusion board.
Feb 2 2017, 4:11 PM · Diffusion, Bug Report
epriestley moved T10754: Remove Subversion daemon working copy operations from Backlog to Subversion on the Diffusion board.
Feb 2 2017, 4:10 PM · Subversion, Diffusion, Daemons, Infrastructure
epriestley moved T10253: Importing linux git repository fails on one commit claiming non-utf8 string is used instead of utf8 from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:09 PM · Diffusion, Bug Report
epriestley moved T8276: Diffusion shows no author information if it was associated with a deleted user from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:09 PM · Restricted Project, Diffusion
epriestley moved T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:09 PM · Restricted Project, Diffusion, Bug Report
epriestley moved T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push. from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Diffusion
epriestley moved T8874: Git push to hosted repository slow from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Diffusion
epriestley moved T8747: "Path Does Not Exist" error caused by not standard characters from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Diffusion
epriestley moved T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Diffusion
epriestley moved T8170: Diffusion -> show raw file doesn't always render text from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Diffusion
epriestley moved T8007: Commit was associated with unrelated diff from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Differential, Diffusion
epriestley moved T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Diffusion (v3)
epriestley moved T7022: diffusion - doesn't understand svn Replace operation from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:08 PM · Bug Report, Diffusion, Subversion
epriestley moved T6980: verifySubversionRoot generates a Error while updating the "example" repository from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:07 PM · Subversion, Diffusion
epriestley moved T6891: Daemon fails to parse SVN Folder with Whitespace from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:07 PM · Diffusion, Subversion
epriestley closed T6221: "Fixes" should work in comment text on revisions, not just summary text as Wontfix.

This is from a million years ago and I now think we should only respect commit messages. If "Fixes Txxx" works or ever worked in comments, I'd say we should actually undo that.

Feb 2 2017, 4:06 PM · Diffusion, Daemons
epriestley closed T5924: SVN discovery fails to detect bad subpath as Invalid.

This is more than two years old and no one else seems to have hit it since then. Declining until we see a modern report.

Feb 2 2017, 4:05 PM · Diffusion, Subversion
epriestley closed T5886: Commit imported into wrong repository (as duplicate) as Invalid.

This report is more than two years old, and we haven't seen other similar reports. If you are still affected by this bug, please file a new request following the guidelines in Contributing Bug Reports. In particular, we need specific reproduction instructions we can follow to reproduce it locally, not just screenshots.

Feb 2 2017, 4:04 PM · Diffusion
epriestley moved T3788: Improve encoding management in Diffusion from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:02 PM · Restricted Project, Diffusion
epriestley moved T1758: Diffusion reveals EOF context incorrectly for unchanged missing newline from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:02 PM · Diffusion
epriestley closed T1180: Allow users to navigate between revisions when viewing a file. as Wontfix.

We haven't seen more interest in this since 2012 and this task no longer meets modern criteria for feature requests (see Contributing Feature Requests).

Feb 2 2017, 4:01 PM · Diffusion
epriestley moved T491: Inline Comments for Paste / Diffusion Files from Backlog to Far Future on the Diffusion board.
Feb 2 2017, 3:58 PM · Restricted Project, Diffusion, Paste
epriestley moved T5826: Behaviour of "browse" while viewing a commit only in one branch from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Diffusion
epriestley moved T5028: Commit message text formatting in remote git repository (SSH) is not preserved from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Diffusion
epriestley moved T4801: Error with unclear next steps from `git push` to hosted repository from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Git, Diffusion
epriestley moved T4405: Detect `sudo` errors on HTTP repository access from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Diffusion
epriestley moved T4255: SVN property changes on directories not shown in Diffusion diff views? from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Subversion, Diffusion
epriestley moved T4197: Change parser fails for changes affecting paths longer than 512 characters from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:57 PM · Diffusion
epriestley moved T4030: Phabricator can't process commits which delete files from a relocated directory from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:57 PM · Diffusion, Subversion
epriestley moved T2999: When we detect a file as binary, explain why from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:57 PM · Diffusion, Arcanist
epriestley moved T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool from Backlog to Far Future on the Diffusion board.
Feb 2 2017, 3:57 PM · Diffusion
epriestley edited projects for T11968: Decide the fate of FutureGraph, added: Diffusion; removed Diffusion (v3).
Feb 2 2017, 3:54 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley edited projects for T9524: Show aggregate subdirectory coverage in Diffusion browse views, added: Diffusion; removed Diffusion (v3).

Kicking this out of scope for now.

Feb 2 2017, 3:48 PM · Diffusion, Restricted Project
epriestley merged T12188: Provide a global configuration option for repository "Autoclose On" branch setting into T10691: Support GitHub-like forking of repositories.
Feb 2 2017, 2:07 PM · Restricted Project, Diffusion, Feature Request
cspeckmim added a revision to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position: Restricted Differential Revision.
Feb 2 2017, 7:51 AM · Diffusion, Mercurial
chad created T12185: Action Lists on Repository edit pages don't display on tablet/mobile.
Feb 2 2017, 6:38 AM · Diffusion (v3), Bug Report
chad added a project to T12163: Long lines overflow in Diffusion browser: PHUI.
Feb 2 2017, 2:07 AM · Bug Report, Diffusion (v3), PHUI

Jan 31 2017

matthewrbowker added a comment to T12176: Importing large SVN repository causes a full disk.

@epriestley That's fair, I'll see what I can do.

Jan 31 2017, 7:13 PM · Bug Report (Needs Information), Daemons, Diffusion
epriestley edited projects for T12176: Importing large SVN repository causes a full disk, added: Bug Report (Needs Information); removed Bug Report.

Because of the complexity of building a reproduction case and high chance that this is a wild goose chase, we'll move forward with this after a community member confirms it reproduces for them. See T12134 for some discussion. See T12129 for a similar recent report which was a time-consuming wild goose chase.

Jan 31 2017, 7:00 PM · Bug Report (Needs Information), Daemons, Diffusion
matthewrbowker created T12176: Importing large SVN repository causes a full disk.
Jan 31 2017, 6:06 PM · Bug Report (Needs Information), Daemons, Diffusion
techdragon added a comment to T10691: Support GitHub-like forking of repositories.

I think most of these changes are independently good, at least, but supporting this practice is largely handing users rope so they can shoot themselves in the feet.

@epriestley Not that it will likely make you feel any better about it, but some of us just really want our Guns-Made-From-Rope™ to be powered by Phabricator instead of other much less awesome things. 😄

Jan 31 2017, 4:02 PM · Restricted Project, Diffusion, Feature Request

Jan 30 2017

epriestley updated the task description for T12168: Upgrading: Owners Packages/Commits now use edges.
Jan 30 2017, 7:53 PM · Diffusion (v3), Installing & Upgrading, Audit
epriestley triaged T12168: Upgrading: Owners Packages/Commits now use edges as Normal priority.
Jan 30 2017, 7:51 PM · Diffusion (v3), Installing & Upgrading, Audit
epriestley created T12168: Upgrading: Owners Packages/Commits now use edges.
Jan 30 2017, 7:51 PM · Diffusion (v3), Installing & Upgrading, Audit

Jan 27 2017

eadler added a comment to T12163: Long lines overflow in Diffusion browser.

sorry that our DEEP NEURAL NETWORK TECHNOLOGY can not yet READ MINDS

Jan 27 2017, 7:03 PM · Bug Report, Diffusion (v3), PHUI
chad added a comment to T12163: Long lines overflow in Diffusion browser.

I'm just going to rename Differential everywhere.

Jan 27 2017, 7:03 PM · Bug Report, Diffusion (v3), PHUI
epriestley added a comment to T12163: Long lines overflow in Diffusion browser.

sorry that our DEEP NEURAL NETWORK TECHNOLOGY can not yet READ MINDS

Jan 27 2017, 7:02 PM · Bug Report, Diffusion (v3), PHUI
chad added a comment to T12163: Long lines overflow in Diffusion browser.

typeaheads are useless

Jan 27 2017, 7:01 PM · Bug Report, Diffusion (v3), PHUI
epriestley edited projects for T12163: Long lines overflow in Diffusion browser, added: Diffusion; removed Differential.

(I think this only impacts Diffusion, not Differential.)

Jan 27 2017, 5:29 PM · Bug Report, Diffusion (v3), PHUI
epriestley merged T1731: Allow users to set their VCS names into T12164: Put an indirection layer between author/committer strings and user accounts.
Jan 27 2017, 5:11 PM · Customer Impact, Diffusion (v3)
epriestley merged task T1731: Allow users to set their VCS names into T12164: Put an indirection layer between author/committer strings and user accounts.
Jan 27 2017, 5:11 PM · FreeBSD, Diffusion
epriestley added a comment to T1731: Allow users to set their VCS names.

I'm going to merge this into T12164, which I think is a more powerful approach on this.

Jan 27 2017, 5:11 PM · FreeBSD, Diffusion
epriestley created T12164: Put an indirection layer between author/committer strings and user accounts.
Jan 27 2017, 5:06 PM · Customer Impact, Diffusion (v3)

Jan 24 2017

epriestley moved T12151: Repository mail silencing rules aren't intuitive if you audit an importing repository from Backlog to Future on the Audit board.
Jan 24 2017, 3:44 PM · Phacility, Diffusion, Audit
epriestley created T12151: Repository mail silencing rules aren't intuitive if you audit an importing repository.
Jan 24 2017, 2:21 PM · Phacility, Diffusion, Audit

Jan 23 2017

epriestley merged T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file into T8170: Diffusion -> show raw file doesn't always render text.
Jan 23 2017, 5:16 PM · Diffusion
epriestley merged task T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file into T8170: Diffusion -> show raw file doesn't always render text.
Jan 23 2017, 5:16 PM · Diffusion, Bug Report
chad updated the task description for T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file.
Jan 23 2017, 5:15 PM · Diffusion, Bug Report
Mnkras renamed T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file from "View Raw File" in Diffusion no longer takes you to the raw output of a the file to "View Raw File" in Diffusion no longer takes you to the raw output of the file.
Jan 23 2017, 5:11 PM · Diffusion, Bug Report
Mnkras created T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file.
Jan 23 2017, 5:11 PM · Diffusion, Bug Report
epriestley closed T12146: Adding multiple Tags on a Diffusion Repository leads to a 404 as Invalid.

I can't reproduce this. It's possible that you actually experienced T11165 and misremembered exactly what you'd done, or performed one edit in a tab with the other tab open.

Jan 23 2017, 3:10 PM · Diffusion, Bug Report