Page MenuHomePhabricator
Create Task
Maniphest T6891

Daemon fails to parse SVN Folder with Whitespace
Open, Needs TriagePublic
Actions

Description

The daemon error log shows this:

STDERR
svn: Unable to parse URL '/svn/Web/!svn/bc/6680/Lernende/Webanwendung/VS/Webanwendung/Service References/'
at [/var/www/phabricator/libphutil/src/future/exec/ExecFuture.php:398]
#0 ExecFuture::resolvex() called at [/var/www/phabricator/phabricator/src/applications/repository/storage/PhabricatorRepository.php:253]
#1 PhabricatorRepository::execxRemoteCommand(--xml ls %C, '[..]/svn/Web/Lernende/Webanwendung/VS/Webanwendung@6680' '[..]/svn/Web/Lernende/Webanwendung/VS/Webanwendung/Firma@6680' [..]/svn/Web/Lernende/Webanwendung/VS/Webanwendung/App_Data@6679' '[..]/svn/Web/Lernende/Webanwendung/VS/Webanwendung/Administration@6680') called at [/var/www/phabricator/phabricator/src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php:592]
#2 PhabricatorRepositorySvnCommitChangeParserWorker::lookupPathFileTypes(Object PhabricatorRepository, Array of size 8 starting with: { /Lernende/Webanwendung/VS/Webanwendung/Administration/PersonenListe.aspx.cs => Array of size 2 starting with: { rawPath => /Lernende/Webanwendung/VS/Webanwendung/Administration/PersonenListe.aspx.cs } }) called at [/var/www/phabricator/phabricator/src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php:121]
#3 PhabricatorRepositorySvnCommitChangeParserWorker::parseCommitChanges(Object PhabricatorRepository, Object PhabricatorRepositoryCommit) called at [/var/www/phabricator/phabricator/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php:30]
#4 PhabricatorRepositoryCommitChangeParserWorker::parseCommit(Object PhabricatorRepository, Object PhabricatorRepositoryCommit) called at [/var/www/phabricator/phabricator/src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:44]
#5 PhabricatorRepositoryCommitParserWorker::doWork() called at [/var/www/phabricator/phabricator/src/infrastructure/daemon/workers/PhabricatorWorker.php:85]
#6 PhabricatorWorker::executeTask() called at [/var/www/phabricator/phabricator/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:123]
#7 PhabricatorWorkerActiveTask::executeTask() called at [/var/www/phabricator/phabricator/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:19]
#8 PhabricatorTaskmasterDaemon::run() called at [/var/www/phabricator/libphutil/src/daemon/PhutilDaemon.php:85]
#9 PhutilDaemon::execute() called at [/var/www/phabricator/libphutil/scripts/daemon/exec/exec_daemon.php:112]

Multiple reports at: https://github.com/phacility/phabricator/issues/583

Related Objects

Event Timeline

chad created this task.Jan 8 2015, 5:02 AM
chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added projects: Subversion, Diffusion.
chad updated the task description. (Show Details)
chad added a subscriber: chad.
marutiborker added a subscriber: marutiborker.EditedJan 8 2015, 6:36 AM

Hi, This is a svn client problem. Update the svn client to 1.8x and it should work fine.

I was having this issue on CENT Os with svn client 1.6.x , I upgraded to 1.8x and it has fixed the issue.

There was also an issue on the server side of svn but the latest svn and httpd ( apache ) packages have taken care of these problems.

chad added a subscriber: btrahan.Jan 8 2015, 4:15 PM

@btrahan, I think you added client detection of 'bad vcs clients', does that include server versions as well?

btrahan added a subscriber: epriestley.Jan 8 2015, 6:21 PM

There's no server detection. (Just to clarify as I get confused here -- the Phabricator server uses the SVN client to get information from some other SVN server.) Theoretically, we can get away without server detection persay since the SVN clients are supposed to clearly indicate that problem and Phabricator doesn't offer SVN-based hosting, so the admin must be doing that too...? (Hand-waving... hi!)

See T3046 for discussion and rPc9c4dc1d9b01db42431581828c063c0ff7eb6df6 for the code.

Anyway, we should probably do something here, but I'll defer to @epriestley as to how we should decide exactly what to do.

chad mentioned this in T6810: Inline comments is only partially working in an imported SVN repo.Jan 15 2015, 12:59 AM
epriestley moved this task from Backlog to Triage on the Diffusion board.Feb 2 2017, 4:07 PM
Phabricator · Built by Phacility