Mnkras (Michael Krasnow)
Bacon. That is all.

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jan 13 2012, 11:20 PM (271 w, 2 d)
Availability
Available

Recent Activity

Sat, Mar 25

Mnkras awarded T11443: T-shirts with new logo a Party Time token.
Sat, Mar 25, 9:30 PM · Public & Media Relations

Fri, Mar 24

Mnkras added a comment to T11443: T-shirts with new logo.

I want

Fri, Mar 24, 4:28 AM · Public & Media Relations

Mon, Mar 20

Mnkras created T12422: Unable to navigate to "All Daemons" on Mobile.
Mon, Mar 20, 6:56 PM · Daemons, Mobile, Bug Report

Thu, Mar 9

Mnkras added a comment to Q587: Is it possible to create a static URL to a file download? (Answer 528).

Use sub-modules and make the sub-module public? (or the parent public and the sub-module private)

Thu, Mar 9, 11:27 PM

Thu, Mar 2

Mnkras created T12340: Exclude refs/pull/* from being tracked in observed repo.
Thu, Mar 2, 1:59 AM · Diffusion, Feature Request

Sun, Feb 26

Mnkras asked a question: Q573: Exclude refs/pull/* from being tracked in observed repo

I couldn't figure out how to do this.

Sun, Feb 26, 6:07 PM
Mnkras added a comment to T12296: Improve Phacility repository import performance.

Cool, now I don't feel so bad since I know you only recently added the option 😄

Sun, Feb 26, 4:44 AM · Diffusion, Ops, Phacility
Mnkras added a comment to T12296: Improve Phacility repository import performance.

That works, Im curious when this changed, as I didn't need to filter since the last few weeks.

Sun, Feb 26, 4:37 AM · Diffusion, Ops, Phacility
Mnkras added a comment to T12296: Improve Phacility repository import performance.

The reason I think something isn't working correctly is in my dashboard, I list recent commits, and since I updated my install a few weeks ago my commit list looks like this a lot:

Sun, Feb 26, 4:29 AM · Diffusion, Ops, Phacility
Mnkras created T12317: PhabricatorTriggerDaemon shows as "Waiting" but there are no errors.
Sun, Feb 26, 3:35 AM · Bug Report
Mnkras added a comment to T12296: Improve Phacility repository import performance.

@epriestley all other commits that have the message "This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref." have imported, so I don't think the reachable code is working correctly, as until within the last few weeks I wasn't seeing these "This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref." commits showing up, but now I see them all the time.

Sun, Feb 26, 1:30 AM · Diffusion, Ops, Phacility

Feb 24 2017

Mnkras added a comment to T12296: Improve Phacility repository import performance.

@epriestley
https://test-3uoifmrptebb.phacility.com/R2:80233a27d7b72bb03710d358e12a531ce46808a9

Feb 24 2017, 6:25 PM · Diffusion, Ops, Phacility

Feb 23 2017

This is a test notification, sent at Wed, Feb 22, 11:44 PM.
Feb 23 2017, 4:44 AM

Feb 21 2017

Mnkras added a comment to T12296: Improve Phacility repository import performance.

@epriestley The import has finished, but some commits show as importing still?

Feb 21 2017, 8:33 PM · Diffusion, Ops, Phacility
Mnkras created T12303: Print View in Phriction shows Persistent Chat.
Feb 21 2017, 8:26 PM · Phriction, Bug Report

Feb 19 2017

Mnkras added a comment to T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.

We once rendered these renames like this:

new/path/to/file.c
  Moved From: old/path/to/file.c

Personally I like that, I think a compromise to make it easier to consume, would be to try and group the moves together and showing the relation, for example
now:

a ->
b ->
a <-
b <-

to

a ->
a <-
b ->
b <-
Feb 19 2017, 7:06 PM · Diffusion, Feature Request
Mnkras edited the description of T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.
Feb 19 2017, 6:37 PM · Diffusion, Feature Request
Mnkras created T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.
Feb 19 2017, 6:08 PM · Diffusion, Feature Request

Feb 6 2017

Mnkras added a project to T12204: Could not read from remote repository.: Phacility Support.
Feb 6 2017, 4:26 AM · Bug Report

Feb 3 2017

Mnkras added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

T9805?

Feb 3 2017, 3:34 AM · Bug Report

Jan 28 2017

Mnkras accepted D17260: Fix operator error in Pholio with PHP 7.1.
Jan 28 2017, 4:50 AM
Mnkras added a comment to T12166: EXCEPTION: (Error) [] operator not supported for strings.

That error makes sense,

Jan 28 2017, 4:42 AM · Bug Report, Pholio

Jan 26 2017

Mnkras added a comment to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000.

@epriestley you don't want to know what schools teach/accept now-adays... is very scary.

Jan 26 2017, 1:59 AM · Differential, Bug Report

Jan 23 2017

Mnkras renamed T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file from ""View Raw File" in Diffusion no longer takes you to the raw output of a the file" to ""View Raw File" in Diffusion no longer takes you to the raw output of the file".
Jan 23 2017, 5:11 PM · Diffusion, Bug Report
Mnkras created T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file.
Jan 23 2017, 5:11 PM · Diffusion, Bug Report

Jan 13 2017

Mnkras abandoned D14566: Ignore caching extensions that are not available on PHP7.
Jan 13 2017, 12:41 AM

Jan 8 2017

Mnkras created T12080: Clicking "Manage Password" next to repo URI does not change page.
Jan 8 2017, 5:30 AM · Diffusion, Quicksand, Bug Report
Mnkras added a comment to T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted.

I expect it to work, because it looks like it is supposed to:

Jan 8 2017, 12:58 AM · Public & Media Relations, Bug Report
Mnkras created T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted.
Jan 8 2017, 12:36 AM · Public & Media Relations, Bug Report
Mnkras created T12078: Toolbar shows I have notifications when I have none..
Jan 8 2017, 12:33 AM · Notifications, Bug Report

Dec 15 2016

J5lx awarded T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands a Heartbreak token.
Dec 15 2016, 7:11 PM · Daemons, Bug Report

Dec 9 2016

rafaelrabeloit awarded T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands a Heartbreak token.
Dec 9 2016, 3:52 PM · Daemons, Bug Report

Nov 3 2016

Mnkras added a comment to T11815: Rotate *.phacility.com SSL certificate.

Nov 3 2016, 8:23 PM · Phacility, Ops

Jul 5 2016

Mnkras added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Of course! Thanks for poking around!

Jul 5 2016, 5:55 AM · Daemons, Bug Report

Jul 4 2016

Mnkras added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Im really not sure, when I run restart this is what my daemon page looks like:

Jul 4 2016, 10:48 PM · Daemons, Bug Report
Mnkras edited the description of T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.
Jul 4 2016, 8:33 PM · Daemons, Bug Report
Mnkras edited the description of T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.
Jul 4 2016, 8:27 PM · Daemons, Bug Report
Mnkras created T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.
Jul 4 2016, 8:27 PM · Daemons, Bug Report

Jun 17 2016

Mnkras added a comment to T11166: When an install has no footer, Maniphest task previews have no bottom margin.

T10433?

Jun 17 2016, 7:47 PM · PHUI

May 7 2016

Mnkras abandoned D14344: Re-order remarkup rule blocks to pass tests on PHP7.

T10929

May 7 2016, 4:39 PM

Apr 19 2016

Mnkras added a comment to D15760: Add a user field into aphlict configuration.

idx is https://secure.phabricator.com/diffusion/PHU/browse/master/src/utils/utils.php$36

Apr 19 2016, 6:30 PM

Apr 16 2016

Mnkras added a comment to T10823: Aphlict admin server doesn't connect when SSL cert and key are supplied.

Yea, so I think the path forward is to check the version of WS and to add some docs about it in the aphlict changes, and just the general updating guide.

Apr 16 2016, 3:21 AM · Aphlict, Bug Report

Apr 15 2016

Mnkras created T10823: Aphlict admin server doesn't connect when SSL cert and key are supplied.
Apr 15 2016, 10:59 PM · Aphlict, Bug Report
Mnkras accepted D15729: Make `bin/aphlict stop` read new config properly.

Fixes the issue on my end! :D

Apr 15 2016, 10:14 PM

Apr 12 2016

Mnkras added a comment to Q361: Git http operations fail with username in url (Answer 357).

Yea, I definitely would not recommend that,
then again using http instead of https isn't great either (its sent in plaintext anyway, regardless if you include it in the url or not)

Apr 12 2016, 11:34 PM
Mnkras added a comment to T10787: Daemons keep crashing due to Phortune.

I was playing with it and made a "Give me your money for free" Fund and now... I regret that...

Apr 12 2016, 11:11 PM · Restricted Project, Bug Report
Mnkras added a comment to Q357: Diffusion - Create New Credential .

T10772

Apr 12 2016, 11:08 PM · Passphrase
Mnkras added Q361: Git http operations fail with username in url (Answer 357).

Can you try:
http://brandon:<password here>@10.21.7.10/diffusion/23/tct.git/

Apr 12 2016, 11:06 PM
Mnkras edited the description of T10787: Daemons keep crashing due to Phortune.
Apr 12 2016, 11:01 PM · Restricted Project, Bug Report
Mnkras created T10787: Daemons keep crashing due to Phortune.
Apr 12 2016, 11:00 PM · Restricted Project, Bug Report
Mnkras added a comment to T10782: Badge Awarder Info shows as a Unknown Object on the back of badges..

We should probably substitute in "Unknown Ghost" then.

Apr 12 2016, 12:44 AM · Badges, Bug Report
Mnkras created T10782: Badge Awarder Info shows as a Unknown Object on the back of badges..
Apr 12 2016, 12:42 AM · Badges, Bug Report
Mnkras added a comment to rP219357aa9fa3: Adding awarder info to badge cards displayed on user profile pages.

Fair enough, I will do that now.

Apr 12 2016, 12:38 AM
Mnkras created T10781: Conpherence new links are missing styles.
Apr 12 2016, 12:31 AM · Conpherence, Bug Report
Mnkras raised a concern with rP219357aa9fa3: Adding awarder info to badge cards displayed on user profile pages.

It seems this no longer is working correctly:

Apr 12 2016, 12:25 AM
Mnkras created T10780: Attempting to Edit a room from the Conpherence homepage doesn't work..
Apr 12 2016, 12:22 AM · Conpherence, Bug Report

Apr 8 2016

Mnkras awarded T10745: Emails are sent out about restricted changes a Like token.
Apr 8 2016, 3:01 AM · Restricted Project, Bug Report

Apr 5 2016

Mnkras created T10723: Paypal Phortune Provider always uses sandbox regardless of provider setting.
Apr 5 2016, 3:26 AM · Restricted Project, Bug Report

Mar 18 2016

Mnkras added a comment to T10612: Editing a panel causes it to duplicate in dashboard.

I had this same issue, I had to dig into the db to remove the duplicate phids

Mar 18 2016, 1:54 AM · Dashboards (v2), Bug Report

Mar 7 2016

Mnkras added a comment to T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion..

Ah, makes sense.

Mar 7 2016, 12:59 AM · Diffusion, Differential, Bug Report
Mnkras created T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion..
Mar 7 2016, 12:52 AM · Diffusion, Differential, Bug Report

Mar 1 2016

Mnkras archived P1952 Spam.
Mar 1 2016, 5:41 PM
Mnkras updated the title for P1952 Spam from Norton Phone number ((((@@@@1-844-655-0455@@@@)))Norton antivirus number to Spam.
Mar 1 2016, 5:40 PM

Feb 24 2016

Mnkras created T10433: Repo in Diffusion has no padding after Branches box if footer is not configured.
Feb 24 2016, 12:26 AM · Diffusion, Bug Report

Feb 23 2016

Mnkras archived P1946 .json.
Feb 23 2016, 4:26 AM
chad awarded P1946 .json a Dislike token.
Feb 23 2016, 4:21 AM
Mnkras created P1946 .json.
Feb 23 2016, 3:45 AM
Mnkras added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

I just ran into a fun issue that @avivey helped me figure out,

Feb 23 2016, 3:32 AM · Dashboards (v2)

Dec 22 2015

Mnkras changed the name of U4 Waffles from to Waffles.
Dec 22 2015, 4:22 PM

Dec 9 2015

Mnkras added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

I can't seem to repro it either, might have been the issue with the edit route you fixed?

Dec 9 2015, 3:20 PM · Bug Report
Mnkras added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

whoops, yes

Dec 9 2015, 3:10 PM · Bug Report
Mnkras added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

Let me clarify,

Dec 9 2015, 3:09 PM · Bug Report
Mnkras updated subscribers of T9805: XHProf will not build on PHP7.
Dec 9 2015, 4:20 AM · XHProf
Mnkras updated subscribers of T9805: XHProf will not build on PHP7.
Dec 9 2015, 4:20 AM · XHProf
Mnkras added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

I can't edit my own task... it 404's

Dec 9 2015, 4:19 AM · Bug Report
Mnkras changed the visibility for F1018337: maniphest-disabled.mov.
Dec 9 2015, 4:18 AM
Mnkras created T9938: Maniphest Actions are improperly disabled/can lead to 404.
Dec 9 2015, 4:18 AM · Bug Report

Dec 5 2015

Mnkras added a comment to T9897: Unbeta Feedback on Phame.

That is hypothetical, but for example, lets say Evan publishes a post with the following:
/blog/750/development_notes_2015_week_494949494949494/
but really meant for the slug to be
/blog/750/development_notes_2015_week_49/

Dec 5 2015, 5:55 PM · Phame
Mnkras added a comment to T9897: Unbeta Feedback on Phame.

The easiest thing I can think of is simple typos/ bad c&p job

Dec 5 2015, 5:43 PM · Phame
Mnkras added a comment to T9897: Unbeta Feedback on Phame.

I have a concern about the /blog/<postid>/ignored_post_title/ approach, if the blog is indexed by Google, /blog/<postid>/ignored_post_title/ and /blog/<postid>/derpa/ will have the exact same content which Google penalizes.

Dec 5 2015, 5:10 PM · Phame

Nov 30 2015

Mnkras added a comment to D14566: Ignore caching extensions that are not available on PHP7.

When I have some time Ill implement a new DataCacheSpec, I chatted in ##php and asked about the OPCache, its enabled by default (like in PHP 5.5+) and there is currently no other available caching extensions.

Nov 30 2015, 4:09 PM

Nov 26 2015

Mnkras added a comment to T9848: CustomLinter Fails.

You have the path to the library directory twice, print out the variables
that you use in the md5 function.

Nov 26 2015, 3:49 PM · Lint

Nov 25 2015

Mnkras added a comment to T9848: CustomLinter Fails.

If you look at the error message and the path you can see what the issue is:

Nov 25 2015, 4:00 PM · Lint

Nov 24 2015

Mnkras added a comment to D14566: Ignore caching extensions that are not available on PHP7.

Drupal ran into a similar issue with APC not existing when they try to run APC unit tests.
https://www.drupal.org/node/2554065

Nov 24 2015, 3:59 AM
Mnkras updated the diff for D14566: Ignore caching extensions that are not available on PHP7.

Re-run arc unit

Nov 24 2015, 3:56 AM
Mnkras retitled D14566: Ignore caching extensions that are not available on PHP7 from to Ignore caching extensions that are not available on PHP7.
Nov 24 2015, 3:54 AM

Nov 23 2015

Mnkras created T9836: Feed doesn't correctly show Restricted Objects.
Nov 23 2015, 8:51 PM · Feed
Mnkras added a comment to rPc034752578cf: Support comments as an EditEngine field.

I wonder if instead of "Comment", "Justification" might have more use in certain cases? (why not both! "Comment/Justification")

Nov 23 2015, 12:40 AM

Nov 19 2015

Mnkras added a comment to T9805: XHProf will not build on PHP7.

I don't think that is going to work here are some things I pulled from the extension migration page (unless we ifdef large blocks of code):

zval

  • PHPNG doesn't require any involvement of pointers to pointers to zval. Most occurrences of zval** variables and parameters have to be changed into zval*. The corresponding Z_*_PP() macros that work with such variables should be changed into Z_*_P().
  • In many places PHPNG work with zval directly (eliminating need for allocation and deallocation). In these cases corresponding zval* variable should be converted into plain zval, macros that use this variable from Z_*P() into Z_*() and corresponding creation macros from ZVAL_*(var, …) into ZVAL_*(&var, …). Be always careful about passing addresses of zval and & operator. PHPNG almost never require passing address of zval*. In some places & operator should be removed.
  • zval allocation macros ALLOC_ZVAL, ALLOC_INIT_ZVAL, MAKE_STD_ZVAL are removed. In most cases their usage indicate that zval* need to be changed into plain zval. Macro INIT_PZVAL is removed as well and its usages in most cases should be just removed.
Nov 19 2015, 2:39 AM · XHProf

Nov 18 2015

Mnkras updated subscribers of T9805: XHProf will not build on PHP7.

@epriestley, due to the fact that the Zend APIs for PHP7+ are different than those in PHP5* how should changes to XHProf be submitted so we don't break stuff?

Nov 18 2015, 3:29 PM · XHProf

Nov 17 2015

Mnkras added a parent task for T9805: XHProf will not build on PHP7: T9640: Make Phabricator compatible with PHP7.
Nov 17 2015, 4:49 AM · XHProf
Mnkras added a subtask for T9640: Make Phabricator compatible with PHP7: T9805: XHProf will not build on PHP7.
Nov 17 2015, 4:49 AM · Prioritized, Restricted Project, Infrastructure
Mnkras created T9805: XHProf will not build on PHP7.
Nov 17 2015, 4:37 AM · XHProf
Mnkras updated the title for P1891 xhprof php7 from untitled to xhprof php7.
Nov 17 2015, 4:37 AM

Nov 16 2015

Mnkras added a comment to T9770: It is possible to use the same 2FA token more than once.

I for-see what @revi stated above as a pretty plausible scenario, even the looking over someones shoulder is a plausible scenario.

Nov 16 2015, 4:50 AM · Security, Auth

Nov 13 2015

Mnkras added a comment to T9770: It is possible to use the same 2FA token more than once.

So I just did some googling and came across the RFC for MFA, and this is
taken from the RFC:

Nov 13 2015, 7:27 PM · Security, Auth
Mnkras added a comment to T9773: Unit tests are slow.

Yea, im getting the same results as chad, tested on php 5.6, and php7 is super fast.

Nov 13 2015, 3:31 AM · Infrastructure
Mnkras added a comment to T9770: It is possible to use the same 2FA token more than once.

I think this is more to conform with what everyone else does, I know Google and Apple don't let you re-use tokens even if they are still in the valid timeframe, not sure if there are specific reasons behind that besides the attack you came up with above.

Nov 13 2015, 3:29 AM · Security, Auth

Nov 9 2015

Mnkras created T9752: Arbitrary values allowed for repo PHID in when adding a path in owners.
Nov 9 2015, 11:58 PM · Owners
Mnkras closed T9750: Informasi as "Spite".
Nov 9 2015, 11:27 PM