Page MenuHomePhabricator

Long lines overflow in Diffusion browser
Closed, ResolvedPublic

Description

Possibly related to T11236?

Reproduction steps:

  • Make a commit with some arbitrarily-long (>225 characters or so) line of text without spaces.
  • Browse that file in Diffusion at /diffusion/REPO/browse/BRANCH/MYFILE.TXT

Expected result:

  • Long line wraps at some reasonable width

Observed result:

  • Long line does not wrap and the side column is hidden underneath the Diffusion source table:

Our version information:

Version information on Phacility test instance:

Event Timeline

In Paste (and I think Differential), we scroll lines instead of trying to wrap them:

In theory, it might be nice to unify the Diffusion file view code and the paste file view code. However, the Diffusion stuff at least is pretty complex/specialized so I'm not sure this is desirable in practice.

A sufficient near-term fix is probably sticking overflow-x: auto; into CSS somewhere.

(I think this only impacts Diffusion, not Differential.)

sorry that our DEEP NEURAL NETWORK TECHNOLOGY can not yet READ MINDS

I'm just going to rename Differential everywhere.

sorry that our DEEP NEURAL NETWORK TECHNOLOGY can not yet READ MINDS

https://archive.google.com/mentalplex/

epriestley edited projects, added Diffusion (v3); removed Diffusion.

I can't reproduce this, is there a specific browser/OS I should test? Also, feel free to upload a test file to rGITTEST

word-break: break-all; seems to be working fine.

I see, it must be a text file.