Page MenuHomePhabricator
Feed Advanced Search

Dec 14 2021

epriestley added a comment to T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way.

...possibly, but not conclusively, a result of an SSH version upgrade...

Dec 14 2021, 8:02 PM · Passphrase, Diffusion
epriestley triaged T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way as Wishlist priority.
Dec 14 2021, 5:58 PM · Passphrase, Diffusion

Sep 5 2021

cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

So that part is correct, but swapping the commit and branch was incidental, and I overlooked it because we usually get the same result: in common cases, this is moot because ancestors(<branch name>) is equivalent to ancestors(<heads of that branch>), and branch(<commit hash>) is equivalent to branch(<branch of that commit>). The latter is always equivalent; the former is equivalent when commit is the single head of branch, which it almost always is in regular use.

But this behavior (on this install) is unambiguously wrong:

Screen Shot 2021-09-04 at 5.28.41 PM.png (1×2 px, 407 KB)

...since b7be5c961297 (the parameter) is an ancestor of 162a9c1e8e44 (the first commit in the result set). I'll send you a diff.

Sep 5 2021, 1:21 AM · Diffusion
epriestley added a revision to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations: D21722: Correct a parameter order swap in "diffusion.historyquery" for Mercurial.
Sep 5 2021, 12:47 AM · Diffusion
epriestley added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

Good catch!

Sep 5 2021, 12:30 AM · Diffusion

Sep 4 2021

cspeckmim closed T13634: Support marking commits as UNREACHABLE in Mercurial as Resolved.
Sep 4 2021, 11:55 PM · Diffusion
cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

One tangential thing I noticed from the error messages in these cases, in DiffusionHistoryQueryConduitAPIMethod the getMercurialResult() function executes this hg command

$path_args = array();
if (strlen($path)) {
  $path_args[] = $path;
  $revset_arg = hgsprintf(
    'reverse(ancestors(%s))',
    $commit_hash);
} else {
  $revset_arg = hgsprintf(
    'reverse(ancestors(%s)) and branch(%s)',
    $drequest->getBranch(),
    $commit_hash);
}
Sep 4 2021, 11:03 PM · Diffusion
cspeckmim closed T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations as Resolved.
Sep 4 2021, 10:51 PM · Diffusion
cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

With just the updates to the future handling this is now the landing page I see with missing commits:

Screen Shot 2021-09-04 at 6.33.54 PM.png (948×3 px, 180 KB)

Sep 4 2021, 10:50 PM · Diffusion
cspeckmim renamed T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations from Improve error-handling behavior of Diffusion repository landing page to Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Sep 4 2021, 9:29 PM · Diffusion
epriestley added a revision to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations: D21721: Use "MethodCallFuture" to move Diffusion Conduit exceptions to resolution time.
Sep 4 2021, 9:13 PM · Diffusion
epriestley added a revision to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations: D21720: Provide "MethodCallFuture" to fix exception semantics in mixed-future contexts.
Sep 4 2021, 8:40 PM · Diffusion
epriestley added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

Ah, that's helpful. I found a repro, it's specific to the behavior of the ImmediateFuture pathway for non-clustered resolution of Conduit "calls". This should force it from any configuration/state, I think:

Sep 4 2021, 7:46 PM · Diffusion
cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

I'm able to reproduce this but I'll investigate further

Sep 4 2021, 7:40 PM · Diffusion
cspeckmim added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

I think I did conflate this partially - namely that this isn't directly caused by the issue discussed in T13365. Where this issue came up for me is while testing out D21715, I removed the head commit from the on-disk repo which caused the landing page to not render properly:

Sep 4 2021, 7:20 PM · Diffusion
epriestley added a comment to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.

I'll have some more detail in D21717 in a minute, but I can't immediately reproduce this, I think? If I intentionally break diffusion.historyquery like this:

Sep 4 2021, 7:06 PM · Diffusion
cspeckmim added a revision to T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations: D21717: Remove history query from DiffusionRepositoryController as it is unused.
Sep 4 2021, 6:07 AM · Diffusion
cspeckmim updated the task description for T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Sep 4 2021, 5:49 AM · Diffusion

Sep 3 2021

cspeckmim claimed T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Sep 3 2021, 10:26 PM · Diffusion
cspeckmim updated the task description for T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Sep 3 2021, 10:26 PM · Diffusion
cspeckmim renamed T13365: Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit" from Conduit API method "diffusion.historyquery" fatals if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit".
Sep 3 2021, 10:24 PM · Diffusion
cspeckmim renamed T13365: Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit" from Conduit API method "diffusion.historyquery" fatals under Git if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals if passed a bad "commit".
Sep 3 2021, 10:24 PM · Diffusion
cspeckmim triaged T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations as Low priority.
Sep 3 2021, 10:23 PM · Diffusion
cspeckmim added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

In Mercurial, I'm not exactly sure how wide this window is. Since you normally can't strip commits in the remote by pushing (AFAIK?)

This is true, though it does change a bit if we enable evolve server-side. Then when commits/branches are pruned when pushing/pulling those obsolete markers will also be transferred, allowing similar disappearing commits (retrievable via —hidden). However I believe by default mercurial does not allow pruning public changesets (would require forcibly changing phases on client/server, or running a server/branch in non-publishing mode). Supporting evolve/topics server-side is probably large enough that it would be its own big project. So I think this assumption holds up well.

Sep 3 2021, 3:57 AM · Diffusion
epriestley added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

(D21715 is still a draft, but I left a couple of more specific comments there.)

Sep 3 2021, 3:39 AM · Diffusion
epriestley added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

Does this refer to when multiple dependent commits are pushed and then stripped from the on-disk state?

Sep 3 2021, 3:35 AM · Diffusion
cspeckmim added a comment to T13634: Support marking commits as UNREACHABLE in Mercurial.

Another caveat here is that if you destroy commits directly in Phabricator's working copy in certain states, it's possible it won't be able to trace ancestry to find all the commits you destroyed in order to mark them unreachable. However, this window is narrow. For Git, you can bin/repository mark-reachable to rebuild reachability if you know you've done a bunch of dangerous mutations to the on-disk state.

Sep 3 2021, 3:02 AM · Diffusion
cspeckmim updated the task description for T13634: Support marking commits as UNREACHABLE in Mercurial.
Sep 3 2021, 2:58 AM · Diffusion
cspeckmim added a revision to T13634: Support marking commits as UNREACHABLE in Mercurial: D21715: Add support to marking commits as UNREACHABLE for Mercurial.
Sep 3 2021, 2:55 AM · Diffusion

Jun 1 2021

epriestley added a revision to T13614: Provide a write-free, non-locking maintenance window for repositories: D21671: Provide an ad-hoc maintenance lock for clustered repositories.
Jun 1 2021, 3:17 PM · Clusters, Diffusion
epriestley added a comment to T13614: Provide a write-free, non-locking maintenance window for repositories.

Since observed repositories version differently today, this strategy won't work -- but I can't come up with any valid reason to ever put a repository into a "write maintenance" mode anyway. I do imagine making observed repositories "replay" fetches into the push log (as though they were pushes) in the future, but that still won't make "write maintenance" on an observed repository meaningful, so it seems fine to just prevent putting non-hosted repositories into this mode.

Jun 1 2021, 1:58 PM · Clusters, Diffusion
epriestley added a revision to T13614: Provide a write-free, non-locking maintenance window for repositories: D21670: Allow maintenance scripts to write synthetic events to the push log that act as repository updates.
Jun 1 2021, 1:50 PM · Clusters, Diffusion
epriestley added a revision to T13614: Provide a write-free, non-locking maintenance window for repositories: D21669: Improve display behavior for write locks held by omnipotent users.
Jun 1 2021, 1:13 PM · Clusters, Diffusion
epriestley added a comment to T13614: Provide a write-free, non-locking maintenance window for repositories.

A minor issue on the way to this is that calling synchronizeWorkingCopyBeforeWrite() with an omnipotent viewer will write to the WorkingCopyVersion table with a null userPHID, which shows as "Unknown Object" in the UI.

Jun 1 2021, 1:08 PM · Clusters, Diffusion
epriestley added a comment to T13614: Provide a write-free, non-locking maintenance window for repositories.

A useful maintenance operation for staging area repositories is to remove out-of-date staging refs: old diffs which have already landed. This is of some particular importance for large installs, since Git has a significant per-ref overhead for many operations until protocol v2: by the time a repository has ~50K refs, interacting with it in basically any way has become slow and cumbersome.

Jun 1 2021, 12:41 PM · Clusters, Diffusion

Apr 13 2021

davidgiga1993 added a comment to T7000: 404 when accessing repo via http.

This issue is still occurring.. the root cause is related to phabricator being set to allow-public. My fix still works and it would be nice if anyone here would support me bringing this upstream.

Apr 13 2021, 6:42 AM · Diffusion

Mar 28 2021

epriestley added a revision to T13647: Reduce repository update cost for repositories with large numbers of refs: D21658: Skip "git for-each-ref" when identifying deleted commits.
Mar 28 2021, 5:58 PM · Diffusion
epriestley added a comment to T13647: Reduce repository update cost for repositories with large numbers of refs.

One call to for-each-ref comes from resolving a list of commit hashes, to test if they still exist. This is accomplished with DiffusionLowLevelResolveRefsQuery, which calls git for-each-ref first and falls back to git cat-file --batch-check.

Mar 28 2021, 5:44 PM · Diffusion
epriestley added a comment to T13647: Reduce repository update cost for repositories with large numbers of refs.

Has this repository changed?

Mar 28 2021, 5:25 PM · Diffusion

Mar 26 2021

epriestley triaged T13647: Reduce repository update cost for repositories with large numbers of refs as Normal priority.
Mar 26 2021, 11:09 PM · Diffusion

Mar 17 2021

epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

A general concern with "batch processing" is that it's quite bad if one commit failing to import can stall the entire repository forever.

Mar 17 2021, 11:18 PM · Diffusion, Differential
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

See also T13552, which modifies the above discussion. The "Update" steps now happen after the "Publish" step.

Mar 17 2021, 11:12 PM · Diffusion, Differential
epriestley closed T13513: Make schema changes to inlines to prepare for new inline features as Resolved.

When you are viewing a document with engine X, and comments originally made with engine Y are present, this should be indicated ("This comment was made while looking at this change as a Q document."). They should probably also be moved to the top/bottom of the file, at least by default, since "Jupyter line number 9 = raw source line number 9" is an exceptionally bad and confusing guess at how to map line numbers.

Mar 17 2021, 10:59 PM · Inline Comments, Diffusion, Differential
epriestley triaged T13645: In Diffusion "Tags" view, improve behavior for tags that point at tag objects as Low priority.
Mar 17 2021, 10:45 PM · Diffusion

Mar 15 2021

epriestley moved T13105: Plans: Rich presentation and diff rendering pipelines for various file types from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Plans, Files, Differential, Diffusion
epriestley moved T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits" from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Diffusion, Differential
epriestley moved T13513: Make schema changes to inlines to prepare for new inline features from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Inline Comments, Diffusion, Differential

Mar 12 2021

epriestley closed T13631: Support an "auditors" attachment for "diffusion.commit.search" as Resolved.

For now, I fixed the explicit misinformation in audit.can-author-close-audit, at least.

Mar 12 2021, 5:27 PM · Diffusion
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21610: Clarify the behavior of "audit.can-author-close-audit".
Mar 12 2021, 5:13 PM · Diffusion

Mar 11 2021

epriestley triaged T13634: Support marking commits as UNREACHABLE in Mercurial as Low priority.
Mar 11 2021, 6:15 PM · Diffusion

Mar 10 2021

epriestley closed T13625: Daemons may make commit-related API calls as users without privileges as Resolved.

Although I didn't look particularly hard, I can't immediately find any more evidence that this is occurring in production.

Mar 10 2021, 6:26 PM · Diffusion, Daemons
epriestley added a comment to T13631: Support an "auditors" attachment for "diffusion.commit.search".

One remaining artifact here is this configuration option:

Mar 10 2021, 6:23 PM · Diffusion
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21601: Allow "transaction.search" to be called on an object type.
Mar 10 2021, 6:13 PM · Diffusion
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21600: Give audit statuses API constants that match their UI strings.
Mar 10 2021, 6:07 PM · Diffusion
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21599: Modernize and clean up "PhabricatorAuditStatusConstants".
Mar 10 2021, 5:15 PM · Diffusion
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21598: Remove very old Audit status constants and AuditRequest data.
Mar 10 2021, 12:01 AM · Diffusion

Mar 9 2021

epriestley added a comment to T13631: Support an "auditors" attachment for "diffusion.commit.search".

Long ago, we used to write a <package, commit> audit relationship with "AUDIT_NOT_REQUIRED", meaning "This commit affects the package, but package owners don't need to audit it.".

Mar 9 2021, 11:50 PM · Diffusion
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21597: Add a very basic "auditors" attachment to "differential.commit.search".
Mar 9 2021, 11:03 PM · Diffusion
epriestley added a comment to T13631: Support an "auditors" attachment for "diffusion.commit.search".

PhabricatorAuditStatusConstants appears to have a set of unused constants:

Mar 9 2021, 10:37 PM · Diffusion
epriestley triaged T13631: Support an "auditors" attachment for "diffusion.commit.search" as Low priority.
Mar 9 2021, 10:27 PM · Diffusion

Mar 4 2021

epriestley added a comment to T13624: Provide an error log for `sshd` subprocesses.

Evidence increasingly suggests that the root problem here was GET_LOCK() issue in T13627, not an error in an sshd subprocess context.

Mar 4 2021, 12:08 AM · Diffusion

Mar 2 2021

epriestley updated the task description for T13625: Daemons may make commit-related API calls as users without privileges.
Mar 2 2021, 11:29 PM · Diffusion, Daemons
epriestley added a comment to T13624: Provide an error log for `sshd` subprocesses.

In general, Phacility production hosts may interact with logs as several different users:

Mar 2 2021, 5:40 PM · Diffusion
epriestley reopened T13624: Provide an error log for `sshd` subprocesses as "Open".

This ran into some filesystem permissions issues and needs followup.

Mar 2 2021, 5:20 PM · Diffusion

Mar 1 2021

epriestley added a comment to T13625: Daemons may make commit-related API calls as users without privileges.

When we are importing a commit, we often don't have any legitimate user to act as: the commit may come from an observed repository (so we never authenticated a pusher), and the "Author" and "Committer" strings are arbitrary and untrusted in Git and Mercurial.

Mar 1 2021, 7:09 PM · Diffusion, Daemons
epriestley added a revision to T13625: Daemons may make commit-related API calls as users without privileges: D21582: When updating revisions in responset to commits, use the omnipotent viewer to pull diffs.
Mar 1 2021, 7:00 PM · Diffusion, Daemons
epriestley added a comment to T13625: Daemons may make commit-related API calls as users without privileges.

All three of these are almost certainly diffusion.rawdiffquery, I think the first one just predated D21463 reaching production so it didn't show the method.

Mar 1 2021, 6:15 PM · Diffusion, Daemons
epriestley closed T13624: Provide an error log for `sshd` subprocesses as Resolved.

This deployed, and appears resolved.

Mar 1 2021, 6:12 PM · Diffusion

Feb 27 2021

epriestley updated the task description for T13625: Daemons may make commit-related API calls as users without privileges.
Feb 27 2021, 7:41 PM · Diffusion, Daemons
epriestley triaged T13625: Daemons may make commit-related API calls as users without privileges as Normal priority.
Feb 27 2021, 7:38 PM · Diffusion, Daemons

Feb 26 2021

epriestley added a revision to T13624: Provide an error log for `sshd` subprocesses: Restricted Differential Revision.
Feb 26 2021, 10:49 PM · Diffusion
epriestley added a revision to T13624: Provide an error log for `sshd` subprocesses: Restricted Differential Revision.
Feb 26 2021, 10:48 PM · Diffusion
epriestley added a revision to T13624: Provide an error log for `sshd` subprocesses: D21579: Support an SSH error log.
Feb 26 2021, 10:46 PM · Diffusion
epriestley added a revision to T13624: Provide an error log for `sshd` subprocesses: D21578: Add a simple primitive for managing PHP runtime error logs.
Feb 26 2021, 10:42 PM · Diffusion
epriestley triaged T13624: Provide an error log for `sshd` subprocesses as Normal priority.
Feb 26 2021, 7:38 PM · Diffusion

Feb 25 2021

epriestley closed T13611: In clusters, "writable" property on bindings may not actually prevent writes as Resolved.
  • This was originally implemented in D19357.
  • This was broken by a refactoring change in D20775.
  • I made problem observable in D21575 fixed it in D21576.
Feb 25 2021, 8:31 PM · Clusters, Diffusion
epriestley added a revision to T13611: In clusters, "writable" property on bindings may not actually prevent writes: D21576: Correct behavior of "writable" Almanac service binding for repository services.
Feb 25 2021, 8:15 PM · Clusters, Diffusion
epriestley added a revision to T13611: In clusters, "writable" property on bindings may not actually prevent writes: D21575: Add an internal service ref panel to repository "Storage" information.
Feb 25 2021, 8:06 PM · Clusters, Diffusion
epriestley added a comment to T13620: Improve access to commit messages from email and timeline contexts.

This is a brute force approach to support "context blocks" without taking any steps backwards (i.e., it supports older transactions and newer, modular transactions), but it feels like this is a lot of steps sideways and this change would be far better if it took a nuanced approach through T12921.

Feb 25 2021, 7:32 PM · Hovercards, Diffusion
epriestley added a comment to T13620: Improve access to commit messages from email and timeline contexts.
  • T12921 is adjacent to mail rendering.
  • T13439 mentioned the hovercard summary text.
Feb 25 2021, 7:11 PM · Hovercards, Diffusion
epriestley added a comment to T13620: Improve access to commit messages from email and timeline contexts.

D21574 implements the hovercard and summary length changes.

Feb 25 2021, 7:01 PM · Hovercards, Diffusion
epriestley added a revision to T13620: Improve access to commit messages from email and timeline contexts: D21574: Provide hovercards for generic edge stories, and include more message information in commit hovercards.
Feb 25 2021, 6:28 PM · Hovercards, Diffusion
epriestley triaged T13620: Improve access to commit messages from email and timeline contexts as Low priority.
Feb 25 2021, 6:18 PM · Hovercards, Diffusion

Feb 24 2021

epriestley updated the task description for T13614: Provide a write-free, non-locking maintenance window for repositories.
Feb 24 2021, 10:10 PM · Clusters, Diffusion

Feb 19 2021

epriestley triaged T13614: Provide a write-free, non-locking maintenance window for repositories as Normal priority.
Feb 19 2021, 4:27 PM · Clusters, Diffusion

Feb 18 2021

epriestley triaged T13611: In clusters, "writable" property on bindings may not actually prevent writes as Low priority.
Feb 18 2021, 11:54 PM · Clusters, Diffusion

Feb 15 2021

epriestley triaged T13606: In Diffusion UI, satisfy "Refs" query from the database, not the API as Normal priority.
Feb 15 2021, 8:17 PM · Diffusion
epriestley added a comment to T13125: Plans: Code coverage reporting.

See PHI1997, which discusses things from the perspective of reporting coverage from a build system.

Feb 15 2021, 7:44 PM · Diffusion, Plans

Feb 4 2021

epriestley closed T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories as Resolved.

This more-or-less worked as desired. Some minor issues:

Feb 4 2021, 9:33 PM · Diffusion, Phacility
epriestley added a revision to T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories: Restricted Differential Revision.
Feb 4 2021, 6:29 PM · Diffusion, Phacility
epriestley added a revision to T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories: D21544: Add an "--ignore-locality" flag to "bin/repository pull".
Feb 4 2021, 6:26 PM · Diffusion, Phacility
epriestley triaged T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories as Normal priority.
Feb 4 2021, 6:26 PM · Diffusion, Phacility

Feb 2 2021

epriestley closed T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT" as Resolved.

Update the daemon UI to break tasks down by object/container.

Feb 2 2021, 10:37 PM · Daemons, Diffusion
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21536: Add basic documentation for using "bin/worker" to manage imports of large repositories.
Feb 2 2021, 9:38 PM · Daemons, Diffusion
epriestley closed T13590: Large HTTP repository pushes may leave clustered repository write lock held as Resolved.

The affected user in PHI1980 reported that this appeared to be effective in resolving the issue.

Feb 2 2021, 9:37 PM · Diffusion
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21535: Add "bin/worker delay" and "bin/worker priority" utilities for managing task queues.
Feb 2 2021, 12:28 AM · Daemons, Diffusion

Feb 1 2021

epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21534: Add more selectors to existing "bin/worker" commands.
Feb 1 2021, 9:53 PM · Daemons, Diffusion
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21533: Internally, align commit processing tasks around PHIDs, not IDs.
Feb 1 2021, 8:07 PM · Daemons, Diffusion
epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21532: Improve consistency in use of "via", "objectPHID", and "containerPHID" parameters in repository workers.
Feb 1 2021, 7:44 PM · Daemons, Diffusion

Jan 29 2021

epriestley added a revision to T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT": D21531: Add support for a "containerPHID" in the worker queue.
Jan 29 2021, 12:33 AM · Daemons, Diffusion