Page MenuHomePhabricator
Create Task
Maniphest T11843

Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
jcox
Nov 10 2016, 3:28 PM
Tags
Referenced Files
F1914077: 0477.wav
Nov 10 2016, 7:47 PM
F1913884: pasted_file
Nov 10 2016, 3:32 PM
F1913866: pasted_file
Nov 10 2016, 3:28 PM
Subscribers
chad
eadler
epriestley
hach-que
jcox
joshuaspence
thoughtpolice

Description

Repro Steps:

  1. Go to https://secure.phabricator.com/T4190
  2. Ctrl+F for D16597
  3. Click on the link to D16597
  4. Click on "show older changes"
  5. You'll be presented with the following:

pasted_file (319×897 px, 55 KB)

Text for searchability:

Argument 1 passed to DifferentialTransactionView::setLeftDiff() must be an instance of DifferentialDiff, null given, called in /core/lib/phabricator/src/applications/differential/storage/DifferentialRevision.php on line 627 and defined

Refreshing the page seems to fix the issue. It also doesn't happen if you go directly to https://secure.phabricator.com/D16597.

This seems similar to T6720.

Related Objects

Event Timeline

jcox created this task.Nov 10 2016, 3:28 PM
jcox added a comment.Nov 10 2016, 3:32 PM

The other errors that appear in DarkConsole:

pasted_file (276×920 px, 79 KB)

epriestley added a subscriber: epriestley.Nov 10 2016, 7:22 PM

Do you have the persistent chat pane open?

chad added a subscriber: chad.Nov 10 2016, 7:39 PM

Quicksand

jcox added a comment.Nov 10 2016, 7:41 PM

Yes I did have the persistent chat pane open. Also can't seem to repro without it.

epriestley added a project: Quicksand.Nov 10 2016, 7:41 PM

Welcome to the wonderful, spooky world of Quicksand.

jcox added a comment.Nov 10 2016, 7:43 PM

{auto-playing-audio WilhelmScream.mp3}

epriestley added a comment.Nov 10 2016, 7:47 PM
This comment was removed by chad.
epriestley mentioned this in T11845: Media with "autoplay" should possibly not autoplay in news feed.Nov 10 2016, 7:48 PM
joshuaspence added a subscriber: joshuaspence.Nov 11 2016, 12:16 PM
epriestley renamed this task from Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() to Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.Nov 11 2016, 9:43 PM
epriestley merged a task: T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".Feb 3 2017, 9:59 PM
epriestley added subscribers: thoughtpolice, eadler.
epriestley merged a task: T11639: InvalidArgumentException when clicking "Show Older Changes" on diff.Jul 27 2017, 4:53 PM
epriestley added a subscriber: hach-que.
Phabricator · Built by Phacility