Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled
Open, Needs TriagePublic

Description

Repro Steps:

  1. Go to https://secure.phabricator.com/T4190
  2. Ctrl+F for D16597
  3. Click on the link to D16597
  4. Click on "show older changes"
  5. You'll be presented with the following:


Text for searchability:

Argument 1 passed to DifferentialTransactionView::setLeftDiff() must be an instance of DifferentialDiff, null given, called in /core/lib/phabricator/src/applications/differential/storage/DifferentialRevision.php on line 627 and defined

Refreshing the page seems to fix the issue. It also doesn't happen if you go directly to https://secure.phabricator.com/D16597.

This seems similar to T6720.

jcox created this task.Nov 10 2016, 3:28 PM
jcox added a comment.Nov 10 2016, 3:32 PM

The other errors that appear in DarkConsole:

Do you have the persistent chat pane open?

jcox added a comment.Nov 10 2016, 7:41 PM

Yes I did have the persistent chat pane open. Also can't seem to repro without it.

Welcome to the wonderful, spooky world of Quicksand.

jcox added a comment.Nov 10 2016, 7:43 PM

{auto-playing-audio WilhelmScream.mp3}

This comment was removed by chad.
epriestley changed the title from "Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff()" to "Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled".Nov 11 2016, 9:43 PM