Page MenuHomePhabricator

Inline Comments for Paste / Diffusion Files
Open, WishlistPublic

Description

Would it be possible for Paste to reuse some of the Differential inline commenting coolness?

Related Objects

Mocks
Restricted Pholio Mock

Event Timeline

svemir triaged this task as Wishlist priority.
svemir added a project: Paste.
svemir added a subscriber: svemir.

There's some discussion of why this is tricky in T363, which proposes something similar for Diffusion -- basically, it's not particularly difficult to implement technically but getting the UI right creates some questions about how the comments actually work, when notifications get sent, who they get sent to, whether they work like Differential, how we reconcile any differences so the user isn't confused, etc. Might happen sooner or later but I haven't yet figured out good answers for this stuff. At the very least, T431 should probably happen first.

Technically there's no reason we couldn't have subscribers and comments on Paste in general, it's just not clear how much value this would provide. We can't trivially reuse other parts of the system since the UI is different (one block of text, not a diff).

epriestley renamed this task from Paste comments to Inline Comments for Paste / Diffusion Files.Apr 9 2012, 7:55 PM

T1093 is a similar request applied to the file views in Diffusion (both are 1-up views with no meaningful workflow on top of them).

musikee claimed this task.
epriestley removed musikee as the assignee of this task.
epriestley added a subscriber: musikee.

T3650 helped clear the path a little bit for this - we have subscribers, comments, and mail integration, just no inline stuff.

I realized now I made a mistake in that this is a block of text (no line numbers) so schema should likely be updated from lineNumber and lineLength to charPosStart and charPosEnd or something. Small mistake as far as mistakes go since these columns won't be used until this Task is tackled. :)

Display is also likely to be challenging since the text that was selected for comment may need to flow as the user changes the size of the browser.

Aren't pastes line-oriented? I think the schema is correct as-is...

{F53062}

We do have the "non-line block of text" issue in some other apps (phriction, legalpad).

chad changed the visibility from "All Users" to "Public (No Login Required)".Aug 2 2015, 4:05 PM
chad removed a subscriber: musikee.
eadler added a project: Restricted Project.Apr 9 2016, 6:01 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 17 2016, 6:25 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 6 2016, 4:18 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 8:59 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.