Page MenuHomePhabricator
Feed Advanced Search

Jun 8 2015

btrahan accepted D13184: Migrate Herald conditions and actions after mailing list changes.
Jun 8 2015, 5:03 PM
btrahan accepted D13183: Use standard subscribers effects in Herald Adapter for revisions.

awesometown

Jun 8 2015, 5:00 PM
btrahan accepted D13182: Use standard subscribers effects in Herald Adapter for tasks.
Jun 8 2015, 4:59 PM
btrahan accepted D13181: Use standard subscribers effects in Herald Adapter for commits.
Jun 8 2015, 4:59 PM
btrahan accepted D13180: Use standard subscribers effects in Herald Adapter for Phriction.
Jun 8 2015, 4:58 PM
btrahan accepted D13179: Make "ADD_CC" and "REMOVE_CC" available as "standard" Herald effects.
Jun 8 2015, 4:46 PM
btrahan reopened T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI as "Open".

@sshannin is sending me screenshots where this is occurring in the durable column view with asynchronous updates via other users sending messages so I'll take a poke around today in case there's something one off in that code path.

Jun 8 2015, 4:40 PM · Transactions, Conpherence
btrahan reopened T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI, a subtask of T7571: Conpherence v2 Errata, as Open.
Jun 8 2015, 4:40 PM · Conpherence
btrahan accepted D13178: Make ACTION_NOTHING a "standard" action in Herald.
Jun 8 2015, 4:18 PM
btrahan accepted D13177: Consolidate "Subscribers" Herald field value logic.
Jun 8 2015, 4:10 PM
btrahan closed T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI as Resolved.

Can you please re-open with reproduction instructions? Algorithmically speaking, this is impossible AFAIK because we now use the unique transaction ids to guarantee we only render each transaction once.

Jun 8 2015, 4:08 PM · Transactions, Conpherence
btrahan closed T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI, a subtask of T7571: Conpherence v2 Errata, as Resolved.
Jun 8 2015, 4:08 PM · Conpherence
btrahan accepted rPb4de79741ceb: Fix a minor issue with the approval queue.
Jun 8 2015, 3:35 PM
btrahan accepted D13205: Fix an issue with extended policy checks and `@mentions`.
Jun 8 2015, 3:24 PM
btrahan triaged T8468: No conpherence user documentation as Wishlist priority.

What are you finding confusing about Conpherence? (I saw your task about creating rooms - anything else?)

Jun 8 2015, 3:24 PM · Documentation, Conpherence
btrahan closed T8469: Hard to find New Room workflow as Wontfix.

This is by design; we don't want new users creating new rooms as they test out the product, and instead think rooms should be created rarely and with some thought. Also, searching first seems like the right call.

Jun 8 2015, 3:23 PM · Conpherence

Jun 6 2015

btrahan accepted D13176: Stop threading handles through the CustomField + ApplicationSearch pipeline.
Jun 6 2015, 8:00 PM
btrahan accepted D13175: Convert Files to SearchFields.
Jun 6 2015, 7:58 PM
btrahan accepted D13174: Move Pholio to SearchFields.
Jun 6 2015, 7:57 PM

Jun 5 2015

btrahan closed T8451: Add agenda and minutes to meeting calendar events as Wontfix.

I could see (maybe) adding custom fields support to events some day and otherwise sounds like T8032 is going to solve this for us for now. :D

Jun 5 2015, 9:43 PM · Calendar
btrahan closed T8436: customer fields issues as Invalid.

If I read all this correctly, this was asking for the status of two existing bugs and reporting a third. I updated the task description to include links to the actual pertinent tasks here. Note I may have erroneously created the third task but I couldn't quite find it.

Jun 5 2015, 9:42 PM · Custom Fields
btrahan updated the task description for T8436: customer fields issues.
Jun 5 2015, 9:40 PM · Custom Fields
btrahan created T8453: Searching via custom fields doesn't work.
Jun 5 2015, 9:40 PM · Custom Fields
btrahan updated the task description for T8436: customer fields issues.
Jun 5 2015, 9:31 PM · Custom Fields
btrahan accepted D13173: Put Spaces on Hovercards and ObjectItemLists.
Jun 5 2015, 9:09 PM
btrahan accepted D13172: Add a Spaces remarkup rule.
Jun 5 2015, 9:08 PM
btrahan accepted D13171: Support PhabricatorSpacesInterface in ApplicationSearch UI.
Jun 5 2015, 6:19 PM
btrahan accepted D13170: Move some value massaging into SearchFields.
Jun 5 2015, 6:09 PM
btrahan accepted D13169: Begin modularizing fields in SearchEngines.
Jun 5 2015, 6:08 PM
btrahan accepted D13168: Rename `PhabricatorSearchField` to `PhabricatorSearchFieldDocumentType`.
Jun 5 2015, 5:52 PM
btrahan accepted D13166: Give Nuance form sources a web UI.

On the TODO user stuff, I had always assumed we'd do some sort of grey accounts. So something like a contact form could require users to log in, require them to enter an email address (grey account time), or be anonymous (no requestor object associated / created). I had figured a given Item would still have a Source associated with it ("the anonymous user complaint box") but not necessarily a requestor object.

Jun 5 2015, 5:52 PM
btrahan accepted D13163: Add Nuance Queue list/edit/detail views.
Jun 5 2015, 5:44 PM
btrahan accepted D13162: Add a list view for Nuance sources.
Jun 5 2015, 5:37 PM
btrahan awarded D13161: Slightly modernize NuanceSource a Piece of Eight token.
Jun 5 2015, 5:36 PM
btrahan accepted D13161: Slightly modernize NuanceSource.
Jun 5 2015, 5:36 PM
btrahan accepted D13160: Slightly modernize NuanceQueue.
Jun 5 2015, 5:34 PM
btrahan accepted D13159: Support Spaces transactions.

I like shifted and I thought of "translocated" which is fancy for "moved" more or less.

Jun 5 2015, 5:34 PM

Jun 4 2015

btrahan added a comment to D13156: Provide core policy support for Spaces.

Given all these constraints, I think while configuring a space it might be cleanest to have the user think about

Jun 4 2015, 11:48 PM
btrahan added a comment to D13156: Provide core policy support for Spaces.

How do you see the Security case playing out? My idea is that users don't put things in the space; the security guys do so the space is very private and not visible. I do like making people get a notification when they lose visibility, similarly to the task I can't find right now about getting a final notification when you are removed from subscribers

Jun 4 2015, 10:55 PM
btrahan accepted D13156: Provide core policy support for Spaces.

I think spaces being stronger than automatic capabilities is the right call from a product perspective. Mainly, I think losing access to a space should really make you lose access to everything in the space.

Jun 4 2015, 10:04 PM
btrahan accepted D13155: Make policy violation dialog more flexible.
Jun 4 2015, 9:50 PM
btrahan accepted D13154: Add spacePHID infrastructure and implement in Paste.
Jun 4 2015, 9:45 PM
btrahan accepted D13153: Introduce a request cache mechanism.
Jun 4 2015, 9:40 PM
btrahan closed T8421: Default room for Conpherence as Wontfix.

Hey SheerIce -

Jun 4 2015, 9:35 PM · Conpherence
btrahan added a comment to T8429: New Conpherence count appears even if I get an email of the message.

Oh i just re-read your description and it sounds buggy regardless of what you have the conpherence setting set to.

Jun 4 2015, 9:24 PM · Conpherence (v4)
btrahan added a comment to T8429: New Conpherence count appears even if I get an email of the message.

Since Conpherence can override per thread, this is broken out as its own setting:

Jun 4 2015, 9:23 PM · Conpherence (v4)
btrahan accepted D13152: Remove PhabricatorStartup::getGlobal/setGlobal mechanism.
Jun 4 2015, 9:15 PM
btrahan accepted D13151: Make CSRF salt per-user instead of per-request.
Jun 4 2015, 8:27 PM
btrahan accepted rP0fc0af6443f3: Let Maniphest send mail again..
Jun 4 2015, 6:37 PM
btrahan accepted rPef43a9844023: Reload commits before publishing mail about them.
Jun 4 2015, 4:46 PM
btrahan accepted rP4a45620b0458: Reload revisions before publishing mail about them.
Jun 4 2015, 4:42 PM
btrahan accepted rP04a22a8fa443: Fix slop with previous patch, perhaps.
Jun 4 2015, 4:41 PM
btrahan accepted rP98aae51c3dd8: Fix an issue with mentions in transactions.
Jun 4 2015, 4:40 PM
btrahan accepted D13150: Improve the stack traces from phlog($exception).
Jun 4 2015, 4:33 PM
btrahan accepted rP908b426ee20d: Put PhabricatorMetaMTAMailingList back to keep bin/storage adjust happy for now.
Jun 4 2015, 2:21 AM
btrahan added a comment to D13128: Migrate mailing lists to mailing list users.

Jun 4 2015, 12:12 AM
btrahan added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

The "start in Billing" workflow for me is

Jun 4 2015, 12:11 AM · Phacility, Phortune

Jun 3 2015

btrahan added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

I think the usability issue here is that from the admin.phacility.com home page you have Instances, Billing, Documentation, Support.

Jun 3 2015, 11:55 PM · Phacility, Phortune
btrahan closed T8406: How do you change your payment method in Phortune? (Phacility case) as Invalid.

Oh, okay, cool. Thanks!

Jun 3 2015, 11:48 PM · Phacility, Phortune
btrahan created T8406: How do you change your payment method in Phortune? (Phacility case).
Jun 3 2015, 11:40 PM · Phacility, Phortune
btrahan accepted D13142: Send mail to targets in the user's translation.
Jun 3 2015, 11:15 PM
btrahan accepted D13139: Note extra mailing list settings in documentation.
Jun 3 2015, 11:14 PM
btrahan accepted D13138: Allow administrators to configure "Email Settings" settings for lists.

UI seems a little strange for the "self actions" thing -- mailing list users can't take actions, right? -- but probably whatevs.

Jun 3 2015, 11:14 PM
btrahan accepted D13137: Allow administrators to configure "Email Format" settings for lists.
Jun 3 2015, 11:13 PM
btrahan accepted D13136: Allow administrators to edit the "Account" panel for mailing lists and bots.
Jun 3 2015, 11:11 PM
btrahan accepted D13131: Build separate mail for each recipient, honoring recipient access levels.
Jun 3 2015, 11:10 PM
btrahan awarded D13131: Build separate mail for each recipient, honoring recipient access levels a Mountain of Wealth token.
Jun 3 2015, 11:10 PM
btrahan accepted D13144: Fix an issue with AlamancDeviceEditor.

Thanks!

Jun 3 2015, 11:09 PM
btrahan accepted D13130: Fix some minor Spaces method visibility issues.
Jun 3 2015, 11:08 PM
btrahan accepted D13128: Migrate mailing lists to mailing list users.

This won't update Herald rules or saved search queries, but they're presumably rare and infeasibly complex to migrate.

Jun 3 2015, 11:08 PM
btrahan accepted D13125: Allow administrators to manage addresses for mailing list users.
Jun 3 2015, 11:05 PM
btrahan accepted D13129: Remove mailing lists application.
Jun 3 2015, 11:04 PM
btrahan awarded D13129: Remove mailing lists application a Mountain of Wealth token.
Jun 3 2015, 11:04 PM
btrahan accepted D13143: Make PhameBlog implement PhabricatorApplicationTransactionInterface.
Jun 3 2015, 11:04 PM
btrahan accepted D13123: Add "Mailing List" users.
Jun 3 2015, 11:02 PM
btrahan accepted D13122: Expand the power of user filtering.
Jun 3 2015, 10:59 PM

Jun 2 2015

btrahan accepted D13120: Update account roles documentation and remove actAsUser.

Sounds like a plan boss.

Jun 2 2015, 4:57 PM
btrahan claimed T7568: Support Desktop Notifications in Conpherence.
Jun 2 2015, 4:56 PM · Conpherence (v4)
btrahan claimed T4139: Add support for desktop notifications.

Yoinking this. If you've made any progress on this, feel free to post a diff, otherwise I'm on it.

Jun 2 2015, 4:56 PM · Aphlict
btrahan merged task T8384: Subscribe others to wiki page into T4099: Add CC: to Phriction Documents.
Jun 2 2015, 4:54 PM · Phriction
btrahan updated subscribers of T4099: Add CC: to Phriction Documents.
Jun 2 2015, 4:54 PM · Phriction
btrahan accepted D13115: Move all ApplicationTransaction publishing to daemons.

Seems like the right first step to me and hopefully it holds up and the split into a Publisher class won't be necessary.

Jun 2 2015, 4:54 PM
btrahan accepted D13107: Allow TransactionEditor to move publishing work to the daemons.
Jun 2 2015, 4:50 PM

Jun 1 2015

btrahan accepted D13104: Add support for "Extended Policies".
Jun 1 2015, 10:37 PM
btrahan committed rPc83ddc3a0eb3: Spaces - re-jigger application name for new Spaces application (authored by btrahan).
Spaces - re-jigger application name for new Spaces application
Jun 1 2015, 9:53 PM
btrahan closed D13103: Spaces - re-jigger application name for new Spaces application by committing rPc83ddc3a0eb3: Spaces - re-jigger application name for new Spaces application.
Jun 1 2015, 9:53 PM
btrahan added a task to D13103: Spaces - re-jigger application name for new Spaces application: T8377: Build the core "Spaces" Application.
Jun 1 2015, 9:25 PM
btrahan added a revision to T8377: Build the core "Spaces" Application: D13103: Spaces - re-jigger application name for new Spaces application.
Jun 1 2015, 9:25 PM · Spaces, Wikimedia, Policy
btrahan retitled D13103: Spaces - re-jigger application name for new Spaces application from to Spaces - re-jigger application name for new Spaces application.
Jun 1 2015, 9:24 PM
btrahan accepted D13102: Implement DestructibleInterface on Spaces, add some basic tests.
Jun 1 2015, 6:55 PM
btrahan accepted rARC1f2b51c4a396: Fix sanity checks for patch workflow.

Cool. I don't think T8307 impacts too many people, and its nice to see a tracking task. :D

Jun 1 2015, 6:37 PM
btrahan accepted rPf5c9b9c014a7: Make Herald rules more resilient.
Jun 1 2015, 6:36 PM
btrahan accepted rPcb52dd27fcb5: Fix a possible query error in filtering events.
Jun 1 2015, 6:36 PM
btrahan requested changes to D11514: Add a setup check for the XHPAST binary.

Copy changes, etc are coming; just taking off my queue.

Jun 1 2015, 6:22 PM

May 28 2015

btrahan closed T7565: Ship Conpherence v2 as Resolved.

while v2 is done, it kind of got busted up a bit and v3 is the new thing to watch still under active development. Check out the Conpherence workboard to follow along.

May 28 2015, 10:42 PM · Conpherence
btrahan closed T7572: Ship Durable Chat Column as Resolved.

This has outlived its utility as a grouping task.

May 28 2015, 10:41 PM · Conpherence
btrahan closed T7572: Ship Durable Chat Column, a subtask of T7569: Support Feed/Notifications in Conpherence, as Resolved.
May 28 2015, 10:41 PM · Conpherence
btrahan closed T7572: Ship Durable Chat Column, a subtask of T7565: Ship Conpherence v2, as Resolved.
May 28 2015, 10:41 PM · Conpherence
btrahan removed a subtask for T7572: Ship Durable Chat Column: T7558: Conpherence doesn't scroll to bottom in Durable Column regularly.
May 28 2015, 10:40 PM · Conpherence
btrahan removed a parent task for T7558: Conpherence doesn't scroll to bottom in Durable Column regularly: T7572: Ship Durable Chat Column.
May 28 2015, 10:40 PM · Conpherence (v4)