Paths

Table of Contentst

Add a setup check for the XHPAST binary
Needs RevisionPublic
Actions

Authored by epriestley on Jan 27 2015, 7:29 AM.

Details

Reviewers

joshuaspence
btrahan

Group Reviewers

Blessed Reviewers

Summary

Adds a setup check which verifies that the XHPAST binary is built and up-to-date.

Test Plan

Deleted the XHPAST binary and saw the xhpast.binary setup issue.
Built an older version of XHPAST and saw the xhpast.version setup issue.
Built the latest version of XHPAST and saw no setup issues.

Diff Detail

Repository

rP Phabricator

Branch

arcpatch-D11514

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4272
Build 6135: [Placeholder Plan] Wait for 30 Seconds
Build 4285: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27693.Jan 27 2015, 7:29 AM

joshuaspence retitled this revision from to Ensure that `PhutilDefaultSyntaxHighlighterEngine` uses XHPAST for highlighting PHP.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 27 2015, 7:29 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence mentioned this in D11517: Create a PHP wrapper class for the XHPAST binary.Jan 27 2015, 10:19 AM

joshuaspence updated this object.Jan 27 2015, 10:22 AM

joshuaspence edited edge metadata.

I suspect the web user will frequently (or, frequently enough to cause support headaches) not have permission to perform the build, or GCC will not be installed, and I don't want new installs to explode when highlighting PHP code.

I'm hesitant to do this build from a web process at all because it may take significantly longer than all other setup/init sorts of checks (it takes a few seconds on my machine).

I'd accept a config warning about out-of-date / unbuilt XHPAST in Phabricator. It could maybe try to rebuild if the user presses a button to trigger it, but I don't want the autorebuild to occur by default. I also suspect the success rate will be low enough that this will frustrate users overall versus just giving them the command to run.

This revision now requires changes to proceed.Jan 27 2015, 2:23 PM

Yeah, a setup check sounds better. Let me see if I can make that happen.

Setup checks instead

joshuaspence retitled this revision from Ensure that `PhutilDefaultSyntaxHighlighterEngine` uses XHPAST for highlighting PHP to Add a setup check for the XHPAST binary.Jan 27 2015, 8:51 PM

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

joshuaspence updated this object.Feb 2 2015, 7:51 AM

Rebase this on the static class and I can write some copy in the pull? The checks are good but I want to soften the language of the first one.

This revision now requires changes to proceed.Feb 2 2015, 2:02 PM

Rebase after D11517

derp

epriestley accepted this revision.May 19 2015, 3:24 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 3:24 PM

I want to rewrite the copy on this one but some stuff came up, let me just steal it for the moment.

This revision now requires review to proceed.May 19 2015, 3:56 PM

Copy changes, etc are coming; just taking off my queue.

This revision now requires changes to proceed.Jun 1 2015, 6:22 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

phpast/

check/

PhabricatorXHPASTSetupCheck.php

22 lines

Diff 28016

View Options

src/__phutil_library_map__.php