Expand the power of user filtering
ClosedPublic
Actions

Authored by epriestley on Jun 2 2015, 5:27 PM.

Details

Reviewers

Maniphest Tasks

T8044: On /people/query make it possible to query for only non-disabled users
T8387: Convert Mailing Lists into special users, similar to bot users

Commits

Restricted Diffusion Commit
rP13f0dac0ed7c: Expand the power of user filtering

Summary

Ref T8387. This mostly merges D10565 + D10480. I'm going to touch this to add mailing list stuff shortly so I wanted to clean those up.

This isn't super pretty but is fully flexible and consistent with other modern query UIs.

This should be more-or-less backward compatible.

Test Plan

Fiddled with the new options.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31681.Jun 2 2015, 5:27 PM

epriestley retitled this revision from to Expand the power of user filtering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8387: Convert Mailing Lists into special users, similar to bot users.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 2 2015, 5:27 PM

epriestley mentioned this in D10565: Make "Active" the default query for People.Jun 2 2015, 5:28 PM

epriestley mentioned this in D10480: Filter by active users.

cburroughs added a subscriber: cburroughs.Jun 2 2015, 5:33 PM

eadler added a task: T8044: On /people/query make it possible to query for only non-disabled users.Jun 3 2015, 4:08 AM

eadler added a subscriber: eadler.

btrahan accepted this revision.Jun 3 2015, 10:59 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2015, 10:59 PM

Closed by commit rP13f0dac0ed7c: Expand the power of user filtering (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2015, 1:43 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T8454: User approval not working.Jun 6 2015, 1:41 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

query/

PhabricatorPeopleQuery.php

10 lines

PhabricatorPeopleSearchEngine.php

121 lines

Diff 31759

View Options

src/applications/people/query/PhabricatorPeopleQuery.php