Page MenuHomePhabricator
Create Task
Maniphest T8453

Searching via custom fields doesn't work
Closed, InvalidPublic
Actions

Description

I think T8436 had a real bug in it, while also asking about the status of two other bugs.

Reproduce:

  • turn on a custom field for maniphest by cutting and pasting the sample config provided, but add "search" : true, as one of the entries.
  • make a task and set estimated hours to 10
  • search for tasks with estimated hours of 10

Expected:

  • see the task you just made as the only result

Actual:

  • no results

Related Objects

Event Timeline

btrahan created this task.Jun 5 2015, 9:40 PM
btrahan raised the priority of this task from to Normal.
btrahan updated the task description. (Show Details)
btrahan added a project: Custom Fields.
btrahan mentioned this in T8436: customer fields issues.
btrahan added a subscriber: btrahan.
epriestley added a subscriber: epriestley.Jun 5 2015, 10:20 PM

I can't reproduce this:

Screen Shot 2015-06-05 at 3.19.50 PM.png (437×1 px, 46 KB)

joshuaspence added a subscriber: joshuaspence.Jun 5 2015, 11:39 PM
epriestley added a comment.Jun 8 2015, 6:59 PM

One thought -- what type of field were you using? I tried reproing it with an "int" field, but maybe the issue is with certain field types or something like that.

btrahan updated the task description. (Show Details)Jun 8 2015, 7:00 PM

{"mycompany:estimated-hours": {"name": "Estimated Hours", "type": "int", "caption": "Estimated number of hours this will take.", "search" : true}}

epriestley added a comment.Jun 8 2015, 7:01 PM

Thanks!

btrahan added a comment.Jun 8 2015, 7:02 PM

I'm updating my instance but will confirm it still repros when its back up

epriestley added a comment.Jun 8 2015, 7:03 PM

Seems OK here, here's the create / detail / search UI:

Screen Shot 2015-06-08 at 12.02.09 PM.png (974×1 px, 125 KB)

Screen Shot 2015-06-08 at 12.02.17 PM.png (974×1 px, 192 KB)

Screen Shot 2015-06-08 at 12.02.35 PM.png (1×1 px, 195 KB)

btrahan closed this task as Invalid.Jun 8 2015, 7:05 PM
btrahan claimed this task.

Repro'd for me then I edited the field and it didn't repro anymore. Maybe I had a daemon error or something, or all the changes here fixed it?

btrahan added a comment.Jun 8 2015, 7:06 PM

(confirmed did not repro when I made another new task either)

epriestley added a comment.Jun 8 2015, 7:06 PM

The index should update without needing the daemons, but that code did get touched in connection with T6367, so maybe I fixed something by accident.

tao_qiping reopened this task as Open.Jun 11 2015, 1:24 PM
tao_qiping added a subscriber: tao_qiping.

Sorry I raised T8436, as this ticket is focus on search custom field. so I re-open it again as I still can re-repro it on list field, below is my custom field. can u please verify a list field to see if it is fixed, if so I may need to update my code to latest.

"tke:system": { 
     "name": "System", 
      "required": true, 
      "type": "select", 
      "search": true, 
      "copy": true, 
      "options": [ "", "SharePoint", "Agent Appointment", "Agent Registration", "AR Overdue", "Business Travel Approval", "CAPA (Corrective Instruction)", "Cash Advance Approval"]
      }
chad added a subscriber: chad.Jun 11 2015, 1:29 PM

We only accept bug reports against HEAD. You're expected to update Phabricator before filing any issue. Thanks!

btrahan added a comment.Jun 11 2015, 6:23 PM
In T8453#120118, @tao_qiping wrote:

Sorry I raised T8436, as this ticket is focus on search custom field. so I re-open it again as I still can re-repro it on list field, below is my custom field. can u please verify a list field to see if it is fixed, if so I may need to update my code to latest.

"tke:system": { 
     "name": "System", 
      "required": true, 
      "type": "select", 
      "search": true, 
      "copy": true, 
      "options": [ "", "SharePoint", "Agent Appointment", "Agent Registration", "AR Overdue", "Business Travel Approval", "CAPA (Corrective Instruction)", "Cash Advance Approval"]
      }

Minimally, the "options" field is incorrect as its a list and not a dictionary. See https://secure.phabricator.com/book/phabricator/article/custom_fields/#advanced-custom-fields and the "options" section. I would expect this to fail since its misconfigured.

We could possibly do a better job detecting this misconfiguration.

btrahan closed this task as Invalid.EditedJun 11 2015, 6:23 PM
btrahan mentioned this in T8516: Better detect misconfiguration of "options" in custom field.

See T8516 for the "detect misconfiguration better" task.

After you update to HEAD and fix your configuration, please do file specific bug(s) with anything you find. Thanks!

tao_qiping added a comment.Jun 13 2015, 3:27 PM

Just for update, I updated to latest code, the custom field search (list type) is working, even per @btrahan it is a wrong configure.

Phabricator · Built by Phacility