Page MenuHomePhabricator

Improve the stack traces from phlog($exception)
ClosedPublic

Authored by epriestley on Jun 4 2015, 1:08 PM.
Tags
None
Referenced Files
F14480838: D13150.diff
Sun, Dec 29, 11:16 PM
Unknown Object (File)
Fri, Dec 27, 8:17 AM
Unknown Object (File)
Fri, Dec 20, 5:11 PM
Unknown Object (File)
Tue, Dec 17, 11:14 AM
Unknown Object (File)
Sun, Dec 8, 6:51 PM
Unknown Object (File)
Fri, Dec 6, 4:55 AM
Unknown Object (File)
Thu, Dec 5, 7:44 PM
Unknown Object (File)
Thu, Dec 5, 12:06 PM
Subscribers

Details

Summary

Fixes T8331. When we throw an uncaught exception in Phabricator, it sometimes ends up getting phlog()'d.

The traces this function prints out are from the phlog() call, not the original exception. This reduces their diagnostic value significantly.

Since we can build reasonable compound stack traces for complex exceptions now, just create a complex exception (don't throw it) and use that stack instead.

Test Plan

Used this patch to get a reasonable stack for T8415.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve the stack traces from phlog($exception).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2015, 4:33 PM
This revision was automatically updated to reflect the committed changes.