Paths

Table of Contentst

Differential D13123

Add "Mailing List" users
ClosedPublic
Actions

Authored by epriestley on Jun 2 2015, 6:28 PM.

Tags

None

Referenced Files

	F14021020: D13123.id31761.diff
	Wed, Nov 6, 4:39 AM

	F14021019: D13123.id.diff
	Wed, Nov 6, 4:39 AM

	F14014921: D13123.diff
	Sun, Nov 3, 10:14 AM

	F14010088: D13123.id31683.diff
	Thu, Oct 31, 4:43 AM

	F14001207: D13123.id31682.diff
	Fri, Oct 25, 5:11 AM

	F13985564: D13123.diff
	Sun, Oct 20, 9:22 PM

	F13985446: D13123.diff
	Sun, Oct 20, 8:31 PM

	F13985438: D13123.diff
	Sun, Oct 20, 8:30 PM

Subscribers

tycho.tatitscheff

Details

Reviewers

Maniphest Tasks

T8387: Convert Mailing Lists into special users, similar to bot users

Commits

Restricted Diffusion Commit
rP992c19957760: Add "Mailing List" users

Summary

Ref T8387. Adds new mailing list users.

This doesn't migrate anything yet. I also need to update the "Email Addresses" panel to let administrators change the list address.

Test Plan

Created and edited a mailing list user.
Viewed profile.
Viewed People list.
Searched for lists / nonlists.
Grepped for all uses of getIsDisabled() / getIsSystemAgent() and added relevant corresponding behaviors.
Hit the web/api/ssh session blocks.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31682.Jun 2 2015, 6:28 PM

epriestley retitled this revision from to Add "Mailing List" users.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8387: Convert Mailing Lists into special users, similar to bot users.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 2 2015, 6:28 PM

Don't require "create non-bot users" to see /people/create/ any more.

Hum.

I remember than once i need to login via bot web interface to get cli-token to install certificates.
Since using parameter we can only create "api-xxxxxxxxxxxx" tokens and no "cli-xxxxxxxxxxxxxxx". And since isntallle certificate direclty is depreciated.

eadler added a subscriber: eadler.Jun 3 2015, 4:17 AM

btrahan accepted this revision.Jun 3 2015, 11:02 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/people/storage/PhabricatorUser.php
118–156	these are nice

This revision is now accepted and ready to land.Jun 3 2015, 11:02 PM

Closed by commit rP992c19957760: Add "Mailing List" users (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2015, 1:43 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D13239: Don't require users be activated in order to establish Web sessions.Jun 10 2015, 8:24 PM

epriestley mentioned this in rP8d6209b70113: Don't require users be activated in order to establish Web sessions.Jun 10 2015, 10:34 PM

epriestley mentioned this in T8574: Users receiving many duplicate emails.Jun 16 2015, 10:49 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150602.mlist.1.sql

2 lines

scripts/

ssh/

6 lines

user/

account_admin.php

4 lines

src/

applications/

auth/

engine/

PhabricatorAuthSessionEngine.php

16 lines

conduit/

controller/

PhabricatorConduitAPIController.php

6 lines

settings/

PhabricatorConduitTokensSettingsPanel.php

4 lines

diffusion/

panel/

DiffusionSetPasswordSettingsPanel.php

4 lines

people/

conduit/

UserConduitAPIMethod.php

3 lines

controller/

PhabricatorPeopleCreateController.php

53 lines

PhabricatorPeopleListController.php

10 lines

PhabricatorPeopleNewController.php

27 lines

customfield/

PhabricatorUserRolesField.php

3 lines

editor/

PhabricatorUserEditor.php

37 lines

phid/

PhabricatorPeopleUserPHIDType.php

4 lines

query/

PhabricatorPeopleQuery.php

13 lines

PhabricatorPeopleSearchEngine.php

25 lines

storage/

PhabricatorUser.php

46 lines

PhabricatorUserLog.php

2 lines

typeahead/

PhabricatorPeopleDatasource.php

8 lines

settings/

controller/

PhabricatorSettingsMainController.php

2 lines

panel/

PhabricatorConduitCertificateSettingsPanel.php

8 lines

PhabricatorSSHKeysSettingsPanel.php

4 lines

Diff 31761

resources/sql/autopatches/20150602.mlist.1.sql

Loading...

scripts/ssh/ssh-exec.php

Loading...

scripts/user/account_admin.php

Loading...

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...

src/applications/conduit/settings/PhabricatorConduitTokensSettingsPanel.php

Loading...

src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php

Loading...

src/applications/people/conduit/UserConduitAPIMethod.php

Loading...

src/applications/people/controller/PhabricatorPeopleCreateController.php

Loading...

src/applications/people/controller/PhabricatorPeopleListController.php

Loading...

src/applications/people/controller/PhabricatorPeopleNewController.php

Loading...

src/applications/people/customfield/PhabricatorUserRolesField.php

Loading...

src/applications/people/editor/PhabricatorUserEditor.php

Loading...

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

Loading...

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...

src/applications/people/query/PhabricatorPeopleSearchEngine.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...

src/applications/people/storage/PhabricatorUserLog.php

Loading...

src/applications/people/typeahead/PhabricatorPeopleDatasource.php

Loading...

src/applications/settings/controller/PhabricatorSettingsMainController.php

Loading...

src/applications/settings/panel/PhabricatorConduitCertificateSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php

Loading...