Page MenuHomePhabricator

Give Nuance form sources a web UI
ClosedPublic

Authored by epriestley on Jun 5 2015, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 6:40 PM
Unknown Object (File)
Tue, Apr 9, 10:36 PM
Unknown Object (File)
Tue, Apr 2, 2:36 AM
Unknown Object (File)
Sun, Mar 24, 3:15 AM
Unknown Object (File)
Sun, Mar 24, 3:15 AM
Unknown Object (File)
Sun, Mar 24, 3:15 AM
Unknown Object (File)
Fri, Mar 22, 10:55 PM
Unknown Object (File)
Mar 10 2024, 4:18 PM
Subscribers

Details

Summary

Ref T8434. Hard-codes form sources as a complaint form.

This form is close to perfect and I'm not actually sure we need to let users customize it at all.

Test Plan

Screen Shot 2015-06-05 at 6.14.52 AM.png (868×1 px, 121 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Nuance form sources a web UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/nuance/application/PhabricatorNuanceApplication.php
65–66

I gave sources the /action/ route at the root, so we could eventually have /action/security/ or /action/bug/ or whatever. Not sure how cool/useful this is, but it seemed reasonable and a bit nicer/friendlier than /nuance/source/act/1/.

btrahan edited edge metadata.

On the TODO user stuff, I had always assumed we'd do some sort of grey accounts. So something like a contact form could require users to log in, require them to enter an email address (grey account time), or be anonymous (no requestor object associated / created). I had figured a given Item would still have a Source associated with it ("the anonymous user complaint box") but not necessarily a requestor object.

It gets more complicated with things like Twitter. The "requestor" object was thus supposed to map to things like users, grey users, twitter handles, etc. I had hoped to have requestor technology around collapsing these things too, so we can get a bit of a CRM situation going where if someone sends us an email and complains on twitter and somewhere else we can talk to them in all these places pretty easily. (A more simple scenario is trying to get someone off social media and into a more private correspondence to trouble shoot.) Another important piece to make explicit here is for a given requestor its really important to be able to go through all their past issues quickly.

src/applications/nuance/application/PhabricatorNuanceApplication.php
65–66

This revision is now accepted and ready to land.Jun 5 2015, 5:52 PM

Yeah, that all makes sense. I think this is consistent with that, with two changes:

  • I made the simplifying assumption that the "form" source is only available for real logged-in users, since that's easy and true for now.
  • I assumed we'll probably always have some Requestor, even if it's the "we have no clue who or what this person is" Requestor, just to make other logic simpler. It might be a twitter account, it might be a grey user, it might be a real user, it might be something else entirely, or it might be some empty/mystery requestor. Maybe this ends up not really making things easier, though.

(Overall this stuff is generally in pretty good shape and I'm excited to build it at some point, although it now looks like that won't be right this second.)

This revision was automatically updated to reflect the committed changes.