Page MenuHomePhabricator

Move some value massaging into SearchFields
ClosedPublic

Authored by epriestley on Jun 5 2015, 4:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 5:40 AM
Unknown Object (File)
Fri, Mar 22, 12:35 PM
Unknown Object (File)
Wed, Mar 13, 6:48 AM
Unknown Object (File)
Thu, Mar 7, 5:36 PM
Unknown Object (File)
Sun, Mar 3, 12:38 PM
Unknown Object (File)
Feb 24 2024, 8:20 PM
Unknown Object (File)
Feb 24 2024, 8:03 PM
Unknown Object (File)
Feb 24 2024, 7:55 PM
Subscribers

Details

Summary

Ref T8441. Ref T7715. Let SearchFields do some value massaging before buiding queries so we don't have to work as hard in each SearchEngine. Particularly, they can handle evaluateTokens() from Tokenizers.

Test Plan

Paste automatically gained access to viewer(), etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move some value massaging into SearchFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/paste/query/PhabricatorPasteSearchEngine.php
18–32

It still feels a little weak that we have to specify this and can't just infer the mapping from the fields, but I think it's pretty reasonable and don't see a way around it without some junk that involves $query->$method($value), which I don't want to get involved with.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2015, 6:09 PM
This revision was automatically updated to reflect the committed changes.