Page MenuHomePhabricator

Migrate mailing lists to mailing list users
ClosedPublic

Authored by epriestley on Jun 2 2015, 10:19 PM.
Tags
None
Referenced Files
F13313817: D13128.id31762.diff
Tue, Jun 11, 12:11 PM
F13311111: D13128.id.diff
Tue, Jun 11, 1:00 AM
F13310447: D13128.id31695.diff
Mon, Jun 10, 1:48 PM
F13284735: D13128.diff
Mon, Jun 3, 9:07 AM
F13269916: D13128.diff
Wed, May 29, 8:10 AM
F13259504: D13128.diff
Sun, May 26, 9:25 PM
F13251001: D13128.id.diff
Fri, May 24, 7:13 PM
F13221161: D13128.diff
Sun, May 19, 2:18 AM
Subscribers

Details

Summary

Ref T8387. This migrates lists in the database to users, and replaces all subscriptions.

This won't update Herald rules or saved search queries, but they're presumably rare and infeasibly complex to migrate.

Test Plan

This migration is relatively re-runnable, so I ran it a bunch of times with different setups using bin/storage adjust --apply. It successfully migrated lists into users and replaced them in all the places they were subscribed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Migrate mailing lists to mailing list users.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

This won't update Herald rules or saved search queries, but they're presumably rare and infeasibly complex to migrate.

How would these things break post killing mailing lists app? I am very comfortable with breaking them, I just would want users to be able to recover via the web ui.

This revision is now accepted and ready to land.Jun 3 2015, 11:08 PM

Break behavior for Herald should be clean at HEAD -- it got buffed up pretty substantially in D12957 for dealing with a similar case out of T7604.

Search will not find matching results, but shouldn't explode either.

This revision was automatically updated to reflect the committed changes.