Page MenuHomePhabricator

Begin modularizing fields in SearchEngines
ClosedPublic

Authored by epriestley on Jun 5 2015, 4:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 12:38 PM
Unknown Object (File)
Sun, Mar 3, 12:37 PM
Unknown Object (File)
Sun, Mar 3, 12:37 PM
Unknown Object (File)
Sun, Mar 3, 12:37 PM
Unknown Object (File)
Feb 24 2024, 7:52 PM
Unknown Object (File)
Feb 9 2024, 4:56 AM
Unknown Object (File)
Feb 7 2024, 7:11 PM
Unknown Object (File)
Feb 3 2024, 4:45 AM
Subscribers

Details

Summary

Ref T8441. Ref T7715. Add a layer of indirection to fields in search engines. This will allow us to:

  • Simplify SearchEngine code, which has collected a lot of duplication around expressing what is effectively field types.
  • Automatically add fields like "Spaces" and "Projects" (primary driver for T8441).
  • Reorder or hide fields (not sure if we really want to do this, but it seems plausible, and this will let us play around with it, at least).
  • Drive Conduit Query methods via SearchEngines, so the same code specifies both the search UI and the application.query endpoint (primary driver in T7715).
Test Plan
  • Searched for stuff in Paste, everything behaved exaclty like it used to (except that I removed the "no language" checkbox, which seemed like fluff from a bygone era).
  • Searched for stuff in other applications, saw no changes.
  • Hit date field errors.
  • Used query strings to specify values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Begin modularizing fields in SearchEngines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Actually use the read pathway.
epriestley added inline comments.
src/applications/search/field/PhabricatorSearchUsersField.php
17

This stuff is copied ~verbatim from SearchEngine, but the idea is that this will eventually be the new copy of it, instead of SearchEngine gradually growing a thousand different readValuesOfTypeXFromRequest().

btrahan edited edge metadata.
btrahan added inline comments.
src/applications/search/field/PhabricatorSearchUsersField.php
17

This revision is now accepted and ready to land.Jun 5 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.