Page MenuHomePhabricator

Introduce a request cache mechanism
ClosedPublic

Authored by epriestley on Jun 4 2015, 7:19 PM.
Tags
None
Referenced Files
F14442940: D13153.diff
Thu, Dec 26, 9:16 AM
Unknown Object (File)
Tue, Dec 24, 10:58 PM
Unknown Object (File)
Tue, Dec 24, 10:58 PM
Unknown Object (File)
Tue, Dec 24, 10:58 PM
Unknown Object (File)
Tue, Dec 24, 7:35 AM
Unknown Object (File)
Sat, Dec 14, 12:22 AM
Unknown Object (File)
Thu, Dec 12, 10:37 PM
Unknown Object (File)
Tue, Dec 10, 3:49 AM
Subscribers

Details

Summary

Ref T8424. This adds a standard KeyValueCache to serve as a request cache.

In particular, I need to cache Spaces (they are frequently accessed, sometimes by multiple viewers) but not have them survive longer than the scope of one request.

This request cache is explicitly destroyed by each web request and each daemon request.

In the very long term, building this kind of construct supports reusing PHP interpreters to run web requests (see some discussion in T2312).

Test Plan
  • Added and executed unit tests.
  • Ran every daemon.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable